Skip to content

Commit 16a3fcf

Browse files
committed
fix: missing required files should count as an error
1 parent 1bbd89f commit 16a3fcf

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/main/java/org/entur/gbfs/validation/validator/FileValidator.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,9 @@ public void validateMissingFile(FileValidationResult fvr) {
110110
fvr.setVersion(version.getVersionString());
111111
fvr.setSchema(version.getSchema(fvr.getFile()).toString());
112112
fvr.setRequired(version.isFileRequired(fvr.getFile()));
113+
if (version.isFileRequired(fvr.getFile())) {
114+
fvr.setErrorsCount(1);
115+
}
113116
}
114117
}
115118
}

src/test/java/org/entur/gbfs/validation/validator/GbfsJsonValidatorTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,8 @@ void testMissingRequiredFile() {
214214

215215
Assertions.assertTrue(result.getFiles().get("system_information").isRequired());
216216
Assertions.assertFalse(result.getFiles().get("system_information").isExists());
217+
218+
Assertions.assertEquals(1, result.getSummary().getErrorsCount());
217219
}
218220

219221
@Test

0 commit comments

Comments
 (0)