feat: service id with no active day validator (#2094)

* feat: service id with no active day validator

* fix: check

Author: cka-y

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/ServiceHasNoActiveDayOfTheWeekValidator.java

@@ -0,0 +1,60 @@
+package org.mobilitydata.gtfsvalidator.validator;
+
+import javax.inject.Inject;
+import org.mobilitydata.gtfsvalidator.annotation.GtfsValidationNotice;
+import org.mobilitydata.gtfsvalidator.annotation.GtfsValidator;
+import org.mobilitydata.gtfsvalidator.notice.NoticeContainer;
+import org.mobilitydata.gtfsvalidator.notice.SeverityLevel;
+import org.mobilitydata.gtfsvalidator.notice.ValidationNotice;
+import org.mobilitydata.gtfsvalidator.table.GtfsCalendar;
+import org.mobilitydata.gtfsvalidator.table.GtfsCalendarSchema;
+import org.mobilitydata.gtfsvalidator.table.GtfsCalendarService;
+import org.mobilitydata.gtfsvalidator.table.GtfsCalendarTableContainer;
+
+@GtfsValidator
+public class ServiceHasNoActiveDayOfTheWeekValidator extends FileValidator {
+  private final GtfsCalendarTableContainer calendarTable;
+
+  @Inject
+  ServiceHasNoActiveDayOfTheWeekValidator(GtfsCalendarTableContainer calendarTable) {
+    this.calendarTable = calendarTable;
+  }
+
+  private boolean hasNoActiveDayOfTheWeek(GtfsCalendar calendar) {
+    return calendar.monday() == GtfsCalendarService.NOT_AVAILABLE
+        && calendar.tuesday() == GtfsCalendarService.NOT_AVAILABLE
+        && calendar.wednesday() == GtfsCalendarService.NOT_AVAILABLE
+        && calendar.thursday() == GtfsCalendarService.NOT_AVAILABLE
+        && calendar.friday() == GtfsCalendarService.NOT_AVAILABLE
+        && calendar.saturday() == GtfsCalendarService.NOT_AVAILABLE
+        && calendar.sunday() == GtfsCalendarService.NOT_AVAILABLE;
+  }
+
+  @Override
+  public void validate(NoticeContainer noticeContainer) {
+    calendarTable.getEntities().stream()
+        .filter(calendar -> calendar.hasServiceId() && hasNoActiveDayOfTheWeek(calendar))
+        .forEach(
+            calendar ->
+                noticeContainer.addValidationNotice(
+                    new ServiceHasNoActiveDayOfTheWeekNotice(
+                        calendar.csvRowNumber(), calendar.serviceId())));
+  }
+
+  /** A service is not valid for any day of the week. */
+  @GtfsValidationNotice(
+      severity = SeverityLevel.WARNING,
+      files = @GtfsValidationNotice.FileRefs({GtfsCalendarSchema.class}))
+  static class ServiceHasNoActiveDayOfTheWeekNotice extends ValidationNotice {
+    /** The row number in calendar.txt where the error occurs. */
+    private final int csvRowNumber;
+
+    /** The service_id field value. */
+    private final String serviceId;
+
+    ServiceHasNoActiveDayOfTheWeekNotice(int csvRowNumber, String serviceId) {
+      this.csvRowNumber = csvRowNumber;
+      this.serviceId = serviceId;
+    }
+  }
+}

main/src/test/java/org/mobilitydata/gtfsvalidator/validator/ServiceHasNoActiveDayOfTheWeekValidatorTest.java

@@ -0,0 +1,60 @@
+package org.mobilitydata.gtfsvalidator.validator;
+
+import static com.google.common.truth.Truth.assertThat;
+
+import com.google.common.collect.ImmutableList;
+import java.util.List;
+import org.junit.Test;
+import org.mobilitydata.gtfsvalidator.notice.NoticeContainer;
+import org.mobilitydata.gtfsvalidator.notice.ValidationNotice;
+import org.mobilitydata.gtfsvalidator.table.GtfsCalendar;
+import org.mobilitydata.gtfsvalidator.table.GtfsCalendarTableContainer;
+
+public class ServiceHasNoActiveDayOfTheWeekValidatorTest {
+  private record CalendarMetadata(String serviceId, boolean hasADayOfTheWeek) {}
+
+  private static List<GtfsCalendar> createCalendarTable(
+      List<CalendarMetadata> calendarMetadataList) {
+    return calendarMetadataList.stream()
+        .map(
+            calendarMetadata -> {
+              GtfsCalendar.Builder builder =
+                  new GtfsCalendar.Builder()
+                      .setCsvRowNumber(1)
+                      .setServiceId(calendarMetadata.serviceId());
+              if (calendarMetadata.hasADayOfTheWeek) {
+                builder.setMonday(1);
+              }
+              return builder.build();
+            })
+        .collect(ImmutableList.toImmutableList());
+  }
+
+  private static List<ValidationNotice> generateNotices(
+      List<CalendarMetadata> calendarMetadataList) {
+    NoticeContainer noticeContainer = new NoticeContainer();
+    new ServiceHasNoActiveDayOfTheWeekValidator(
+            GtfsCalendarTableContainer.forEntities(
+                createCalendarTable(calendarMetadataList), noticeContainer))
+        .validate(noticeContainer);
+    return noticeContainer.getValidationNotices();
+  }
+
+  @Test
+  public void serviceHasNoActiveDayOfTheWeek() {
+    List<CalendarMetadata> calendarMetadataList =
+        ImmutableList.of(
+            new CalendarMetadata("service_1", false), new CalendarMetadata("service_2", true));
+    List<ValidationNotice> notices = generateNotices(calendarMetadataList);
+    assertThat(notices.size()).isEqualTo(1);
+  }
+
+  @Test
+  public void serviceHasAnActiveDayOfTheWeek() {
+    List<CalendarMetadata> calendarMetadataList =
+        ImmutableList.of(
+            new CalendarMetadata("service_1", true), new CalendarMetadata("service_2", true));
+    List<ValidationNotice> notices = generateNotices(calendarMetadataList);
+    assertThat(notices).isEmpty();
+  }
+}