fix: update TripAndShapeDistanceValidator to ignore shape with no shape_dist_traveled (#2018)

Some GTFS feeds do not provide shape_dist_traveled in shapes.txt
In this case, the value is set to 0 in the code, so sorting shapes based
on ShapeDistTraveled does not work and usually returns the first shape
row.

It leads to an error, the first shape of the shape is usually very far
away from the last stop of the trips following the shape.

We can assume the biggest shape_dist_traveled of a given shape should
never be 0, otherwise it means the value is not set. In this case, we
return early to ensure no validation error will be issued.

Fixes #2018

Author: thelleboid-tsr

main/src/main/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidator.java

@@ -84,6 +84,11 @@ public void validate(NoticeContainer noticeContainer) {
               }
 
               double maxShapeDist = maxShape.shapeDistTraveled();
+
+              if (maxShapeDist == 0) {
+                return;
+              }
+
               double distanceInMeters =
                   getDistanceMeters(maxShape.shapePtLatLon(), stop.stopLatLon());
               if (maxStopTimeDist > maxShapeDist) {

main/src/test/java/org/mobilitydata/gtfsvalidator/validator/TripAndShapeDistanceValidatorTest.java

@@ -108,6 +108,24 @@ public void testTripDistanceExceedsShapeDistance() {
     assertThat(found).isTrue();
   }
 
+  @Test
+  public void testTripDistanceExceedsShapeDistanceNoShapeDistance() {
+    List<ValidationNotice> notices =
+        generateNotices(
+            createTripTable(2),
+            createStopTimesTable(1, 10.0),
+            createShapeTable(1, 0.0, 10.0),
+            createStopTable(1));
+    boolean found =
+        notices.stream()
+            .anyMatch(
+                notice ->
+                    notice
+                        instanceof
+                        TripAndShapeDistanceValidator.TripDistanceExceedsShapeDistanceNotice);
+    assertThat(found).isFalse();
+  }
+
   @Test
   public void testTripDistanceExceedsShapeDistanceWarning() {
     List<ValidationNotice> notices =