v4.2.0 · MobilityData gtfs-validator · Discussion #1614 · GitHub

emmambd
Nov 27, 2023
Maintainer

Overview

This release includes

Support for time variable fares that was adopted in GTFS in July 2023
A new summary section of the validation report, including tags to see if a feed has GTFS components like Blocks, Frequencies, or Fares v2
Automatic generation of the RULES documentation on https://gtfs-validator.mobilitydata.org/rules.html
New releases published to Maven

New notices

invalid_input_files_in_subfolder 🔴 ERROR, added to the spec in Forbid subfolders in GTFS files google/transit#379
trip_distance_exceeds_shape_distance 🔴 ERROR, added to the spec in Specify stop times shape_dist_traveled must not exceed the trip shape's maximum distance google/transit#380
missing_bike_allowance 🟠WARNING, added to best practices in suggest explicit bikes_allowed for ferry trips to avoid big detours GTFS_Schedule_Best-Practices#55
missing_feed_contact_email_and_url 🟠WARNING
unused_parent_station ⚪ INFO

Notices for Fares v2 - time variable fares, added to the spec in google/transit#357

timeframe_overlap 🔴 ERROR
timeframe_only_start_or_end_time_specified 🔴 ERROR
timeframe_start_or_end_time_greater_than_twenty_four_hours 🔴 ERROR

Changed notices

Downgraded platform_without_parent_station 🟠WARNING → ⚪ INFO
Replaced missing_timepoint_column 🟠WARNING → missing_recommended_column 🟠WARNING

Impacts on existing data

You can find the impact of this release on all existing datasets we have in the Mobility database in this spreadsheet.

Full Changelog: v4.1.0...v4.2.0

New Contributors

@mijogu made their first contribution in feat: integrate Cypress for E2E testing #1396
@ryon made their first contribution in feat: report link sharing #1397
@jcpitre made their first contribution in fix: Modified to accept mime type encountered on Windows #1439
@lottspot made their first contribution in fix(web/service): change permissions for application.properties, service acount json, & newrelic.yml #1453
@cka-y made their first contribution in feat: Added route names component #1469
@qcdyx made their first contribution in feat: 1465 add a route colors gtfs component #1492
@bradyhunsaker made their first contribution in feat: Add a rule that stations (location_type 1) must be the parent_station of some stop (location_type 0). #1493
@Whoops made their first contribution in fix: don't throw exception on calendar with no days #1519
@emmambd made their first contribution in docs: Update core developers list #1550
@1Maxnet1 made their first contribution in docs: Fix Link in README.md #1546
@fredericsimard made their first contribution in Small fix, required double-quotes #1558

What's Changed

Rules

fix: Downgraded platform_without_parent_station notice to info by @jcpitre in fix: Downgraded platform_without_parent_station notice to info #1444
feat: Add a rule that stations (location_type 1) must be the parent_station of some stop (location_type 0). by @bradyhunsaker in feat: Add a rule that stations (location_type 1) must be the parent_station of some stop (location_type 0). #1493
feat: Added missing_recommended_column notice by @jcpitre in feat: Added missing_recommended_column notice #1470
feat: Validation for timeframes.txt by @bdferris-v2 in feat: Validation for timeframes.txt #1518
feat: 1423 only warn if feed contact email or url are both unset by @qcdyx in feat: 1423 only warn if feed contact email or url are both unset #1514
feat: validator for ferry trips + bikes allowance by @cka-y in feat: validator for ferry trips + bikes allowance #1510
feat: 1504 add new error if a gtfs dataset has gtfs files in sub folders by @qcdyx in feat: 1504 add new error if a gtfs dataset has gtfs files in sub folders #1535
feat: trip vs shape distance validation by @cka-y in feat: trip vs shape distance validation #1553
fix: comments on Acceptance tests keeps running for hours #1587 by @cka-y in fix: comments on #1587 #1592

Bug fixes

fix: Fix typo in TimeframeOverlapNotice class name by @bdferris-v2 in fix: Fix typo in TimeframeOverlapNotice class name #1569
Fix: typo in config.yml by @isabelle-dr in Fix: typo in config.yml #1435
feat: 1532 support mac created zip files by @qcdyx in feat: 1532 support mac created zip files #1543
fix: Mixed Case false positives by @briandonahue in fix: Mixed Case false positives #1430
fix: don't throw exception on calendar with no days by @Whoops in fix: don't throw exception on calendar with no days #1519
fix: Update the "Help" menu with current command line parameters#1116 by @cka-y in fix: Update the "Help" menu with current command line parameters#1116 #1502
fix: Package installers CI step failing by @davidgamez in fix: Package installers CI step failing #1568
Fix for deprecated of set-output in GH actions by @fredericsimard in Fix for deprecated of set-output in GH actions #1571
bug: initialized tooltip in the report.html by @qcdyx in bug: initialized tooltip in the report.html #1581
fix: Remove triage action & add exclude paths by @fredericsimard in fix: Remove triage action & add exclude paths #1576
fix: fix OutOfBoundsException when agency.txt is missing in the input data… by @qcdyx in fix: fix OutOfBoundsException when agency.txt is missing in the input data… #1551
Fix: Restore missing CSS by @briandonahue in Fix: Restore missing CSS #1457
fix: Modified to accept mime type encountered on Windows by @jcpitre in fix: Modified to accept mime type encountered on Windows #1439
fix: Web Validator hangs after supplying non-zip URL Web Validator hangs after supplying non-zip URL #1445 by @cka-y in fix: Web Validator hangs after supplying non-zip URL #1445 #1481
fix: Web validator allows non-zip files to be uploaded Web validator allows non-zip files to be uploaded #1440 by @cka-y in fix: Web validator allows non-zip files to be uploaded #1440 #1482

New summary section of report

feat: Add metadata to report by @briandonahue in feat: Add metadata to report #1389
fix: Bug in HTML report generation where feed metadata can be null by @bdferris-v2 in fix: Bug in HTML report generation where feed metadata can be null #1451
feat: Added route names component by @cka-y in feat: Added route names component #1469
Issue/1463 by @cka-y in Issue/1463 #1471
feat: 1465 add a route colors gtfs component by @qcdyx in feat: 1465 add a route colors gtfs component #1492
feat: 1466 add a transfers gtfs component by @qcdyx in feat: 1466 add a transfers gtfs component #1501
feat: Provide an explanation to users about what a GTFS Component is Provide an explanation to users about what a GTFS Component is #1505 by @cka-y in feat: Provide an explanation to users about what a GTFS Component is #1505 #1512
feat: added rest of GTFS components by @cka-y in feat: added rest of GTFS components #1516
feat: Add overview section to the Json report by @jcpitre in feat: Add overview section to the Json report #1531

Generate documentation automatically

fix: Refactor MainTest to avoid stubbing System.exit() by @bdferris-v2 in fix: Refactor MainTest to avoid stubbing System.exit() #1410
feat: Add @GtfsValidationNotice annotations to all notice classes by @bdferris-v2 in feat: Add @GtfsValidationNotice annotations to all notice classes #1366
feat: Add unit-test check for @GtfsValidationNotice annotation and notices that I missed by @bdferris-v2 in feat: Add unit-test check for @GtfsValidationNotice annotation and notices that I missed #1413
feat: Include section references in the notice output schema. by @bdferris-v2 in feat: Include section references in the notice output schema. #1416
feat: Add Notice documentation header check. by @bdferris-v2 in feat: Add Notice documentation header check. #1422
feat: Change Notice field comment format and unit-test to enforce they exist by @bdferris-v2 in feat: Change Notice field comment format and unit-test to enforce they exist #1421
Fix: Switch javadoc aggregation plugin to non-jar version. by @bdferris-v2 in Fix: Switch javadoc aggregation plugin to non-jar version. #1432
feat: Add a few missing "Affected files" references by @bdferris-v2 in feat: Add a few missing "Affected files" references #1427
fix: Use correct import for @nullable annotation. by @bdferris-v2 in fix: Use correct import for @Nullable annotation. #1438
Feat: Bulk update Notice Javadoc to include content from RULES.md. by @bdferris-v2 in Feat: Bulk update Notice Javadoc to include content from RULES.md. #1428
feat: Add documentation update + unit-test for new notice doc conventions. by @bdferris-v2 in feat: Add documentation update + unit-test for new notice doc conventions. #1429
feat: Split the notice doc comment into a short summary string and additional documentation. by @bdferris-v2 in feat: Split the notice doc comment into a short summary string and additional documentation. #1452
feat: Additional test to enforce documentation comment conventions by @bdferris-v2 in feat: Additional test to enforce documentation comment conventions #1450
Fix: bug in Notice documentation comment splitting. by @bdferris-v2 in Fix: bug in Notice documentation comment splitting. #1479
feat: Resolve notice severity level from @GtfsValidationNotice annotation. by @bdferris-v2 in feat: Resolve notice severity level from @GtfsValidationNotice annotation. #1475
Feat: Remove SeverityLevel from ValidationNotice constructor by @bdferris-v2 in Feat: Remove SeverityLevel from ValidationNotice constructor #1489
feat: Remove unit-test that RULES.md is up-to-date with Notice classes. by @bdferris-v2 in feat: Remove unit-test that RULES.md is up-to-date with Notice classes. #1517
Remove unit-test that RULES.md is up-to-date with Notice classes by @qcdyx in Remove unit-test that RULES.md is up-to-date with Notice classes #1522

Web-based validator improvements

feat: integrate Cypress for E2E testing by @mijogu in feat: integrate Cypress for E2E testing #1396
chore: ignore web packages on acceptance and e2e tests by @davidgamez in chore: ignore web packages on acceptance and e2e tests #1403
feat: report link sharing by @ryon in feat: report link sharing #1397
feat: Web Validator Service Tests by @briandonahue in feat: Web Validator Service Tests #1375
feat: add Cypress tests for error messaging by @mijogu in feat: add Cypress tests for error messaging #1405
feat: add google analytics by @ryon in feat: add google analytics #1407
docs(web-client): update local dev instructions by @KClough in docs(web-client): update local dev instructions #1408
feat: web pipeline by @briandonahue in feat: web pipeline #1406
docs(web-service): update readme with local dev guidance by @KClough in docs(web-service): update readme with local dev guidance #1414
feat: use sentry spring-boot by @KClough in feat: use sentry spring-boot #1415
docs: Update README.md with open api spec by @KClough in docs: Update README.md with open api spec #1418
fix(web/service): change permissions for application.properties, service acount json, & newrelic.yml by @lottspot in fix(web/service): change permissions for application.properties, service acount json, & newrelic.yml #1453
refactor: remove web merge actions by @lottspot in refactor: remove web merge actions #1497
feat: generate rules page from json file by @KClough in feat: generate rules page from json file #1508
refactor(ci): rename cypress workflow to be consistent by @themightychris in refactor(ci): rename cypress workflow to be consistent #1490

For developers: Ability to change "required" status of GTFS files/tables at run-time instead of compile time

feat: Make GtfsTableDescriptor.required a mutable property by @bdferris-v2 in feat: Make GtfsTableDescriptor.required a mutable property #1566
feat: Add method to GtfsFeedLoader to access GtfsTableDescriptors. by @bdferris-v2 in feat: Add method to GtfsFeedLoader to access GtfsTableDescriptors. #1573

Report improvements

HTML Report, limit records displayed by @briandonahue in HTML Report, limit records displayed #1433
feat: Add notice descriptions to HTML report by @briandonahue in feat: Add notice descriptions to HTML report #1447
feat: add stop_id to the decreasing_or_equal_stop_time_distance notice by @cka-y in feat: add stop_id to the decreasing_or_equal_stop_time_distance notice #1554
fix: Use csvRowNumber in MissingFeedContactEmailAndUrlNotice for consistency with other notices by @bdferris-v2 in fix: Use csvRowNumber in MissingFeedContactEmailAndUrlNotice for consistency with other notices #1572
fix: Add back support for @GtfsTable.maxCharsPerColumn. by @bdferris-v2 in fix: Add back support for @GtfsTable.maxCharsPerColumn. #1462
feat: 1425 output fieldname of missing recommended field notice even if there is no column by @qcdyx in feat: 1425 output fieldname of missing recommended field notice even if there is no column #1511

Documentation updates

Fix: Update slack links by @isabelle-dr in Fix: Update slack links #1426
Fix: Add reference routes.txt Best Practices by @isabelle-dr in Fix: Add reference routes.txt Best Practices #1424
fix: correct typo for export notices schema flag by @KClough in fix: correct typo for export notices schema flag #1449
Fix: Update slack channel link by @isabelle-dr in Fix: Update slack channel link #1495
Add david as core developer and steering commitee CONTRIBUTING.md by @isabelle-dr in Add david as core developer and steering commitee CONTRIBUTING.md #1498
docs: Update core developers list by @emmambd in docs: Update core developers list #1550
docs: Fix Link in README.md by @1Maxnet1 in docs: Fix Link in README.md #1546

Maintenance

Docs: Update NOTICE_MIGRATION.md by @isabelle-dr in Docs: Update NOTICE_MIGRATION.md #1379
build(deps-dev): bump @sveltejs/kit from 1.7.2 to 1.15.1 in /web/client by @dependabot in build(deps-dev): bump @sveltejs/kit from 1.7.2 to 1.15.1 in /web/client #1376
feat: deploy web app to staging environment by @lottspot in feat: deploy web app to staging environment #1560
feat: 1520 gtfs validator desktop app deprecation by @qcdyx in feat: 1520 gtfs validator desktop app deprecation #1555
build(deps): bump requests from 2.26.0 to 2.31.0 in /scripts/mobility-database-harvester by @dependabot in build(deps): bump requests from 2.26.0 to 2.31.0 in /scripts/mobility-database-harvester #1443
feat: Conditionally run more multi-file validators if their dependencies don't have parse errors by @bdferris-v2 in feat: Conditionally run more multi-file validators if their dependencies don't have parse errors #1496
fix: report.json doesn't include details of parsing failures by @cka-y in fix: report.json doesn't include details of parsing failures #1526
fix: Forced java version to 17.0.7 in github action by @jcpitre in fix: Forced java version to 17.0.7 in github action #1541
chore: add local Spring Boot profile by @davidgamez in chore: add local Spring Boot profile #1545
feat: Automate generation of release artifacts by @cka-y in feat: Automate generation of release artifacts #1529
feat: Automation of the update of the NOTICE_MIGRATION.md on releases by @cka-y in feat: Automation of the update of the NOTICE_MIGRATION.md on releases #1530
feat: 1537 get list of validators that couldnt run because of a parsing problem by @qcdyx in feat: 1537 get list of validators that couldnt run because of a parsing problem #1565
Updated actions/setup-node action to v3.8.1 to use node 16 by @fredericsimard in Updated actions/setup-node action to v3.8.1 to use node 16 #1577
Corrected a problem with the acceptance test action. by @jcpitre in Corrected a problem with the acceptance test action. #1583
feat: Resolve release version from new /version endpoint. by @bdferris-v2 in feat: Resolve release version from new /version endpoint. #1586
feat: 1588 publish to maven central by @jcpitre in feat: 1588 publish to maven central #1596

This discussion was created from the release v4.2.0.

Replies: 0 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment