Add fare_product_with_multiple_default_rider_categories

[skalexch]

Describe the problem

We adopted rider categories. The PR will be merged soon.

Describe the new validation rule

Related spec language	Rationale for rule	Notice name to update or add	Pseudologic	Notice table columns	Severity	Notice description
rider_categories.rider_category_id, fare_products.rider_category_id, is_default_fare_category	When multiple rider categories are eligible for a single fare product specified by a fare_product_id, there must be exactly one of these eligible rider categories indicated as the default rider category	fare_product_with_multiple_default_rider_categories	if rider_categories.txt does not exist: Do not trigger a notice and ignore subsequent checks For each fare_product_id: If multiple rider_category_id are associated: If more than one of these rider_category_id has is_default_fare_category ==1: Trigger Notice	FareProductId, CsvRowNumber1,CsvRowNumber2 (for the fare product), RiderCategoryId1,RiderCategoryId2	ERROR	A fare product in fare_products.txt has more than one eligible default rider category from rider_categories.txt.

Sample GTFS datasets

http://developer.trimet.org/schedule/gtfs.zip

Severity

ERROR

Additional context

gtfs.org documentation: google/transit#511

[jcpitre]

@skalexch what happens if there are more then 2 rider categories marked as default (Sorry I am a bit late to the party).
I am guessing it's OK with you to just show the first 2 defaults, right?

[skalexch]

@jcpitre there can be two defaults but they cannot be eligible for the same fare_product_id. This can be the case with multiple agencies with different categories as default. This might not be relevant now but if we add eligibility criteria like age, then the issue will become apparent. That's probably the reason why this restriction was added.

[jcpitre]

@skalexch My question is "what if 3 riders categories marked as default"?.
The notice only lists 2.
It's not very important.

[skalexch]

@jcpitre oh thank you for clarifying! I guess it's okay to show the first two. What's important in the notice is the fare_product_id. And listing two default rider categories will prompt the user to open the file and remove an incorrect one. I think going beyond two is visual clogging