Add an warning notice for service_id with no active weekdays.

[skalexch]

Describe the problem

If a service_id exists but all weekdays have a value of 0, it means that:

• A mistake was made.
• The service is taken off, which means it should be removed from the feed.
• There is an exception for that service during that week, which is better specified through calendar_dates.txt.

This is supported in the legacy validator as ValidateHasServiceAtLeastOnceAWeek and is a WARNING (Google Type notice TYPE_CALENDAR_HAS_NO_ACTIVE_DAYS_OF_WEEK).

Describe the new validation rule

Related spec language	Rationale for rule	Notice name to update or add	Pseudologic	Notice table columns	Severity	Notice description
calendar.service_id, calendar.sunday, calendar.monday, calendar.tuesday, calendar.wednesday, calendar.thursday, calendar.friday, calendar.saturday	A service should be valid at least once a week	service_has_no_active_days_of_week	For each service_id, if {calendar.sunday, calendar.monday, calendar.tuesday, calendar.wednesday, calendar.thursday, calendar.friday, calendar.saturday} = {0}: Trigger notice	csvRowNumber, serviceId	WARNING	A service is not valid for all days of the week.

Sample GTFS datasets

No response

Severity

WARNING

Additional context

No response

[emmambd]

@derhuerst I'm curious why you gave this a thumbs down. Could you share your thoughts?

[derhuerst]

Sorry for the confusion, I think I meant to give it a thumbs-up. I support having this because, from my experience, ~50% of all empty services are unintended, and the others can be omitted easily.

[davidgamez]

@skalexch, just to confirm, is this a warning?