add test coverage

Author: davidgamez

api/src/feeds/impl/models/search_feed_item_result_impl.py

@@ -51,7 +51,7 @@ def from_orm_gtfs(cls, feed_search_row: t_feedsearch):
                 service_date_range_end=feed_search_row.latest_dataset_service_date_range_end,
                 agency_timezone=feed_search_row.latest_dataset_agency_timezone,
                 validation_report=LatestDatasetValidationReport(
-                    total_error=feed_search_row.latest_total_error.la.total_error,
+                    total_error=feed_search_row.latest_total_error,
                     total_warning=feed_search_row.latest_total_warning,
                     total_info=feed_search_row.latest_total_info,
                     unique_error_count=feed_search_row.latest_unique_error_count,

api/tests/unittest/models/test_gtfs_feed_impl.py

@@ -172,6 +172,7 @@ def create_test_notice(notice_code: str, total_notices: int, severity: str):
             unique_error_count=3,
             unique_warning_count=4,
             unique_info_count=2,
+            features=["feature"],
         ),
         service_date_range_start=datetime(2024, 1, 1, 0, 0, 0, tzinfo=ZoneInfo("Canada/Atlantic")),
         service_date_range_end=datetime(2025, 1, 1, 0, 0, 0, tzinfo=ZoneInfo("Canada/Atlantic")),

api/tests/unittest/models/test_latest_dataset_impl.py

@@ -4,7 +4,7 @@
 
 from geoalchemy2 import WKTElement
 
-from shared.database_gen.sqlacodegen_models import Gtfsdataset, Feed, Validationreport
+from shared.database_gen.sqlacodegen_models import Gtfsdataset, Feed, Validationreport, Feature
 from feeds.impl.models.bounding_box_impl import BoundingBoxImpl
 from feeds.impl.models.latest_dataset_impl import LatestDatasetImpl
 
@@ -36,6 +36,7 @@ def test_from_orm(self):
                         unique_error_count=0,
                         unique_warning_count=0,
                         unique_info_count=0,
+                        features=[],
                     ),
                     Validationreport(
                         validator_version="1.2.0",
@@ -45,6 +46,7 @@ def test_from_orm(self):
                         unique_error_count=2,
                         unique_warning_count=1,
                         unique_info_count=1,
+                        features=[Feature(name="feature 1.2.0 1"), Feature(name="feature 1.2.0 2")],
                     ),
                     Validationreport(
                         validator_version="1.1.1",
@@ -54,6 +56,7 @@ def test_from_orm(self):
                         unique_error_count=1,
                         unique_warning_count=1,
                         unique_info_count=0,
+                        features=[Feature(name="feature 1.1.1 1"), Feature(name="feature 1.1.1 2")],
                     ),
                 ],
             )
@@ -74,6 +77,7 @@ def test_from_orm(self):
             service_date_range_end=datetime(2025, 1, 1, 0, 0, 0, tzinfo=ZoneInfo("Canada/Atlantic")),
             agency_timezone="Canada/Atlantic",
             validation_report={
+                "features": ["feature 1.2.0 1", "feature 1.2.0 2"],
                 "validator_version": "1.2.0",
                 "total_error": 3,
                 "total_info": 1,

api/tests/unittest/models/test_search_feed_item_result_impl.py

@@ -5,6 +5,7 @@
 
 from feeds.impl.models.search_feed_item_result_impl import SearchFeedItemResultImpl
 from feeds_gen.models.latest_dataset import LatestDataset
+from feeds_gen.models.latest_dataset_validation_report import LatestDatasetValidationReport
 from feeds_gen.models.location import Location
 from feeds_gen.models.source_info import SourceInfo
 
@@ -43,6 +44,13 @@ def __init__(self, **kwargs):
     latest_dataset_service_date_range_start="2030-09-29T00:00:00+00:00",
     latest_dataset_service_date_range_end="2031-09-29T00:00:00+00:00",
     latest_dataset_agency_timezone="Canada/Atlantic",
+    latest_total_error=1,
+    latest_total_warning=2,
+    latest_total_info=3,
+    latest_unique_error_count=1,
+    latest_unique_warning_count=2,
+    latest_unique_info_count=3,
+    latest_dataset_features=["feature1", "feature2"],
     external_ids=[],
     redirect_ids=[],
     feed_reference_ids=[],
@@ -86,6 +94,15 @@ def test_from_orm_gtfs(self):
                 service_date_range_start=item.latest_dataset_service_date_range_start,
                 service_date_range_end=item.latest_dataset_service_date_range_end,
                 agency_timezone=item.latest_dataset_agency_timezone,
+                validation_report=LatestDatasetValidationReport(
+                    total_error=item.latest_total_error,
+                    total_warning=item.latest_total_warning,
+                    total_info=item.latest_total_info,
+                    unique_error_count=item.latest_unique_error_count,
+                    unique_warning_count=item.latest_unique_warning_count,
+                    unique_info_count=item.latest_unique_info_count,
+                    features=item.latest_dataset_features,
+                ),
             ),
         )
         assert result == expected