chore: improve logs on operations api (#1220)

Author: davidgamez

functions-python/operations_api/src/feeds_operations/impl/feeds_operations_impl.py

@@ -48,25 +48,24 @@
 )
 from .request_validator import validate_request
 
-logging.basicConfig(level=logging.INFO)
-
 
 class OperationsApiImpl(BaseOperationsApi):
     """Implementation of the operations API."""
 
     def process_feed(self, feed) -> GtfsFeedResponse | GtfsRtFeedResponse:
         """Process a feed into the appropriate response type using fromOrm methods."""
-        logging.info(f"Processing feed {feed.stable_id} with type {feed.data_type}")
+        logging.debug("Processing feed %s with type %s", feed.stable_id, feed.data_type)
 
         if feed.data_type == "gtfs":
             result = GtfsFeedImpl.from_orm(feed)
-            logging.info(f"Successfully processed GTFS feed {feed.stable_id}")
+            logging.debug("Successfully processed GTFS feed %s", feed.stable_id)
             return result
         elif feed.data_type == "gtfs_rt":
             result = GtfsRtFeedImpl.from_orm(feed)
-            logging.info(f"Successfully processed GTFS-RT feed {feed.stable_id}")
+            logging.debug("Successfully processed GTFS-RT feed %s", feed.stable_id)
             return result
 
+        logging.error("Unsupported feed type: %s", feed.data_type)
         raise ValueError(f"Unsupported feed type: {feed.data_type}")
 
     @with_db_session
@@ -188,8 +187,9 @@ async def _update_feed(
             )
 
             logging.info(
-                f"Feed ID: {update_request_feed.id} attempting to update with the following request: "
-                f"{update_request_feed}"
+                "Feed ID: %s attempting to update with the following request: %s",
+                update_request_feed.id,
+                update_request_feed,
             )
             impl_class = (
                 UpdateRequestGtfsFeedImpl
@@ -207,22 +207,23 @@ async def _update_feed(
                 db_session.flush()
                 refreshed = refresh_materialized_view(db_session, t_feedsearch.name)
                 logging.info(
-                    f"Materialized view {t_feedsearch.name} refreshed: {refreshed}"
+                    "Materialized view %s refreshed: %s", t_feedsearch.name, refreshed
                 )
                 db_session.commit()
                 logging.info(
-                    f"Feed ID: {update_request_feed.id} updated successfully with the following changes: "
-                    f"{diff.values()}"
+                    "Feed ID: %s updated successfully with the following changes: %s",
+                    update_request_feed.id,
+                    diff.values(),
                 )
                 return Response(status_code=200)
             else:
                 logging.info(
-                    f"No changes detected for feed ID: {update_request_feed.id}"
+                    "No changes detected for feed ID: %s", update_request_feed.id
                 )
                 return Response(status_code=204)
         except Exception as e:
             logging.error(
-                f"Failed to update feed ID: {update_request_feed.id}. Error: {e}"
+                "Failed to update feed ID: %s. Error: %s", update_request_feed.id, e
             )
             if isinstance(e, HTTPException):
                 raise e

functions-python/operations_api/src/feeds_operations/impl/models/basic_feed_impl.py

@@ -1,14 +1,10 @@
-import logging
-
 from feeds_operations.impl.models.external_id_impl import ExternalIdImpl
 from feeds_operations.impl.models.location_impl import LocationImpl
 from feeds_operations.impl.models.redirect_impl import RedirectImpl
 from feeds_operations_gen.models.base_feed import BaseFeed
 from feeds_operations_gen.models.source_info import SourceInfo
 from shared.database_gen.sqlacodegen_models import Feed
 
-logger = logging.getLogger(__name__)
-
 
 class BaseFeedImpl(BaseFeed):
     """Base implementation of the feeds models."""

functions-python/operations_api/src/main.py

@@ -21,9 +21,9 @@
 import asyncio
 
 from middleware.request_context_middleware import RequestContextMiddleware
-from shared.helpers.logger import Logger
+from shared.helpers.logger import init_logger
 
-Logger.init_logger()
+init_logger()
 
 app = FastAPI(
     title="Mobility Database Catalog Operations",

functions-python/operations_api/src/middleware/request_context_middleware.py

@@ -14,7 +14,6 @@
 #  limitations under the License.
 #
 
-import logging
 from starlette.types import ASGIApp, Receive, Scope, Send
 
 from middleware.request_context_oauth2 import (
@@ -29,7 +28,6 @@ class RequestContextMiddleware:
     """
 
     def __init__(self, app: ASGIApp) -> None:
-        self.logger = logging.getLogger()
         self.app = app
 
     async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:

functions-python/operations_api/src/middleware/request_context_oauth2.py

@@ -44,7 +44,7 @@ def validate_token_with_google(token: str, google_client_id: str) -> dict:
     try:
         response = get_tokeninfo_response(token)
     except Exception as e:
-        logging.error(f"Token validation failed: {e}")
+        logging.error("Token validation failed: %s", e)
         raise HTTPException(status_code=500, detail="Token validation failed")
 
     if response.status_code != 200: