Skip to content

Commit 336eaf3

Browse files
committed
resolved PR comments
1 parent b97f5ae commit 336eaf3

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

functions-python/backfill_dataset_service_date_range/requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ geoalchemy2==0.14.7
1717
# Google specific packages for this function
1818
cloudevents~=1.10.1
1919
google-cloud-storage
20+
google-cloud-tasks
2021

2122
# Configuration
2223
python-dotenv==1.0.0

functions-python/tasks_executor/src/tasks/refresh_feedsearch_view/refresh_materialized_view.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,20 @@ def refresh_materialized_view_task(dry_run, db_session):
3030
logging.info("Materialized view refresh task initiated.")
3131

3232
view_name = "feedsearch"
33-
success = refresh_materialized_view(db_session, view_name)
34-
35-
if success:
36-
success_msg = "Successfully refreshed materialized view: " f"{view_name}"
37-
logging.info(success_msg)
38-
return {"message": success_msg}, 200
33+
if dry_run:
34+
msg = f"Dry run: {view_name} not refreshed."
35+
logging.info(msg)
36+
return {"message": msg, "dry_run": True}, 200
3937
else:
40-
error_msg = f"Failed to refresh materialized view: {view_name}"
41-
logging.error(error_msg)
42-
return {"error": error_msg}, 500
38+
success = refresh_materialized_view(db_session, view_name)
39+
if success:
40+
success_msg = f"Successfully refreshed materialized view: {view_name}"
41+
logging.info(success_msg)
42+
return {"message": success_msg}, 200
43+
else:
44+
error_msg = f"Failed to refresh materialized view: {view_name}"
45+
logging.error(error_msg)
46+
return {"error": error_msg}, 500
4347

4448
except Exception as error:
4549
error_msg = f"Error refreshing materialized view: {error}"

0 commit comments

Comments
 (0)