Skip to content

Commit 35941ed

Browse files
committed
fix ci failing test
1 parent 510099e commit 35941ed

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

functions-python/operations_api/src/feeds_operations/impl/feeds_operations_impl.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,9 @@
3232
from feeds_operations_gen.models.update_request_gtfs_feed import UpdateRequestGtfsFeed
3333
from helpers.database import start_db_session
3434
from helpers.query_helper import query_feed_by_stable_id
35-
from helpers.logger import Logger
3635
from deepdiff import DeepDiff
3736

3837
logging.basicConfig(level=logging.INFO)
39-
Logger.init_logger()
4038

4139

4240
class OperationsApiImpl(BaseOperationsApi):

functions-python/operations_api/src/main.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121
import asyncio
2222

2323
from middleware.request_context_middleware import RequestContextMiddleware
24+
from helpers.logger import Logger
25+
26+
Logger.init_logger()
2427

2528
app = FastAPI(
2629
title="Mobility Database Catalog Operations",

functions-python/operations_api/tests/feeds_operations/impl/test_feeds_operations_impl.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import os
22
from unittest import mock
3+
from unittest.mock import patch
34

45
import pytest
56
from fastapi import HTTPException
@@ -39,27 +40,29 @@ def update_request_gtfs_feed():
3940
)
4041

4142

43+
@patch("helpers.logger.Logger")
4244
@mock.patch.dict(
4345
os.environ,
4446
{
4547
"FEEDS_DATABASE_URL": default_db_url,
4648
},
4749
)
4850
@pytest.mark.asyncio
49-
async def test_update_gtfs_feed_no_changes(update_request_gtfs_feed):
51+
async def test_update_gtfs_feed_no_changes(_, update_request_gtfs_feed):
5052
api = OperationsApiImpl()
5153
response: Response = await api.update_gtfs_feed(update_request_gtfs_feed)
5254
assert response.status_code == 204
5355

5456

57+
@patch("helpers.logger.Logger")
5558
@mock.patch.dict(
5659
os.environ,
5760
{
5861
"FEEDS_DATABASE_URL": default_db_url,
5962
},
6063
)
6164
@pytest.mark.asyncio
62-
async def test_update_gtfs_feed_field_change(update_request_gtfs_feed):
65+
async def test_update_gtfs_feed_field_change(_, update_request_gtfs_feed):
6366
update_request_gtfs_feed.feed_name = "New feed name"
6467
with get_testing_session() as session:
6568
api = OperationsApiImpl()
@@ -74,14 +77,15 @@ async def test_update_gtfs_feed_field_change(update_request_gtfs_feed):
7477
assert db_feed.feed_name == "New feed name"
7578

7679

80+
@patch("helpers.logger.Logger")
7781
@mock.patch.dict(
7882
os.environ,
7983
{
8084
"FEEDS_DATABASE_URL": default_db_url,
8185
},
8286
)
8387
@pytest.mark.asyncio
84-
async def test_update_gtfs_feed_set_wip(update_request_gtfs_feed):
88+
async def test_update_gtfs_feed_set_wip(_, update_request_gtfs_feed):
8589
update_request_gtfs_feed.operational_status_action = "wip"
8690
with get_testing_session() as session:
8791
api = OperationsApiImpl()
@@ -96,14 +100,15 @@ async def test_update_gtfs_feed_set_wip(update_request_gtfs_feed):
96100
assert db_feed.operational_status == "wip"
97101

98102

103+
@patch("helpers.logger.Logger")
99104
@mock.patch.dict(
100105
os.environ,
101106
{
102107
"FEEDS_DATABASE_URL": default_db_url,
103108
},
104109
)
105110
@pytest.mark.asyncio
106-
async def test_update_gtfs_feed_invalid_feed(update_request_gtfs_feed):
111+
async def test_update_gtfs_feed_invalid_feed(_, update_request_gtfs_feed):
107112
update_request_gtfs_feed.id = "invalid"
108113
api = OperationsApiImpl()
109114
with pytest.raises(HTTPException) as exc_info:

0 commit comments

Comments
 (0)