migrate to cloud logging

Author: davidgamez

api/src/feeds/impl/feeds_api_impl.py

@@ -61,9 +61,9 @@ class FeedsApiImpl(BaseFeedsApi):
     If a method is left blank the associated endpoint will return a 500 HTTP response.
     """
 
-    APIFeedType = Union[FeedOrm, GtfsFeed, GtfsRTFeed]
 
     def __init__(self) -> None:
+        Logger.init_logger()
         self.logger = Logger("FeedsApiImpl").get_logger()
 
     @with_db_session

api/src/shared/common/logging_utils.py

@@ -2,7 +2,7 @@
 import os
 from google.cloud.logging.handlers import CloudLoggingHandler
 import google.cloud.logging
-
+from google.cloud.logging_v2 import Client
 
 def get_env_logging_level():
     """
@@ -22,46 +22,71 @@ class Logger:
 
     def __init__(self, name: str):
         self.logger = logging.getLogger(name)
-        self.logger.setLevel(get_env_logging_level())
-        self.logger.handlers.clear()
+        # self.logger.setLevel(get_env_logging_level())
+        # self.logger.handlers.clear()
 
         # formatter = jsonlogger.JsonFormatter(
         #     '%(asctime)s %(levelname)s %(name)s %(message)s'
         # )
-
-        if not is_local_env():
-            handler = logging.StreamHandler()
-        else:
-            try:
-                client = google.cloud.logging.Client()
-                client.setup_logging()
-                self.logger.info("GCP logging client initialized")
-                handler = CloudLoggingHandler(client)
-            except Exception as e:
-                # fallback to stdout if cloud client fails
-                self.logger.error(f"GCP logging failed, using fallback: {e}")
-                handler = logging.StreamHandler()
+        # logging.basicConfig(level=get_env_logging_level())
+        # if not is_local_env():
+        #     handler = logging.StreamHandler()
+        # else:
+        #     try:
+        #         client = google.cloud.logging.Client()
+        #         client.setup_logging()
+        #         # self.logger.info("GCP logging client initialized")
+        #         # handler = CloudLoggingHandler(client)
+        #     except Exception as e:
+        #         # fallback to stdout if cloud client fails
+        #         # self.logger.error(f"GCP logging failed, using fallback: {e}")
+        #         handler = logging.StreamHandler()
 
         # handler.setFormatter(formatter)
-        self.logger.addHandler(handler)
+        # self.logger.addHandler(handler)
 
         # Also configure SQLAlchemy to use this logger
-        self.setup_sqlalchemy_logger(handler)
-        self.logger.info("Logger initialized")
+        # self.setup_sqlalchemy_logger(handler)
+        # self.logger.info("Logger initialized")
 
-    def setup_sqlalchemy_logger(self, handler):
-        sqlalchemy_loggers = [
-            "sqlalchemy.engine",
-            # "sqlalchemy.pool",
-            # "sqlalchemy.dialects.postgresql",
-            "sqlalchemy.engine.Engine",
-        ]
-        for logger_name in sqlalchemy_loggers:
-            logger = logging.getLogger(logger_name)
-            logger.setLevel(get_env_logging_level())
-            logger.handlers.clear()
-            logger.addHandler(handler)
-            logger.propagate = False
+    @staticmethod
+    def init_logger():
+        """
+        Initializes the logger
+        """
+        logging.basicConfig(level=get_env_logging_level())
+        if is_local_env():
+            # Use the default logging handler
+            logging.info("Using default logging handler")
+            return
+        try:
+            client = google.cloud.logging.Client()
+            client.get_default_handler()
+            client.setup_logging()
+            logging.info("GCP logging client initialized")
+            # return client
+        except Exception as error:
+            # This might happen when the GCP authorization credentials are not available.
+            # Example, when running the tests locally
+            logging.error(f"Error initializing the logger: {error}")
+        # return None
+
+    # def setup_sqlalchemy_logger(self, handler):
+    #     sqlalchemy_loggers = [
+    #         "sqlalchemy.engine",
+    #         # "sqlalchemy.pool",
+    #         # "sqlalchemy.dialects.postgresql",
+    #         "sqlalchemy.engine.Engine",
+    #     ]
+    #     for logger_name in sqlalchemy_loggers:
+    #         logger = logging.getLogger(logger_name)
+    #         logger.setLevel(get_env_logging_level())
+    #         logger.handlers.clear()
+    #         logger.addHandler(handler)
+    #         logger.propagate = False
 
     def get_logger(self):
         return self.logger
+
+def new_logger(self):
+    logging.basicConfig(level=get_env_logging_level())