Skip to content

Commit 6168402

Browse files
authored
Fix/populate uncaught errors (#1063)
1 parent 30081e6 commit 6168402

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

api/src/scripts/populate_db.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def get_safe_value(row, column_name, default_value):
8080
"""
8181
Get a safe value from the row
8282
"""
83-
value = row[column_name]
83+
value = row.get(column_name)
8484
if not value or pandas.isna(value) or f"{value}".strip() == "":
8585
return default_value
8686
return f"{value}".strip()
@@ -92,7 +92,7 @@ def get_safe_boolean_value(row, column_name, default_value: bool | None) -> bool
9292
Only allowed values are "true" and "false" (case insensitive)
9393
Anything else returns the default.
9494
"""
95-
value = row[column_name]
95+
value = row.get(column_name)
9696
if value is None or pandas.isna(value) or f"{value}".strip() == "":
9797
return default_value
9898
# I am not sure if pandas will convert "TRUE" and "FALSE" to boolean, so go back to using a string

api/src/scripts/populate_db_gtfs.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import os
2+
import traceback
23
from typing import TYPE_CHECKING
34
from datetime import datetime
45

@@ -131,6 +132,9 @@ def process_feed_references(self, session: "Session"):
131132
except ValueError:
132133
gtfs_stable_id = static_reference
133134
gtfs_feed = self.query_feed_by_stable_id(session, gtfs_stable_id, "gtfs")
135+
if not gtfs_feed:
136+
self.logger.warning(f"Could not find static reference feed {gtfs_stable_id} for feed {stable_id}")
137+
continue
134138
already_referenced_ids = {ref.id for ref in gtfs_feed.gtfs_rt_feeds}
135139
if gtfs_feed and gtfs_rt_feed.id not in already_referenced_ids:
136140
gtfs_feed.gtfs_rt_feeds.append(gtfs_rt_feed)
@@ -294,6 +298,7 @@ def initialize(self, trigger_downstream_tasks: bool = True):
294298
self.trigger_downstream_tasks()
295299
except Exception as e:
296300
self.logger.error(f"\n------ Failed to populate the database with sources.csv: {e} -----\n")
301+
traceback.print_exc()
297302
exit(1)
298303

299304

0 commit comments

Comments
 (0)