Add missing id in the path

Author: davidgamez

functions-python/tasks_executor/src/tasks/geojson/update_geojson_files_precision.py

@@ -62,8 +62,8 @@ def query_unprocessed_feeds(limit, db_session):
 
 
 @track_metrics(metrics=("time", "memory", "cpu"))
-def _upload_file(bucket, geojson):
-    processed_blob = bucket.blob("geolocation.geojson")
+def _upload_file(bucket, file_path, geojson):
+    processed_blob = bucket.blob(file_path)
     processed_blob.upload_from_string(
         json.dumps(geojson, ensure_ascii=False),
         content_type="application/geo+json",
@@ -163,9 +163,8 @@ def update_geojson_files_precision_handler(
             if processed % 100 == 0:
                 logging.info("Processed %s/%s", processed, len(feeds))
                 db_session.commit()
-            file = storage.Blob(
-                bucket=bucket, name=f"{feed.stable_id}/{GEOLOCATION_FILENAME}"
-            )
+            file_path = f"{feed.stable_id}/{GEOLOCATION_FILENAME}"
+            file = storage.Blob(bucket=bucket, name=file_path)
             if not file.exists():
                 logging.info("File does not exist: %s", file.name)
                 continue
@@ -181,8 +180,9 @@ def update_geojson_files_precision_handler(
 
             # Optionally upload processed geojson
             if not dry_run:
-                _upload_file(bucket, geojson)
+                _upload_file(bucket, file_path, geojson)
                 _update_feed_info(feed, timestamp)
+                logging.info("Updated feed %s", feed.stable_id)
 
             processed += 1
         except Exception as e:

functions-python/tasks_executor/tests/tasks/geojson/test_update_geojson_files_precision.py

@@ -180,8 +180,8 @@ def test_handler_uploads_and_updates_feed_info(self, db_session: Session):
             )
 
         # verify upload happened
-        self.assertIn("geolocation.geojson", fake_bucket.uploaded)
-        uploaded_text = fake_bucket.uploaded["geolocation.geojson"]
+        self.assertIn(blob_name, fake_bucket.uploaded)
+        uploaded_text = fake_bucket.uploaded[blob_name]
         uploaded_geo = json.loads(uploaded_text)
         coords = uploaded_geo.get("features")[0]["geometry"]["coordinates"]
         self.assertEqual(coords, [round(100.1234567, 5), round(0.9876543, 5)])