Fix failing test and add optional default parameter

Author: davidgamez

functions-python/helpers/transform.py

@@ -89,7 +89,7 @@ def to_float(value, default_value: Optional[float] = None) -> Optional[float]:
         return default_value
 
 
-def get_safe_value(row, column_name, default_value):
+def get_safe_value(row, column_name, default_value=None) -> Optional[str]:
     """
     Get a safe value from the row. If the value is missing or empty, return the default value.
     """
@@ -101,7 +101,7 @@ def get_safe_value(row, column_name, default_value):
     return f"{value}".strip()
 
 
-def get_safe_float(row, column_name, default_value=None):
+def get_safe_float(row, column_name, default_value=None) -> Optional[float]:
     """
     Get a safe float value from the row. If the value is missing or cannot be converted to float,
     """

functions-python/pmtiles_builder/src/csv_cache.py

@@ -128,14 +128,16 @@ def get_stops_from_trip(self, trip_id):
 
     def get_coordinates_for_stop(self, stop_id) -> tuple[float, float] | None:
         if self.stop_to_coordinates is None:
+            self.stop_to_coordinates = {}
             for s in self.get_file(STOPS_FILE):
+                self.stop_to_coordinates.get(stop_id, [])
                 row_stop_id = get_safe_value(s, "stop_id")
                 row_stop_lon = get_safe_float(s, "stop_lon")
                 row_stop_lat = get_safe_float(s, "stop_lat")
                 if row_stop_id is None or row_stop_lon is None or row_stop_lat is None:
                     self.logger.warning("Invalid stop data: %s", s)
                     continue
-                self.stop_to_coordinates = {row_stop_id: (row_stop_lon, row_stop_lat)}
+                self.stop_to_coordinates[row_stop_id] = (row_stop_lon, row_stop_lat)
         return self.stop_to_coordinates.get(stop_id, None)
 
     def set_workdir(self, workdir):

functions-python/pmtiles_builder/tests/test_build_pmtiles.py

@@ -391,7 +391,7 @@ def test_create_routes_geojson_fallback_to_stop_coordinates(self):
                 self.assertEqual(data["type"], "FeatureCollection")
                 self.assertEqual(len(data["features"]), 1)
                 coords = data["features"][0]["geometry"]["coordinates"]
-                self.assertEqual(coords, [[-73.0, 45.0], [-73.1, 45.1]])
+                self.assertEqual([[-73.0, 45.0], [-73.1, 45.1]], coords)
 
     def test_load_agencies(self):
         builder = PmtilesBuilder("feed123", "feed123_dataset456")