Merge pull request #1177 from MobilityData/1125-modifying-features-in-gbfs-endpoints

feat: 1125 modifying features in gbfs endpoints

Author: qcdyx

functions-python/gbfs_validator/src/gbfs_data_processor.py

@@ -30,6 +30,18 @@
 from shared.database.database import with_db_session
 from shared.helpers.utils import create_http_task
 
+FEATURE_ENDPOINTS = [
+    "manifest",
+    "gbfs_versions",
+    "vehicle_types",
+    "station_status",
+    "vehicle_status",
+    "system_regions",
+    "system_pricing_plans",
+    "system_alerts",
+    "geofencing_zones",
+]
+
 
 class GBFSDataProcessor:
     def __init__(self, stable_id: str, feed_id: str):
@@ -298,7 +310,9 @@ def update_or_create_gbfs_endpoint(
             )
 
         gbfs_endpoint_orm.url = endpoint.url  # Update the URL
-        gbfs_endpoint_orm.is_feature = endpoint.name in features
+        gbfs_endpoint_orm.is_feature = (
+            endpoint.name in features and endpoint.name in FEATURE_ENDPOINTS
+        )
         return gbfs_endpoint_orm
 
     def validate_gbfs_feed_versions(self) -> None:

liquibase/changelog.xml

@@ -56,4 +56,5 @@
     <include file="changes/feat_1124.sql" relativeToChangelogFile="true"/>
     <!-- Materialized view updated. Added versions of GBFS feeds-->
     <include file="changes/feat_1118.sql" relativeToChangelogFile="true"/>
+    <include file="changes/feat_1125.sql" relativeToChangelogFile="true"/>
 </databaseChangeLog>

liquibase/changes/feat_1125.sql

@@ -0,0 +1,16 @@
+-- Update gbfsendpoint table to set is_feature = false for specific endpoints
+UPDATE gbfsendpoint
+SET is_feature = CASE
+    WHEN name IN (
+        'manifest',
+        'gbfs_versions',
+        'vehicle_types',
+        'station_status',
+        'vehicle_status',
+        'system_regions',
+        'system_pricing_plans',
+        'system_alerts',
+        'geofencing_zones'
+    ) THEN true
+    ELSE false
+END;