Fix: various adjustments (#855)

* seo decription

* removed unused styling

* text update to 3k feeds

* sign in button adjustment

* null undefined check fix

* button clickability

* sticky header and nav fix feeds page

Author: Alessandro100

web-app/.eslintrc.json

@@ -28,7 +28,8 @@
       "react/react-in-jsx-scope": "off",
       "prettier/prettier": "error",
       "@typescript-eslint/ban-tslint-comment": "off",
-      "react/prop-types": "off"
+      "react/prop-types": "off",
+      "eqeqeq": "off"
     }
   }
 

web-app/public/index.html

@@ -31,7 +31,7 @@
     <link rel="icon" href="%PUBLIC_URL%/favicon.ico" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <meta name="theme-color" content="#000000" />
-    <meta name="description" content="Mobility Database" />
+    <meta name="description" content="Access GTFS and GTFS Realtime transit data with over 3,000 feeds from 70+ countries on the web's leading transit data platform." />
     <link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
     <!--
       manifest.json provides metadata used when your web app is installed on a

web-app/src/app/screens/About.tsx

@@ -2,7 +2,6 @@ import * as React from 'react';
 import CssBaseline from '@mui/material/CssBaseline';
 import Box from '@mui/material/Box';
 import Container from '@mui/material/Container';
-import '../styles/SignUp.css';
 import { Button, Typography } from '@mui/material';
 import { OpenInNew } from '@mui/icons-material';
 import { theme } from '../Theme';

web-app/src/app/screens/Contribute.tsx

@@ -2,7 +2,6 @@ import * as React from 'react';
 import CssBaseline from '@mui/material/CssBaseline';
 import Box from '@mui/material/Box';
 import Container from '@mui/material/Container';
-import '../styles/SignUp.css';
 import { Typography } from '@mui/material';
 import { theme } from '../Theme';
 

web-app/src/app/screens/FAQ.tsx

@@ -2,7 +2,6 @@ import * as React from 'react';
 import CssBaseline from '@mui/material/CssBaseline';
 import Box from '@mui/material/Box';
 import Container from '@mui/material/Container';
-import '../styles/SignUp.css';
 import '../styles/FAQ.css';
 import { Typography } from '@mui/material';
 import { WEB_VALIDATOR_LINK } from '../constants/Navigation';

web-app/src/app/screens/Feed/FeedSummary.tsx

@@ -158,7 +158,7 @@ export default function FeedSummary({
             sx={{ display: 'flex', overflowWrap: 'anywhere' }}
             data-testid='producer-url'
           >
-            {feed?.source_info?.producer_url !== undefined && (
+            {feed?.source_info?.producer_url != undefined && (
               <a
                 href={feed?.source_info?.producer_url}
                 target='_blank'
@@ -238,7 +238,7 @@ export default function FeedSummary({
       )}
 
       {feed?.data_type === 'gtfs' &&
-        feed?.feed_contact_email !== undefined &&
+        feed?.feed_contact_email != undefined &&
         feed?.feed_contact_email.length > 0 && (
           <Box sx={boxElementStyle}>
             <Typography
@@ -248,7 +248,7 @@ export default function FeedSummary({
             >
               {t('feedContactEmail')}
             </Typography>
-            {feed?.feed_contact_email !== undefined &&
+            {feed?.feed_contact_email != undefined &&
               feed?.feed_contact_email.length > 0 && (
                 <Button
                   sx={{ textOverflow: 'ellipsis', cursor: 'initial' }}
@@ -276,7 +276,7 @@ export default function FeedSummary({
           </Box>
         )}
 
-      {latestDataset?.validation_report?.features !== undefined && (
+      {latestDataset?.validation_report?.features != undefined && (
         <Box sx={boxElementStyle}>
           <Typography
             variant='subtitle1'

web-app/src/app/screens/Feed/PreviousDatasets.tsx

@@ -165,54 +165,45 @@ export default function PreviousDatasets({
                     {(dataset.validation_report === null ||
                       dataset.validation_report === undefined) && (
                       <Button
+                        LinkComponent={'a'}
                         variant='contained'
                         sx={{ mx: 2 }}
                         disableElevation
                         endIcon={<LaunchOutlined />}
+                        href={WEB_VALIDATOR_LINK}
+                        target='_blank'
+                        rel='noreferrer'
                       >
-                        <a
-                          href={WEB_VALIDATOR_LINK}
-                          target='_blank'
-                          className='btn-link'
-                          rel='noreferrer'
-                        >
-                          Run Validator Yourself
-                        </a>
+                        Run Validator Yourself
                       </Button>
                     )}
                     {dataset.validation_report != null && (
                       <>
                         <Button
+                          LinkComponent={'a'}
                           variant='contained'
                           sx={{ mx: 2 }}
                           disableElevation
                           endIcon={<LaunchOutlined />}
+                          href={`${dataset?.validation_report?.url_html}`}
+                          target='_blank'
+                          rel='noreferrer'
+                          data-testid='validation-report-html'
                         >
-                          <a
-                            href={`${dataset?.validation_report?.url_html}`}
-                            target='_blank'
-                            className='btn-link'
-                            rel='noreferrer'
-                            data-testid='validation-report-html'
-                          >
-                            View Report
-                          </a>
+                          View Report
                         </Button>
                         <Button
+                          LinkComponent={'a'}
                           variant='contained'
                           sx={{ mx: 2, my: { xs: 1, xl: 0 } }}
                           endIcon={<LaunchOutlined />}
                           disableElevation
+                          href={`${dataset?.validation_report?.url_json}`}
+                          target='_blank'
+                          rel='noreferrer'
+                          data-testid='validation-report-json'
                         >
-                          <a
-                            href={`${dataset?.validation_report?.url_json}`}
-                            target='_blank'
-                            className='btn-link'
-                            rel='noreferrer'
-                            data-testid='validation-report-json'
-                          >
-                            JSON Version
-                          </a>
+                          JSON Version
                         </Button>
                       </>
                     )}

web-app/src/app/screens/Feed/index.tsx

@@ -12,7 +12,6 @@ import {
   Skeleton,
 } from '@mui/material';
 import { ChevronLeft } from '@mui/icons-material';
-import '../../styles/SignUp.css';
 import '../../styles/FAQ.css';
 import { ContentBox } from '../../components/ContentBox';
 import { useAppDispatch } from '../../hooks';