fix: populate gbfs script setting producer_url as autodiscovery_url (#1223)

Author: davidgamez

api/src/scripts/gbfs_utils/fetching.py

@@ -23,7 +23,7 @@ def fetch_data(auto_discovery_url, logger, urls=[], fields=[]):
                 break
             elif not feeds:
                 feeds = lang_feeds
-        logger.info(f"Feeds found from auto-discovery URL {auto_discovery_url}: {feeds}")
+        logger.debug(f"Feeds found from auto-discovery URL {auto_discovery_url}: {feeds}")
         if feeds:
             for url in urls:
                 fetched_data[url] = get_field_url(feeds, url)

api/src/scripts/populate_db_gbfs.py

@@ -91,7 +91,7 @@ def populate_db(self, session, fetch_url=True):
                 gbfs_feed.operator = row["Name"]
                 gbfs_feed.provider = row["Name"]
                 gbfs_feed.operator_url = row["URL"]
-                gbfs_feed.producer_url = row["URL"]
+                gbfs_feed.producer_url = row["Auto-Discovery URL"]
                 gbfs_feed.auto_discovery_url = row["Auto-Discovery URL"]
                 gbfs_feed.updated_at = datetime.now(pytz.utc)
 

liquibase/changelog.xml

@@ -61,4 +61,5 @@
     <include file="changes/feat_1082.sql" relativeToChangelogFile="true"/>
     <include file="changes/feat_1181.sql" relativeToChangelogFile="true"/>
     <include file="changes/feat_1182.sql" relativeToChangelogFile="true"/>
+    <include file="changes/feat_1200.sql" relativeToChangelogFile="true"/>
 </databaseChangeLog>

liquibase/changes/feat_1200.sql

@@ -0,0 +1,17 @@
+-- This SQL updates the producer's url to autodiscovery_url for all GBFS feeds
+
+-- Populate producer_url in the feed entity with the autodiscovery_url from the gbfsfeed table
+UPDATE feed
+SET producer_url = (
+  SELECT
+    auto_discovery_url
+  FROM
+    gbfsfeed
+  WHERE
+    feed.id = gbfsfeed.id
+)
+WHERE producer_url IS NULL and data_type = 'gbfs';
+
+
+-- Update search
+REFRESH MATERIALIZED VIEW CONCURRENTLY feedsearch;