Added INSTALL_LATEST for manual trigger so it's somewhat testable.

Author: jcpitre

.github/workflows/db-update-dev.yml

@@ -12,7 +12,7 @@ on:
   workflow_dispatch:
     inputs:
       DRY_RUN:
-        description: Skip applying schema and content updates
+        description: Dry run. Skip applying schema and content updates
         required: false
         default: false
         type: boolean
@@ -28,9 +28,14 @@ jobs:
       API_BASE_URL: api-dev.mobilitydatabase.org
       # DRY_RUN is only if requested by the user in a workflow_dispatch
       DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && inputs.DRY_RUN }}
-      # We always want to install the latest except if we received a dispatch from mobility_database_catalog.
-      # In that case we want to keep the currently installed version.
-      INSTALL_LATEST: ${{ github.event_name != 'repository_dispatch' }}
+      # We want to use the currently installed version (not the latest) if we received a dispatch from
+      #   mobility_database_catalog.
+      # For a workflow_dispatch (manual trigger), we use the value set by the user.
+      INSTALL_LATEST: ${{
+        (github.event_name == 'repository_dispatch' && false) ||
+        (github.event_name == 'workflow_dispatch' && inputs.INSTALL_LATEST)
+      } }
+
     secrets:
       DB_USER_PASSWORD: ${{ secrets.DEV_POSTGRE_USER_PASSWORD }}
       DB_USER_NAME: ${{ secrets.DEV_POSTGRE_USER_NAME }}

.github/workflows/db-update-prod.yml

@@ -4,10 +4,15 @@ on:
   workflow_dispatch:  # Manual trigger
     inputs:
       DRY_RUN:
-        description: Skip applying schema and content updates
+        description: Dry run. Skip applying schema and content updates
         required: false
         default: false
         type: boolean
+      INSTALL_LATEST:
+        description: Install the latest (main) API version when true; when false install the currently deployed version.
+        required: false
+        default: true
+        type: boolean
   workflow_call: []
   repository_dispatch: # Update on mobility-database-catalog repo dispatch
     types: [ catalog-sources-updated, gbfs-systems-updated ]
@@ -23,9 +28,16 @@ jobs:
       API_BASE_URL: api.mobilitydatabase.org
       # DRY_RUN is only if requested by the user in a workflow_dispatch
       DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && inputs.DRY_RUN }}
-      # We always want to install the latest except if we received a dispatch from mobility_database_catalog.
-      # In that case we want to keep the currently installed version.
-      INSTALL_LATEST: ${{ github.event_name != 'repository_dispatch' }}
+      # We want to use the currently installed version (not the latest) if we received a dispatch from
+      #   mobility_database_catalog.
+      # We want to use the latest version if the trigger was workflow_call, because currently it's used for
+      #   upgrading (e.g. release.yml)
+      # For a workflow_dispatch (manual trigger), we use the value set by the user.
+      INSTALL_LATEST: ${{
+        (github.event_name == 'repository_dispatch' && false) ||
+        (github.event_name == 'workflow_call' && true) ||
+        (github.event_name == 'workflow_dispatch' && inputs.INSTALL_LATEST)
+      }}
     secrets:
       DB_USER_PASSWORD: ${{ secrets.PROD_POSTGRE_USER_PASSWORD }}
       DB_USER_NAME: ${{ secrets.PROD_POSTGRE_USER_NAME }}

.github/workflows/db-update-qa.yml

@@ -4,7 +4,7 @@ on:
   workflow_dispatch:
     inputs:
       DRY_RUN:
-        description: Skip applying schema and content updates
+        description: Dry run. Skip applying schema and content updates
         required: false
         default: false
         type: boolean
@@ -25,9 +25,17 @@ jobs:
       API_BASE_URL: api-qa.mobilitydatabase.org
       # DRY_RUN is only if requested by the user in a workflow_dispatch
       DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && inputs.DRY_RUN }}
-      # We always want to install the latest except if we received a dispatch from mobility_database_catalog.
-      # In that case we want to keep the currently installed version.
-      INSTALL_LATEST: ${{ github.event_name != 'repository_dispatch' }}
+      # We want to use the currently installed version (not the latest) if we received a dispatch from
+      #   mobility_database_catalog.
+      # We want to use the latest version if the trigger was workflow_call, because currently it's used for
+      #   upgrading (e.g. release.yml)
+      # For a workflow_dispatch (manual trigger), we use the value set by the user.
+      INSTALL_LATEST: ${{
+        (github.event_name == 'repository_dispatch' && false) ||
+        (github.event_name == 'workflow_call' && true) ||
+        (github.event_name == 'workflow_dispatch' && inputs.INSTALL_LATEST)
+      }}
+
     secrets:
       DB_USER_PASSWORD: ${{ secrets.QA_POSTGRE_USER_PASSWORD }}
       DB_USER_NAME: ${{ secrets.QA_POSTGRE_USER_NAME }}