Skip to content

Commit c42c3f2

Browse files
authored
fix: missing reports after release of GTFS validator (#969)
1 parent 800d355 commit c42c3f2

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

.github/workflows/validator-update.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,12 @@ jobs:
3333
run: |
3434
gcloud tasks create-http-task \
3535
--queue=update-validation-report-task-queue \
36-
--url=https://${ENVIRONMENT}-${PROJECT_ID}.cloudfunctions.net/update-validation-report \
36+
--url=https://${{ vars.MOBILITY_FEEDS_REGION }}-${PROJECT_ID}.cloudfunctions.net/update-validation-report \
3737
--schedule-time=$(date -u -d "+24 hours" +%Y-%m-%dT%H:%M:%SZ) \
3838
--oidc-service-account-email=${DEPLOYER_SERVICE_ACCOUNT} \
39-
--location=${{ vars.MOBILITY_FEEDS_REGION }}
39+
--location=${{ vars.MOBILITY_FEEDS_REGION }} \
40+
--header=Content-Type:application/json \
41+
--body-content='{}'
4042
notify-slack-on-failure:
4143
needs: [ validator-update ]
4244
if: failure() && (github.event_name != 'workflow_dispatch')

functions-python/update_validation_report/function_config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
],
1515
"ingress_settings": "ALLOW_INTERNAL_AND_GCLB",
1616
"max_instance_request_concurrency": 1,
17-
"max_instance_count": 5,
17+
"max_instance_count": 1,
1818
"min_instance_count": 0,
1919
"available_cpu": 1
2020
}

infra/functions-python/main.tf

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,6 +1413,19 @@ resource "google_cloud_tasks_queue" "update_validation_report_task_queue" {
14131413
project = var.project_id
14141414
location = var.gcp_region
14151415
name = "update-validation-report-task-queue"
1416+
1417+
rate_limits {
1418+
max_concurrent_dispatches = 1
1419+
max_dispatches_per_second = 1
1420+
}
1421+
1422+
retry_config {
1423+
# This will make the cloud task retry for ~1 hour
1424+
max_attempts = 31
1425+
min_backoff = "120s"
1426+
max_backoff = "120s"
1427+
max_doublings = 2
1428+
}
14161429
}
14171430

14181431
# Task queue to invoke gbfs_validator_batch function for the scheduler

0 commit comments

Comments
 (0)