fix linter errors

Author: ianktc

web-app/src/app/screens/FeedSubmission/Form/FirstStep.tsx

@@ -21,7 +21,7 @@ import {
 import { type YesNoFormInput, type FeedSubmissionFormFormInput } from '.';
 import { useEffect } from 'react';
 import { useTranslation } from 'react-i18next';
-import { isValidFeedLink, checkFeedUrlExistsInCsv } from '../../../services/feeds/utils';
+import { isValidFeedLink, checkFeedUrlExistsInCsv, } from '../../../services/feeds/utils';
 import FormLabelDescription from './components/FormLabelDescription';
 
 export interface FeedSubmissionFormFormInputFirstStep {
@@ -42,7 +42,7 @@ interface FormFirstStepProps {
   setNumberOfSteps: (numberOfSteps: YesNoFormInput) => void;
 }
 
-const realtimeFeedURLPrefix = "https://mobilitydatabase.org/feeds/gtfs/";
+const realtimeFeedURLPrefix = 'https://mobilitydatabase.org/feeds/gtfs/';
 
 export default function FormFirstStep({
   initialValues,
@@ -270,9 +270,11 @@ export default function FormFirstStep({
                   rules={{
                     required: t('form.feedLinkRequired'),
                     validate: async (value) => {
-                      if (!isValidFeedLink(value ?? '')) return t('form.errorUrl');
+                      if (!isValidFeedLink(value ?? '')) {
+                        return t('form.errorUrl');
+                      }
                       const exists = await checkFeedUrlExistsInCsv(value ?? '');
-                      if (exists) {
+                      if (typeof exists === 'string' && exists.length > 0) {
                         return `Feed Exists:${exists}`;
                       }
                       return true;
@@ -287,12 +289,15 @@ export default function FormFirstStep({
                       error={errors.feedLink !== undefined}
                       {...field}
                       helperText={
-                        errors.feedLink?.message?.startsWith('Feed Exists:') ? (
+                        typeof errors.feedLink?.message === 'string' && errors.feedLink.message.startsWith('Feed Exists:') ? (
                           <span>
                             {t('form.feedAlreadyExists')}
-                            <a href=
-                              {errors.feedLink.message.replace('Feed Exists:', `${realtimeFeedURLPrefix}`)} target="_blank" rel="noopener noreferrer">
-                              {t(errors.feedLink.message.replace('Feed Exists:',''))}
+                            <a
+                              href={errors.feedLink.message.replace('Feed Exists:', `${realtimeFeedURLPrefix}`)}
+                              target="_blank"
+                              rel="noopener noreferrer"
+                            >
+                              {t(errors.feedLink.message.replace('Feed Exists:', ''))}
                             </a>
                           </span>
                         ) : (

web-app/src/app/screens/FeedSubmission/Form/SecondStepRealtime.tsx

@@ -10,7 +10,7 @@ import { type SubmitHandler, Controller, useForm } from 'react-hook-form';
 import { type AuthTypes, type FeedSubmissionFormFormInput } from '.';
 import { useEffect } from 'react';
 import { useTranslation } from 'react-i18next';
-import { isValidFeedLink, checkFeedUrlExistsInCsv } from '../../../services/feeds/utils';
+import { isValidFeedLink, checkFeedUrlExistsInCsv, } from '../../../services/feeds/utils';
 
 export interface FeedSubmissionFormInputSecondStepRT {
   tripUpdates: string;
@@ -32,7 +32,7 @@ interface FormSecondStepRTProps {
   handleBack: (formData: Partial<FeedSubmissionFormFormInput>) => void;
 }
 
-const realtimeFeedURLPrefix = "https://mobilitydatabase.org/feeds/gtfs_rt/";
+const realtimeFeedURLPrefix = 'https://mobilitydatabase.org/feeds/gtfs_rt/';
 
 export default function FormSecondStepRT({
   initialValues,
@@ -125,10 +125,13 @@ export default function FormSecondStepRT({
                       errors.serviceAlerts?.message?.startsWith('Feed Exists:') ? (
                         <span>
                           {t('form.feedAlreadyExists')}
-                          <a href=
-                            {errors.serviceAlerts.message.replace('Feed Exists:', `${realtimeFeedURLPrefix}`)} target="_blank" rel="noopener noreferrer">
-                            {t(errors.serviceAlerts.message.replace('Feed Exists:',''))}
-                          </a>
+                            <a
+                              href={errors.serviceAlerts.message.replace('Feed Exists:', `${realtimeFeedURLPrefix}`)}
+                              target="_blank"
+                              rel="noopener noreferrer"
+                            >
+                              {t(errors.serviceAlerts.message.replace('Feed Exists:', ''))}
+                            </a>
                         </span>
                       ) : (
                         errors.serviceAlerts?.message ?? ''
@@ -202,10 +205,13 @@ export default function FormSecondStepRT({
                       errors.tripUpdates?.message?.startsWith('Feed Exists:') ? (
                         <span>
                           {t('form.feedAlreadyExists')}
-                          <a href=
-                            {errors.tripUpdates.message.replace('Feed Exists:', `${realtimeFeedURLPrefix}`)} target="_blank" rel="noopener noreferrer">
-                            {t(errors.tripUpdates.message.replace('Feed Exists:',''))}
-                          </a>
+                            <a
+                              href={errors.tripUpdates.message.replace('Feed Exists:', `${realtimeFeedURLPrefix}`)}
+                              target="_blank"
+                              rel="noopener noreferrer"
+                            >
+                              {t(errors.tripUpdates.message.replace('Feed Exists:', ''))}
+                            </a>
                         </span>
                       ) : (
                         errors.tripUpdates?.message ?? ''
@@ -279,10 +285,13 @@ export default function FormSecondStepRT({
                       errors.vehiclePositions?.message?.startsWith('Feed Exists:') ? (
                         <span>
                           {t('form.feedAlreadyExists')}
-                          <a href=
-                            {errors.vehiclePositions.message.replace('Feed Exists:', `${realtimeFeedURLPrefix}`)} target="_blank" rel="noopener noreferrer">
-                            {t(errors.vehiclePositions.message.replace('Feed Exists:',''))}
-                          </a>
+                            <a
+                              href={errors.vehiclePositions.message.replace('Feed Exists:', `${realtimeFeedURLPrefix}`)}
+                              target="_blank"
+                              rel="noopener noreferrer"
+                            >
+                              {t(errors.vehiclePositions.message.replace('Feed Exists:', ''))}
+                            </a>
                         </span>
                       ) : (
                         errors.vehiclePositions?.message ?? ''