Skip to content

Commit 0eb48de

Browse files
committed
Multiple chnges that should fix some issues
1 parent 49568e8 commit 0eb48de

File tree

3 files changed

+13
-20
lines changed

3 files changed

+13
-20
lines changed

common/src/main/java/org/modsauce/otyacraftenginerenewed/networking/OEPackets.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.modsauce.otyacraftenginerenewed.networking;
22

33
import dev.architectury.networking.NetworkManager;
4+
import dev.architectury.platform.Platform;
45
import java.util.UUID;
56
import net.minecraft.nbt.CompoundTag;
67
import net.minecraft.network.RegistryFriendlyByteBuf;
@@ -36,7 +37,7 @@ public class OEPackets {
3637

3738
public static void init() {
3839
NetworkManager.registerReceiver(
39-
NetworkManager.Side.C2S,
40+
NetworkManager.c2s(),
4041
BLOCK_ENTITY_INSTRUCTION,
4142
(friendlyByteBuf, packetContext) ->
4243
ServerMessageHandler.onBlockEntityInstructionMessage(
@@ -45,7 +46,7 @@ public static void init() {
4546
)
4647
);
4748
NetworkManager.registerReceiver(
48-
NetworkManager.Side.C2S,
49+
NetworkManager.c2s(),
4950
ITEM_INSTRUCTION,
5051
(friendlyByteBuf, packetContext) ->
5152
ServerMessageHandler.onItemInstructionMessage(
@@ -56,21 +57,23 @@ public static void init() {
5657
}
5758

5859
public static void clientInit() {
60+
// S2C Packets - Only register on client side to avoid Fabric networking issues
61+
// The server doesn't need to register S2C receivers, only the client does
5962
NetworkManager.registerReceiver(
60-
NetworkManager.Side.S2C,
63+
NetworkManager.s2c(),
6164
BLOCK_ENTITY_INSTRUCTION_RETURN,
6265
(friendlyByteBuf, packetContext) ->
6366
ClientMessageHandler.onBlockEntityInstructionReturn(
64-
new BlockEntityInstructionMessage(friendlyByteBuf),
67+
new BlockEntityInstructionMessage((RegistryFriendlyByteBuf) friendlyByteBuf),
6568
packetContext
6669
)
6770
);
6871
NetworkManager.registerReceiver(
69-
NetworkManager.Side.S2C,
72+
NetworkManager.s2c(),
7073
ITEM_INSTRUCTION_RETURN,
7174
(friendlyByteBuf, packetContext) ->
7275
ClientMessageHandler.onItemInstructionReturn(
73-
new ItemInstructionMessage(friendlyByteBuf),
76+
new ItemInstructionMessage((RegistryFriendlyByteBuf) friendlyByteBuf),
7477
packetContext
7578
)
7679
);

fabric/src/main/java/org/modsauce/otyacraftenginerenewed/fabric/mixin/client/MinecraftMixin.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,18 +33,8 @@ private void setLevel(
3333
if (level != null) OEClientEventHooks.onLevelUnload(level);
3434
}
3535

36-
@Inject(
37-
method = "clearLevel",
38-
at = @At(
39-
value = "INVOKE",
40-
target = "Lnet/minecraft/client/Minecraft;updateScreenAndTick(Lnet/minecraft/client/gui/screens/Screen;)V",
41-
ordinal = 0,
42-
shift = At.Shift.AFTER
43-
)
44-
)
45-
private void clearLevel(Screen screen, CallbackInfo ci) {
46-
if (this.level != null) OEClientEventHooks.onLevelUnload(level);
47-
}
36+
// TODO: Fix for MC 1.21.1 - clearLevel method was renamed or removed
37+
// The level unload functionality is handled by setLevel injection and NeoForge events
4838

4939
@Inject(
5040
method = "continueAttack",

gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ mod_version=3.7.1-1.21.1-alpha1
1111
# Dependencies
1212
architectury_version=13.0.8
1313
fabric_loader_version=0.17.2
14-
fabric_api_version=0.116.5+1.21.1
15-
neoforge_version=21.1.200
14+
fabric_api_version=0.116.7+1.21.1
15+
neoforge_version=21.1.213
1616
felnull_version=1.75
1717
cloth_config_version=15.0.140
1818
modmenu_version=11.0.3

0 commit comments

Comments
 (0)