Skip to content

Commit 322953f

Browse files
authored
Merge pull request #48 from Onoyiza/test_os-win-mac
Test os win mac
2 parents 3b9efde + 77eb30f commit 322953f

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,13 @@ jobs:
1919
extra_args: --hook-stage manual --all-files
2020

2121
build:
22-
23-
runs-on: ubuntu-latest
22+
name: Build for Python ${{ matrix.python-version }} on ${{ matrix.runs-on }}
23+
runs-on: ${{ matrix.runs-on }}
2424
strategy:
2525
fail-fast: false
2626
matrix:
27-
python-version: ["3.7", "3.8", "3.9", "3.10"]
27+
python-version: [ "3.7", "3.8", "3.9", "3.10"]
28+
runs-on: [ubuntu-latest, macos-latest, windows-latest]
2829

2930
steps:
3031
- uses: actions/checkout@v2

docs/contributors.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,17 @@
2121
url = per_info[i]
2222
print(url)
2323
data = requests.get(url=url)
24-
empty_list.append(data.json())
24+
requests_status = "unknown"
25+
while (requests_status == "unknown") or (requests_status == "unsuccessful"):
26+
if data.status_code == 200:
27+
requests_status = "successful"
28+
empty_list.append(data.json())
29+
else:
30+
# handle failure on requests to the url for mac os
31+
requests_status = "unsuccessful"
32+
print(f"Failed to get data from: {url}")
33+
# make request again to get data from the url
34+
data = requests.get(url=url)
2535

2636
df1 = pd.DataFrame(empty_list)
2737
df1["name"] = df1["name"].fillna("")

0 commit comments

Comments
 (0)