generate code using fqt for bool #134
Open
+136
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
3 times, most recently
from
525c7f7 to
e94ab4b
Compare
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
from
e94ab4b to
0fa4f36
Compare
ModProg
force-pushed
the
generate-code-using-fqt-for-bool
branch
from
0fa4f36 to
cf14e42
Compare
daxpedda
approved these changes
Nov 25, 2025
Collaborator
daxpedda
left a comment
daxpedda
left a comment
There was a problem hiding this comment.
Missing a changelog entry, otherwise looks good.
I'm yet again surprised what we have to account for in a proc-macro ...
| #[repr(C)] | ||
| enum Test { | ||
| A = isize::MAX - 2, | ||
| A = (u32::MAX - 2) as isize, |
Owner
Author
There was a problem hiding this comment.
Because while we can use isize as a type, we are only allowed to use i32 values in future versions of rust with repr(C), I could probably simplify this by just using the value of i32::MAX directly
Collaborator
There was a problem hiding this comment.
I think we should stick with isize until we get there, we also use isize internally, so we should test for that.
(on a side note: I'm doubtful this change will actually happen because it would break too much)
daxpedda
reviewed
Nov 26, 2025
| #[repr(C)] | ||
| enum Test { | ||
| A = -0x8000_0000_0000_0000_isize, | ||
| A = (-0x8000_0000_i32) as isize, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #133