Fix review comments: remove unused imports and redundant check_toolset_files method

Co-authored-by: MaestroError <46760939+MaestroError@users.noreply.github.com>

Author: Copilot

README.md

@@ -372,7 +372,7 @@ These are critical issues that prevent the schema from being used. Validation us
 - **Required fields**: Presence of `schemaVersion` and `metadata`
 - **Data types**: Field values match expected types
 - **Tool definitions**: Valid execution types and input schemas
-- **Toolset references**: Toolset files exist in the `mci/` directory
+- **Toolset references**: Referenced toolsets must exist in the `mci/` directory (validated by MCIClient)
 - **MCP server definitions**: Valid server configurations
 
 If any errors are found, validation fails and the schema cannot be used.

src/mci/core/validator.py

@@ -90,10 +90,7 @@ def validate_schema(self) -> ValidationResult:
             errors.append(ValidationError(message=f"Failed to load schema data: {str(e)}"))
             return ValidationResult(errors=errors, warnings=warnings, is_valid=False)
 
-        # Perform additional checks (as warnings)
-        toolset_warnings = self.check_toolset_files()
-        warnings.extend(toolset_warnings)
-
+        # Perform additional checks for MCP commands (as warnings)
         mcp_warnings = self.check_mcp_commands()
         warnings.extend(mcp_warnings)
 
@@ -121,51 +118,6 @@ def _load_schema_data(self) -> None:
             else:
                 raise ValueError(f"Unsupported file format: {file_path.suffix}")
 
-    def check_toolset_files(self) -> list[ValidationWarning]:
-        """
-        Check that referenced toolset files exist.
-
-        Returns:
-            List of ValidationWarning for missing toolset files
-
-        Example:
-            >>> validator = MCIValidator("mci.json")
-            >>> validator._load_schema_data()
-            >>> warnings = validator.check_toolset_files()
-        """
-        warnings: list[ValidationWarning] = []
-
-        if not self.schema_data:
-            return warnings
-
-        toolsets = self.schema_data.get("toolsets", [])
-        if not toolsets:
-            return warnings
-
-        schema_dir = Path(self.file_path).parent
-        mci_dir = schema_dir / "mci"
-
-        # Type narrowing: toolsets should be a list
-        if not isinstance(toolsets, list):
-            return warnings
-
-        for toolset in toolsets:
-            if isinstance(toolset, str):
-                # Toolset is a string reference (e.g., "weather")
-                # Should correspond to mci/weather.mci.json or mci/weather.mci.yaml
-                toolset_json = mci_dir / f"{toolset}.mci.json"
-                toolset_yaml = mci_dir / f"{toolset}.mci.yaml"
-
-                if not toolset_json.exists() and not toolset_yaml.exists():
-                    warnings.append(
-                        ValidationWarning(
-                            message=f"Toolset file not found: {toolset}",
-                            suggestion=f"Create {toolset_json} or {toolset_yaml}, or update the toolset reference",
-                        )
-                    )
-
-        return warnings
-
     def check_mcp_commands(self) -> list[ValidationWarning]:
         """
         Check that MCP server commands are available in PATH.

tests/test_validate_command.py

@@ -8,7 +8,6 @@
 import tempfile
 from pathlib import Path
 
-import pytest
 from click.testing import CliRunner
 
 from mci.cli.validate import validate

tests/unit/core/test_validator.py

@@ -8,10 +8,7 @@
 import tempfile
 from pathlib import Path
 
-import pytest
-
-from mci.core.validator import MCIValidator, ValidationResult
-from mci.utils.error_formatter import ValidationError, ValidationWarning
+from mci.core.validator import MCIValidator
 
 
 def test_valid_schema_via_mciclient():

testsManual/test_validate.py

@@ -84,7 +84,12 @@ def test_invalid_schema():
 
 
 def test_schema_with_missing_toolsets():
-    """Test 3: Schema with missing toolset files (errors in MCIClient)."""
+    """
+    Test 3: Schema with missing toolset files.
+    
+    MCIClient validates toolset references and treats missing toolsets as errors.
+    This test demonstrates that validation fails when toolsets don't exist in the mci/ directory.
+    """
     console = Console()
     print_section(console, "Test 3: Schema with Missing Toolset Files (Errors)")