Skip to content

Commit 204d141

Browse files
committed
[app-builder] clean code
1 parent badeffa commit 204d141

File tree

7 files changed

+23
-5
lines changed

7 files changed

+23
-5
lines changed

CONTRIBUTING.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,15 @@ Licensed under the MIT License. See License.txt in the project root for license
6666
- 所有 `@param``@return` 的注释,最后都需要根据其类型添加引用,基本类型需要添加 `{@code }` 标记,其他需要添加 `{@link }` 标记。
6767
- 所有半角字符和全角字符之间需要增加一个空格,来使得整体排版规整,方便超长内容的换行。
6868

69+
### 插件sql
70+
71+
- 如果插件包含数据库相关操作,需要在插件的 `resources` 目录下创建 `sql` 目录,其中包含 `schema` 目录(存放创表相关语句)和 `data` 目录(存放预置数据相关的语句)。具体目录格式如下:
72+
```text
73+
sql
74+
├── schema
75+
└── data
76+
```
77+
6978
## 提交规则
7079

7180
### 本地提交配置

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ fit start -Dfit.profiles.active=prod
112112

113113
> 这里直接使用了 `fit` 命令,该命令请参考 `fit-framework` 项目的[指导手册](https://github.com/ModelEngine-Group/fit-framework/blob/main/docs/framework/fit/java/quick-start-guide/03.%20%E4%BD%BF%E7%94%A8%E6%8F%92%E4%BB%B6%E7%9A%84%E7%83%AD%E6%8F%92%E6%8B%94%E8%83%BD%E5%8A%9B.md)
114114
>
115-
> 当前,`app-platform` 使用了 `fit` 的 3.5.0-M4 版本,因此,如果采用手动编译,需要在 `fit-framework` 仓库中切换到 `v3.5.0-M3` 标签处进行编译构建操作。
115+
> 当前,`app-platform` 使用了 `fit` 的 3.5.0-M4 版本,因此,如果采用手动编译,需要在 `fit-framework` 仓库中切换到 `v3.5.0-M4` 标签处进行编译构建操作。
116116
117117
---------
118118

app-builder/plugins/aipp-custom-model-center/src/main/resources/sql/data/app_engine_model_upgrade_250625.sql renamed to app-builder/plugins/aipp-custom-model-center/src/main/resources/sql/data/01_app_engine_model_upgrade.sql

File renamed without changes.

app-builder/plugins/tool-waterflow/src/test/java/modelengine/jade/carver/tool/waterflow/WaterFlowToolCallWrapperTest.java renamed to app-builder/plugins/tool-waterflow/src/test/java/modelengine/jade/carver/tool/waterflow/WaterFlowToolCallAdapterTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
import java.util.HashMap;
2525

2626
/**
27-
* {@link WaterFlowToolCallAdapter} 的测试
27+
* {@link WaterFlowToolCallAdapter} 的测试
2828
*
29-
* @author songyongtan
30-
* @since 2024/12/17
29+
* @author 宋永坦
30+
* @since 2024-12-17
3131
*/
3232
@ExtendWith(MockitoExtension.class)
3333
class WaterFlowToolCallAdapterTest {

app-builder/plugins/waterflow-appfactory/src/main/java/modelengine/fit/waterflow/appfactory/fitable/AippFlowDefinitionServiceImpl.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,11 @@ public void deleteFlows(String metaId, String version, OperationContext context)
9191
flowsService.deleteFlows(metaId, version, convertOperationContext(context));
9292
}
9393

94+
/**
95+
* convert the context type.
96+
* @param context the provided context.
97+
* @return waterflow context.
98+
*/
9499
public static modelengine.fit.waterflow.entity.OperationContext convertOperationContext(OperationContext context) {
95100
if (Objects.isNull(context)) {
96101
return modelengine.fit.waterflow.entity.OperationContext.custom().build();

app-builder/plugins/waterflow-graph/src/main/java/modelengine/fit/waterflow/graph/FlowsEngineWebService.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,11 @@ public FlowInfo getFlowDefinitionById(String definitionId, OperationContext cont
287287
return flowInfo;
288288
}
289289

290+
/**
291+
* convert the context type.
292+
* @param context the provided context.
293+
* @return waterflow context.
294+
*/
290295
public static modelengine.fit.waterflow.entity.OperationContext convertOperationContext(OperationContext context) {
291296
return modelengine.fit.waterflow.entity.OperationContext.custom()
292297
.tenantId(context.getTenantId())

app-builder/waterflow/java/waterflow-dependency/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
<!-- Framework version -->
1717
<fit.version>3.5.0-M4</fit.version>
18-
<fel.version>1.0.0-SNAPSHOT</fel.version>
1918
<waterflow.core.version>3.5.0-M4</waterflow.core.version>
2019
<waterflow.version>1.0.0-SNAPSHOT</waterflow.version>
2120
<ohscript.version>3.5.0-M4</ohscript.version>

0 commit comments

Comments
 (0)