Skip to content

Commit 72eca5c

Browse files
wuayeewuayee
andauthored
[app-builder] 去除知识库节点的可行性检查 (#531)
Co-authored-by: wuayee <[email protected]>
1 parent 8511761 commit 72eca5c

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed

app-builder/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/service/impl/RetrievalNodeChecker.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,8 @@
66

77
package modelengine.fit.jober.aipp.service.impl;
88

9-
import modelengine.fit.jane.common.entity.OperationContext;
10-
import modelengine.fit.jober.aipp.dto.check.AppCheckDto;
11-
import modelengine.fit.jober.aipp.dto.check.CheckResult;
12-
139
import modelengine.fitframework.annotation.Component;
1410

15-
import java.util.List;
16-
1711
/**
1812
* 普通检索节点的checker
1913
*
@@ -22,8 +16,4 @@
2216
*/
2317
@Component
2418
public class RetrievalNodeChecker extends AbstractNodeChecker {
25-
@Override
26-
public List<CheckResult> validate(AppCheckDto appCheckDto, OperationContext context) {
27-
return this.invalidNodeConfig(appCheckDto, appCheckDto.getType());
28-
}
2919
}

app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/AppBuilderAppServiceImplTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,8 +572,7 @@ void testModelNode() {
572572
mockedStatic.when(() -> CheckerFactory.getChecker(anyString())).thenReturn(new RetrievalNodeChecker());
573573
List<CheckResult> results =
574574
this.appBuilderAppService.checkAvailable(Collections.singletonList(appCheckDto), null);
575-
Assertions.assertFalse(results.get(0).isValid());
576-
Assertions.assertEquals(results.get(0).getConfigChecks().size(), 2);
575+
Assertions.assertTrue(results.isEmpty());
577576
}
578577
}
579578

app-builder/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/CheckerTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,7 @@ public void testRetrievalNode() {
130130
+ "\"createdAt\":\"2024-12-02 12:41:14\",\"checked\":true}]}]}";
131131
AppCheckDto appCheckDto = JsonUtils.parseObject(testNode, AppCheckDto.class);
132132
List<CheckResult> results = this.retrievalNodeChecker.validate(appCheckDto, null);
133-
Assertions.assertEquals(results.size(), 2);
134-
Assertions.assertFalse(results.get(0).isValid());
135-
Assertions.assertEquals(results.get(0).getConfigChecks().size(), 2);
136-
Assertions.assertFalse(results.get(1).isValid());
137-
Assertions.assertEquals(results.get(1).getConfigChecks().size(), 1);
133+
Assertions.assertTrue(results.isEmpty());
138134
}
139135
}
140136

0 commit comments

Comments
 (0)