[fel] clean code

Author: loveTsong

framework/fel/java/fel-community/model-openai/src/main/java/modelengine/fel/community/model/openai/OpenAiModel.java

@@ -60,7 +60,6 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.stream.Collectors;
 
@@ -166,7 +165,7 @@ public List<Media> generate(String prompt, ImageOption option) {
                     .map(entity -> entity.object().media())
                     .orElseThrow(() -> new FitException("The response body is abnormal."));
         } catch (IOException e) {
-            throw new FitException(e);
+            throw new IllegalStateException("Failed to close response.", e);
         }
     }
 

framework/fel/java/fel-core/pom.xml

@@ -56,12 +56,6 @@
             <artifactId>h2</artifactId>
             <scope>test</scope>
         </dependency>
-        
-        <!-- Third-party -->
-        <dependency>
-            <groupId>org.projectlombok</groupId>
-            <artifactId>lombok</artifactId>
-        </dependency>
     </dependencies>
 
     <build>

framework/fel/java/fel-core/src/main/java/modelengine/fel/core/chat/support/FlatChatMessage.java

@@ -6,8 +6,6 @@
 
 package modelengine.fel.core.chat.support;
 
-import lombok.Data;
-import lombok.NoArgsConstructor;
 import modelengine.fel.core.chat.ChatMessage;
 import modelengine.fel.core.chat.MessageType;
 import modelengine.fel.core.tool.ToolCall;
@@ -26,8 +24,6 @@
  * @author 易文渊
  * @since 2024-04-12
  */
-@Data
-@NoArgsConstructor
 public class FlatChatMessage implements ChatMessage {
     private String id;
     private String type;

framework/fel/java/fel-core/src/main/java/modelengine/fel/core/document/support/RerankDocumentProcessor.java

@@ -92,8 +92,7 @@ private RerankResponse rerankExchange(HttpClassicClientRequest request) {
                     .map(ObjectEntity::object)
                     .orElseThrow(() -> new FitException("The response body is abnormal.")));
         } catch (IOException e) {
-            log.error("Failed to request rerank model.", e);
-            throw new FitException(e);
+            throw new IllegalStateException("Failed to request rerank model.", e);
         }
     }
 }

framework/fel/java/fel-flow/src/main/java/modelengine/fel/engine/activities/AiState.java

@@ -106,6 +106,7 @@ public void register(EmitterListener<O, FlowSession> handler) {
         this.state.register(handler);
     }
 
+    @Override
     public void unregister(EmitterListener<O, FlowSession> listener) {
         this.state.unregister(listener);
     }

framework/fel/java/fel-flow/src/main/java/modelengine/fel/engine/flows/AiProcessFlow.java

@@ -51,6 +51,7 @@ public void register(EmitterListener<R, FlowSession> listener) {
         }
     }
 
+    @Override
     public void unregister(EmitterListener<R, FlowSession> listener) {
         EmitterListener<Object, FlowSession> target = this.listeners.remove(listener);
         if (target != null) {

framework/fel/java/fel-flow/src/main/java/modelengine/fel/engine/operators/patterns/AbstractAgent.java

@@ -34,7 +34,6 @@ public abstract class AbstractAgent extends AbstractFlowPattern<Prompt, ChatMess
     private static final String AGENT_MEMORY = "agent_memory";
     private static final String CHECK_POINT = "check_point";
 
-    @Getter
     private final ChatFlowModel model;
     private final String memoryId;
 
@@ -64,6 +63,15 @@ protected AbstractAgent(ChatFlowModel flowModel, String memoryId) {
         this.memoryId = notBlank(memoryId, "The agent message key cannot be blank.");
     }
 
+    /**
+     * 获取配置的模型对象。
+     *
+     * @return 配置的模型对象。
+     */
+    public ChatFlowModel getModel() {
+        return model;
+    }
+
     /**
      * 执行工具调用。
      *

framework/fel/java/fel-flow/src/main/java/modelengine/fel/engine/operators/patterns/AbstractFlowPattern.java

@@ -105,11 +105,11 @@ public Flow<I> origin() {
     }
 
     /**
-     * built the flow session for starting the conversation.
+     * Built the flow session for starting the conversation.
      *
-     * @param emitter the {@link FlowEmitter}{@code <}{@link O}{@code >} representing output emitter.
-     * @return {@link FlowSession}.
-     * @param <O> the output data type.
+     * @param emitter The {@link FlowEmitter}{@code <}{@link O}{@code >} representing output emitter.
+     * @return The new {@link FlowSession}.
+     * @param <O> The output data type.
      */
     protected static <O> FlowSession buildFlowSession(FlowEmitter<O> emitter) {
         FlowSession mainSession = AiFlowSession.require();
@@ -124,12 +124,18 @@ private AiProcessFlow<I, O> getFlow() {
         return Validation.notNull(this.flowSupplier.get(), "The flow cannot be null.");
     }
 
+    /**
+     * A functional interface defining an action to be performed with processed results.
+     * Implementations handle both the result data and its associated flow session context.
+     *
+     * @param <O> The type of result data to be processed.
+     */
     protected interface ResultAction<O> {
         /**
-         * process the result.
+         * Process the result.
          *
-         * @param data the result of {@link O}.
-         * @param flowSession the result flow session of {@link FlowSession}.
+         * @param data The result of {@link O}.
+         * @param flowSession The result flow session of {@link FlowSession}.
          */
         void process(O data, FlowSession flowSession);
     }

framework/fel/java/fel-flow/src/main/java/modelengine/fel/engine/operators/patterns/FlowNodeSupportable.java

@@ -18,7 +18,7 @@
  *
  * @param <I> 表示输入数据的类型。
  * @param <O> 表示流程处理完成的数据类型。
- * @author songyongtan
+ * @author 宋永坦
  * @since 2025-05-16
  */
 public class FlowNodeSupportable<I, O> extends AbstractFlowPattern<I, O> {

framework/fel/java/services/fel-pipeline-service/pom.xml

@@ -21,12 +21,6 @@
             <groupId>org.fitframework</groupId>
             <artifactId>fit-util</artifactId>
         </dependency>
-
-        <!-- Lombok -->
-        <dependency>
-            <groupId>org.projectlombok</groupId>
-            <artifactId>lombok</artifactId>
-        </dependency>
     </dependencies>
 
     <build>