Skip to content

Commit 9f859e6

Browse files
authored
[fit] correct Javadoc of isInvalidCookiePair & add default value for Cookie.Builder.value (#343)
* [fit] correct Javadoc of isInvalidCookiePair to reflect invalid check * [fit] add default value for Cookie.Builder.value * [fit] update cookie parse test
1 parent c42a85a commit 9f859e6

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/Cookie.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
package modelengine.fit.http;
88

99
import modelengine.fitframework.pattern.builder.BuilderFactory;
10+
import modelengine.fitframework.util.StringUtils;
1011

1112
/**
1213
* 表示 Http 中的 Cookie。
@@ -210,7 +211,7 @@ interface Builder {
210211
* @return 表示 {@link Cookie} 的构建器的 {@link Builder}。
211212
*/
212213
static Builder builder() {
213-
return builder(null).maxAge(-1);
214+
return builder(null).value(StringUtils.EMPTY).maxAge(-1).secure(false).httpOnly(false);
214215
}
215216

216217
/**

framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/main/java/modelengine/fit/http/util/HttpUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,11 +229,11 @@ private static void parseCookieAttributes(String[] parts, Cookie.Builder builder
229229
}
230230

231231
/**
232-
* 验证给定的 Cookie 名称和值是否合法
232+
* 判断给定的 Cookie 名称和值是否无效
233233
*
234234
* @param name 表示 Cookie 的名称 {@link String}。
235235
* @param value 表示 Cookie 的值 {@link String},允许为空但不允许为 {@code null},可带双引号。
236-
* @return 如果 name value 都合法返回 {@code true},否则返回 {@code false}。
236+
* @return 如果 name value 无效返回 {@code true},否则返回 {@code false}。
237237
*/
238238
public static boolean isInvalidCookiePair(String name, String value) {
239239
if (StringUtils.isEmpty(name) || !TOKEN_PATTERN.matcher(name).matches()) {

framework/fit/java/fit-builtin/services/fit-http-classic/definition/src/test/java/modelengine/fit/http/util/HttpUtilsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ void givenValidSetCookieStringThenParseSuccessfully() {
8282
void givenEmptySetCookieThenReturnEmptyCookie() {
8383
Cookie cookie = HttpUtils.parseSetCookie("");
8484
assertThat(cookie.name()).isNull();
85-
assertThat(cookie.value()).isNull();
85+
assertThat(cookie.value()).isEmpty();
8686
}
8787

8888
@Test

0 commit comments

Comments
 (0)