✨ Now supports add/delete/edit chunks

✨ Chunk hybrid search now works in the knowledgebase rather than the document

Author: Jasonxia007

test/backend/services/test_vectordatabase_service.py

@@ -1144,6 +1144,70 @@ def test_search_hybrid_exception(self):
             )
         self.assertIn("Error executing hybrid search", str(context.exception))
 
+    def test_search_hybrid_weight_accurate_boundary_values(self):
+        """Test search_hybrid with different weight_accurate values to ensure line 1146 is covered."""
+        # Test with weight_accurate = 0.0 (semantic only)
+        self.mock_vdb_core.hybrid_search.return_value = [
+            {
+                "document": {"title": "Doc1", "content": "Content1"},
+                "score": 0.90,
+                "index": "test_index",
+            }
+        ]
+
+        result = ElasticSearchService.search_hybrid(
+            index_names=["test_index"],
+            query="test query",
+            tenant_id="test_tenant",
+            top_k=10,
+            weight_accurate=0.0,
+            vdb_core=self.mock_vdb_core
+        )
+        self.assertEqual(len(result["results"]), 1)
+        self.mock_vdb_core.hybrid_search.assert_called_with(
+            index_names=["test_index"],
+            query_text="test query",
+            embedding_model=self.mock_embedding,
+            top_k=10,
+            weight_accurate=0.0
+        )
+
+        # Test with weight_accurate = 1.0 (accurate only)
+        self.mock_vdb_core.hybrid_search.reset_mock()
+        result = ElasticSearchService.search_hybrid(
+            index_names=["test_index"],
+            query="test query",
+            tenant_id="test_tenant",
+            top_k=10,
+            weight_accurate=1.0,
+            vdb_core=self.mock_vdb_core
+        )
+        self.mock_vdb_core.hybrid_search.assert_called_with(
+            index_names=["test_index"],
+            query_text="test query",
+            embedding_model=self.mock_embedding,
+            top_k=10,
+            weight_accurate=1.0
+        )
+
+        # Test with weight_accurate = 0.3 (more semantic)
+        self.mock_vdb_core.hybrid_search.reset_mock()
+        result = ElasticSearchService.search_hybrid(
+            index_names=["test_index"],
+            query="test query",
+            tenant_id="test_tenant",
+            top_k=10,
+            weight_accurate=0.3,
+            vdb_core=self.mock_vdb_core
+        )
+        self.mock_vdb_core.hybrid_search.assert_called_with(
+            index_names=["test_index"],
+            query_text="test query",
+            embedding_model=self.mock_embedding,
+            top_k=10,
+            weight_accurate=0.3
+        )
+
     def test_health_check_healthy(self):
         """
         Test health check when Elasticsearch is healthy.

test/sdk/vector_database/test_elasticsearch_core.py

@@ -645,6 +645,88 @@ def test_delete_chunk_not_found(elasticsearch_core_instance):
         assert result is False
 
 
+def test_create_chunk_exception(elasticsearch_core_instance):
+    """Test create_chunk raises exception when client.index fails."""
+    elasticsearch_core_instance.client = MagicMock()
+    elasticsearch_core_instance.client.index.side_effect = Exception("Index operation failed")
+    
+    payload = {"id": "chunk-1", "content": "A"}
+    
+    with pytest.raises(Exception) as exc_info:
+        elasticsearch_core_instance.create_chunk("kb-index", payload)
+    
+    assert "Index operation failed" in str(exc_info.value)
+    elasticsearch_core_instance.client.index.assert_called_once()
+
+
+def test_update_chunk_exception_from_resolve(elasticsearch_core_instance):
+    """Test update_chunk raises exception when _resolve_chunk_document_id fails."""
+    elasticsearch_core_instance.client = MagicMock()
+    with patch.object(
+        elasticsearch_core_instance,
+        "_resolve_chunk_document_id",
+        side_effect=Exception("Resolve failed"),
+    ):
+        updates = {"content": "updated"}
+        
+        with pytest.raises(Exception) as exc_info:
+            elasticsearch_core_instance.update_chunk("kb-index", "chunk-1", updates)
+        
+        assert "Resolve failed" in str(exc_info.value)
+        elasticsearch_core_instance.client.update.assert_not_called()
+
+
+def test_update_chunk_exception_from_update(elasticsearch_core_instance):
+    """Test update_chunk raises exception when client.update fails."""
+    elasticsearch_core_instance.client = MagicMock()
+    with patch.object(
+        elasticsearch_core_instance,
+        "_resolve_chunk_document_id",
+        return_value="es-id-1",
+    ):
+        elasticsearch_core_instance.client.update.side_effect = Exception("Update operation failed")
+        
+        updates = {"content": "updated"}
+        
+        with pytest.raises(Exception) as exc_info:
+            elasticsearch_core_instance.update_chunk("kb-index", "chunk-1", updates)
+        
+        assert "Update operation failed" in str(exc_info.value)
+        elasticsearch_core_instance.client.update.assert_called_once()
+
+
+def test_delete_chunk_exception_from_resolve(elasticsearch_core_instance):
+    """Test delete_chunk raises exception when _resolve_chunk_document_id fails with non-NotFoundError."""
+    elasticsearch_core_instance.client = MagicMock()
+    with patch.object(
+        elasticsearch_core_instance,
+        "_resolve_chunk_document_id",
+        side_effect=Exception("Resolve failed"),
+    ):
+        with pytest.raises(Exception) as exc_info:
+            elasticsearch_core_instance.delete_chunk("kb-index", "chunk-1")
+        
+        assert "Resolve failed" in str(exc_info.value)
+        elasticsearch_core_instance.client.delete.assert_not_called()
+
+
+def test_delete_chunk_exception_from_delete(elasticsearch_core_instance):
+    """Test delete_chunk raises exception when client.delete fails with non-NotFoundError."""
+    elasticsearch_core_instance.client = MagicMock()
+    with patch.object(
+        elasticsearch_core_instance,
+        "_resolve_chunk_document_id",
+        return_value="es-id-1",
+    ):
+        elasticsearch_core_instance.client.delete.side_effect = Exception("Delete operation failed")
+        
+        with pytest.raises(Exception) as exc_info:
+            elasticsearch_core_instance.delete_chunk("kb-index", "chunk-1")
+        
+        assert "Delete operation failed" in str(exc_info.value)
+        elasticsearch_core_instance.client.delete.assert_called_once()
+
+
 def test_resolve_chunk_document_id_direct_hit(elasticsearch_core_instance):
     """Test _resolve_chunk_document_id returns given id when ES _id exists."""
     elasticsearch_core_instance.client = MagicMock()