✨ Unit test: Truncation information of files that are too large is displayed to the user #1119

Author: WMC001

backend/services/file_management_service.py

@@ -284,10 +284,12 @@ async def process_image_file(query: str, filename: str, file_content: bytes, ten
     """
     Process image file, convert to text using external API
     """
-    image_stream = BytesIO(file_content)
-    text = convert_image_to_text(query, image_stream, tenant_id, language)
-
-    return f"Image file {filename} content: {text}"
+    try:
+        image_stream = BytesIO(file_content)
+        text = convert_image_to_text(query, image_stream, tenant_id, language)
+        return f"Image file {filename} content: {text}"
+    except Exception as e:
+        return f"Image file {filename} content: Error processing image file {filename}: {str(e)}"
 
 
 async def process_text_file(query: str, filename: str, file_content: bytes, tenant_id: str, language: str = 'zh') -> tuple[str, Optional[str]]:
@@ -325,16 +327,22 @@ async def process_text_file(query: str, filename: str, file_content: bytes, tena
                 f"File processing failed (status code: {response.status_code}): {error_detail}")
 
     except Exception as e:
-        raise Exception(f"Error processing file: {str(e)}")
+        return f"File {filename} content: Error processing text file {filename}: {str(e)}", None
 
-    text, truncation_percentage = convert_long_text_to_text(query, raw_text, tenant_id, language)
-    return f"File {filename} content: {text}", truncation_percentage
+    try:
+        text, truncation_percentage = convert_long_text_to_text(query, raw_text, tenant_id, language)
+        return f"File {filename} content: {text}", truncation_percentage
+    except Exception as e:
+        return f"File {filename} content: Error processing text file {filename}: {str(e)}", None
 
 
 def get_file_description(files: List[UploadFile]) -> str:
     """
     Generate file description text
     """
+    if not files:
+        return "User provided some reference files:\nNo files provided"
+    
     description = "User provided some reference files:\n"
     for file in files:
         ext = os.path.splitext(file.filename or "")[1].lower()

test/backend/app/test_file_management_app.py

@@ -545,85 +545,6 @@ async def mock_generator(*args, **kwargs):
             assert response is not None
 
 
-@pytest.mark.asyncio
-async def test_process_image_file(mock_files):
-    # Import directly in the test to use the already established mocks
-    from backend.services.file_management_service import process_image_file
-
-    with patch("backend.services.file_management_service.convert_image_to_text") as mock_convert:
-        # Configure mock
-        mock_convert.return_value = "Extracted text from image"
-
-        # Test the function
-        result = await process_image_file(
-            query="Test query",
-            filename="test.jpg",
-            file_content=mock_files["mock_image_content"],
-            tenant_id="tenant123"
-        )
-
-        # Assertions
-        assert "Image file test.jpg content" in result
-        assert "Extracted text from image" in result
-
-
-@pytest.mark.asyncio
-async def test_process_text_file(mock_files):
-    # Import directly in the test to use the already established mocks
-    from backend.services.file_management_service import process_text_file
-
-    # Mock multiple functions to ensure complete coverage of all call paths
-    with patch('backend.utils.config_utils.get_model_name_from_config', return_value="test-model"), \
-            patch('backend.utils.attachment_utils.get_model_name_from_config', return_value="test-model"), \
-            patch('backend.utils.attachment_utils.convert_long_text_to_text', return_value="Processed text content"), \
-            patch('backend.services.file_management_service.convert_long_text_to_text', return_value="Processed text content"):
-
-        with patch('httpx.AsyncClient') as mock_client:
-            # Setup mock response for httpx client
-            mock_response = MagicMock()
-            mock_response.status_code = 200
-            mock_response.json.return_value = {
-                "text": "Extracted raw text from file"}
-
-            mock_client_instance = MagicMock()
-            mock_client_instance.post.return_value = asyncio.Future()
-            mock_client_instance.post.return_value.set_result(mock_response)
-            mock_client.return_value.__aenter__.return_value = mock_client_instance
-
-            # Test the function
-            result, truncation_percentage = await process_text_file(
-                query="Test query",
-                filename="test.txt",
-                file_content=mock_files["mock_file_content"],
-                tenant_id="tenant123",
-                language="en"
-            )
-
-            # Assertions
-            assert "File test.txt content" in result
-            assert truncation_percentage is None
-
-
-def test_get_file_description(mock_files):
-    # Import directly in the test to use the already established mocks
-    from backend.services.file_management_service import get_file_description
-
-    # Create mock UploadFile objects
-    text_file = MagicMock()
-    text_file.filename = "document.txt"
-
-    image_file = MagicMock()
-    image_file.filename = "photo.jpg"
-
-    # Test the function
-    result = get_file_description([text_file, image_file])
-
-    # Assertions
-    assert "User provided some reference files" in result
-    assert "Image file photo.jpg" in result
-    assert "File document.txt" in result
-
-
 def test_options_route():
     # Create test client
     with TestClient(app) as client: