Skip to content

Commit 133b642

Browse files
author
jiangpeiling
committed
πŸ› Knowledge base summary failed. #1619
1 parent 0ee8bd9 commit 133b642

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

β€Žbackend/utils/document_vector_utils.pyβ€Ž

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -424,9 +424,8 @@ def summarize_document(document_content: str, filename: str, language: str = LAN
424424
{"role": MESSAGE_ROLE["USER"], "content": user_prompt}
425425
]
426426

427-
# Call LLM
427+
# Call LLM, allow more tokens for generation
428428
response = llm(messages, max_tokens=max_words * 2)
429-
# Allow more tokens for generation
430429
if not response or not response.content:
431430
return ""
432431
return response.content.strip()

β€Žfrontend/services/knowledgeBaseService.tsβ€Ž

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -469,17 +469,20 @@ class KnowledgeBaseService {
469469
onProgress(data.message);
470470
}
471471
} else if (data.status === "completed") {
472-
// Check if message field exists when status is completed
473-
if (!data.message || data.message.trim() === "") {
472+
// On completed, check if the accumulated summary is empty
473+
if (!summary || summary.trim() === "") {
474474
// No summary was generated, throw internationalized error
475475
const errorMessage = i18n.t(
476476
"knowledgeBase.summary.notGenerated"
477477
);
478478
throw new Error(errorMessage);
479479
}
480-
summary += data.message;
481-
if (onProgress) {
482-
onProgress(data.message);
480+
// If there is a final message, append it
481+
if (data.message && data.message.trim() !== "") {
482+
summary += data.message;
483+
if (onProgress) {
484+
onProgress(data.message);
485+
}
483486
}
484487
} else if (data.status === "error") {
485488
throw new Error(data.message);

0 commit comments

Comments
Β (0)