🐛 English error message shows up under chinese language when model is not connected #1502

Author: Phinease

frontend/app/[locale]/setup/models/components/model/ModelAddDialog.tsx

@@ -32,6 +32,26 @@ export const ModelAddDialog = ({ isOpen, onClose, onSuccess }: ModelAddDialogPro
   const { t } = useTranslation()
   const { message } = App.useApp()
   const { updateModelConfig } = useConfig()
+
+  // Parse backend error message and return i18n key with params
+  const parseModelError = (errorMessage: string): { key: string; params?: Record<string, string> } => {
+    if (!errorMessage) {
+      return { key: 'model.dialog.error.addFailed' }
+    }
+
+    // Check for name conflict error
+    const nameConflictMatch = errorMessage.match(/Name ['"]?([^'"]+)['"]? is already in use/i)
+    if (nameConflictMatch) {
+      return {
+        key: 'model.dialog.error.nameConflict',
+        params: { name: nameConflictMatch[1] }
+      }
+    }
+
+    // For other errors, return generic error key without showing backend details
+    return { key: 'model.dialog.error.addFailed' }
+  }
+
   const [form, setForm] = useState({
     type: MODEL_TYPES.LLM as ModelType,
     name: "",
@@ -211,7 +231,8 @@ export const ModelAddDialog = ({ isOpen, onClose, onSuccess }: ModelAddDialogPro
         onSuccess()
       }
     } catch (error: any) {
-      message.error(error?.message || '添加模型失败');
+      const errorInfo = parseModelError(error?.message || '')
+      message.error(t(errorInfo.key, errorInfo.params))
     }
 
     setForm(prev => ({
@@ -354,7 +375,9 @@ export const ModelAddDialog = ({ isOpen, onClose, onSuccess }: ModelAddDialogPro
       // Close the dialog
       onClose()
     } catch (error) {
-      message.error(t('model.dialog.error.addFailed', { error }))
+      const errorMessage = error instanceof Error ? error.message : String(error)
+      const errorInfo = parseModelError(errorMessage)
+      message.error(t(errorInfo.key, errorInfo.params))
       log.error(t('model.dialog.error.addFailedLog'), error)
     } finally {
       setLoading(false)

frontend/public/locales/en/common.json

@@ -560,7 +560,7 @@
   "model.dialog.status.verifying": "Verifying model connectivity...",
   "model.dialog.success.connectivityVerified": "Model connectivity verification successful!",
   "model.dialog.error.connectivityRequired": "Please verify model connectivity and ensure connection is successful before adding the model",
-  "model.dialog.error.addFailed": "Failed to add model: {{error}}",
+  "model.dialog.error.addFailed": "Failed to add model",
   "model.dialog.error.addFailedLog": "Failed to add model",
   "model.dialog.error.noModelsFetched": "Please check your API key and network connectivity",
   "model.dialog.message.noModels": "Please fetch models first",

frontend/public/locales/zh/common.json

@@ -560,7 +560,7 @@
   "model.dialog.warning.incompleteForm": "请先填写完整的模型配置信息",
   "model.dialog.status.verifying": "正在验证模型连通性...",
   "model.dialog.error.connectivityRequired": "请先验证模型连通性且确保连接成功后再添加模型",
-  "model.dialog.error.addFailed": "添加模型失败：{{error}}",
+  "model.dialog.error.addFailed": "添加模型失败",
   "model.dialog.error.addFailedLog": "添加模型失败",
   "model.dialog.error.noModelsFetched": "请检查相关API Key以及网络连通性",
   "model.dialog.message.noModels": "请先获取模型",