🐛 Fix typo error

🧪 Fix test_auth_utils.py failed only in GitHub workflow

Author: Jasonxia007

backend/apps/northbound_app.py

@@ -4,7 +4,7 @@
 
 from fastapi import APIRouter, Body, Header, Request
 
-from consts.model import UnauthorizedError
+from consts.exceptions import UnauthorizedError
 from services.northbound_service import (
     NorthboundContext,
     get_conversation_history,

backend/apps/northbound_base_app.py

@@ -4,14 +4,14 @@
 from fastapi.middleware.cors import CORSMiddleware
 
 from .northbound_app import router as northbound_router
-from consts.model import LimitExceededError, UnauthorizedError, SignatureValidationError
+from consts.exceptions import LimitExceededError, UnauthorizedError, SignatureValidationError
 
 logger = logging.getLogger("northbound_base_app")
 
 
 northbound_app = FastAPI(
     title="Nexent Northbound API",
-    description="北向接口 - 面向合作伙伴的外部API",
+    description="Northbound APIs for partners",
     version="1.0.0",
     root_path="/api"
 )

backend/apps/user_management_app.py

@@ -9,7 +9,7 @@
 from consts.const import SUPABASE_URL, SUPABASE_KEY
 from consts.model import STATUS_CODES, ServiceResponse, UserSignUpRequest, UserSignInRequest
 from database.model_management_db import create_model_record
-from utils.auth_utils import get_jwt_expiry_seconds, calculate_expires_at
+from utils.auth_utils import get_jwt_expiry_seconds, calculate_expires_at, get_current_user_id
 from database.user_tenant_db import insert_user_tenant
 from utils.config_utils import config_manager
 
@@ -550,7 +550,6 @@ async def get_user_id(request: Request):
 
     # If the token is invalid, try to parse the user ID from the token
     try:
-        from utils.auth_utils import get_current_user_id
         user_id, _ = get_current_user_id(authorization)
         if user_id:
             logging.info(f"Successfully parsed user ID from token: {user_id}")

backend/consts/exceptions.py

@@ -0,0 +1,10 @@
+# Northbound customize error class
+class LimitExceededError(Exception):
+    pass
+
+class UnauthorizedError(Exception):
+    pass
+
+class SignatureValidationError(Exception):
+    """Raised when X-Signature header is missing or does not match the expected HMAC value."""
+    pass

backend/consts/model.py

@@ -379,15 +379,3 @@ class MemoryAgentShareMode(str, Enum):
     @classmethod
     def default(cls) -> "MemoryAgentShareMode":
         return cls.NEVER
-
-# Northbound customize error class
-class LimitExceededError(Exception):
-    pass
-
-class UnauthorizedError(Exception):
-    pass
-
-# Custom error raised when HMAC signature validation fails in northbound requests
-class SignatureValidationError(Exception):
-    """Raised when X-Signature header is missing or does not match the expected HMAC value."""
-    pass

backend/services/northbound_service.py

@@ -9,8 +9,8 @@
 from fastapi.responses import StreamingResponse
 
 from database.conversation_db import get_conversation_messages
-from consts.model import (
-    AgentRequest,
+from consts.model import AgentRequest
+from consts.exceptions import (
     LimitExceededError,
     UnauthorizedError,
 )
@@ -122,7 +122,7 @@ async def to_external_conversation_id(internal_id: int) -> str:
         raise Exception("invalid internal conversation id")
     external_id = get_external_id_by_internal(internal_id=internal_id, mapping_type="CONVERSATION")
     if not external_id:
-        raise Exception(f"cannot find external id for conversation_id: {internal_id}")
+        logger.warning(f"cannot find external id for conversation_id: {internal_id}")
     return external_id
 
 
@@ -197,7 +197,7 @@ async def start_streaming_chat(
         )
     finally:
         if composed_key:
-            asyncio.create_task(_release_idempotency_after_delay(composed_key, 3))
+            asyncio.create_task(_release_idempotency_after_delay(composed_key))
 
     # Attach request id header
     response.headers["X-Request-Id"] = ctx.request_id
@@ -219,10 +219,7 @@ async def list_conversations(ctx: NorthboundContext) -> Dict[str, Any]:
     conversations = get_conversation_list_service(ctx.user_id)
     # get_conversation_list_service is sync
     for item in conversations:
-        try:
-            item["conversation_id"] = await to_external_conversation_id(int(item["conversation_id"]))
-        except Exception:
-            pass
+        item["conversation_id"] = await to_external_conversation_id(int(item["conversation_id"]))
     return {"message": "success", "data": conversations, "requestId": ctx.request_id}
 
 
@@ -280,4 +277,4 @@ async def update_conversation_title(ctx: NorthboundContext, external_conversatio
         raise Exception(f"Failed to update conversation title for external conversation id {external_conversation_id}: {str(e)}")
     finally:
         if composed_key:
-            asyncio.create_task(_release_idempotency_after_delay(composed_key, 3))
+            asyncio.create_task(_release_idempotency_after_delay(composed_key))

backend/utils/auth_utils.py

@@ -8,7 +8,7 @@
 
 from fastapi import Request, HTTPException
 from consts.const import DEFAULT_USER_ID, DEFAULT_TENANT_ID, IS_SPEED_MODE
-from consts.model import SignatureValidationError, UnauthorizedError
+from consts.exceptions import SignatureValidationError, UnauthorizedError
 import jwt
 from supabase import create_client
 from database.user_tenant_db import get_user_tenant_by_user_id

test/backend/app/test_northbound_app.py

@@ -16,6 +16,42 @@
 # Pre-mock heavy dependencies before importing router
 sys.modules['consts'] = MagicMock()
 sys.modules['consts.model'] = MagicMock()
+# Provide stub for consts.exceptions with expected exception classes
+# so that imports in application code succeed during tests.
+# We intentionally use real classes (not MagicMock) so that isinstance checks work if present.
+
+import types
+
+consts_exceptions_mod = types.ModuleType("consts.exceptions")
+
+
+class LimitExceededError(Exception):
+    pass
+
+
+class UnauthorizedError(Exception):
+    pass
+
+
+class SignatureValidationError(Exception):
+    pass
+
+
+consts_exceptions_mod.LimitExceededError = LimitExceededError
+consts_exceptions_mod.UnauthorizedError = UnauthorizedError
+consts_exceptions_mod.SignatureValidationError = SignatureValidationError
+
+# Ensure the parent 'consts' is a module (could be MagicMock) and register submodule.
+import sys as _sys
+if 'consts' not in _sys.modules or not isinstance(_sys.modules['consts'], types.ModuleType):
+    consts_root = types.ModuleType("consts")
+    consts_root.__path__ = []
+    _sys.modules['consts'] = consts_root
+else:
+    consts_root = _sys.modules['consts']
+
+consts_root.exceptions = consts_exceptions_mod
+_sys.modules['consts.exceptions'] = consts_exceptions_mod
 sys.modules['services'] = MagicMock()
 sys.modules['services.northbound_service'] = MagicMock()
 sys.modules['utils'] = MagicMock()

test/backend/app/test_northbound_base_app.py

@@ -67,6 +67,16 @@ class SignatureValidationError(Exception):
 consts_module.model = consts_model_module
 sys.modules['consts'] = consts_module
 sys.modules['consts.model'] = consts_model_module
+# ---------------------------------------------------------------------------
+# Provide 'consts.exceptions' stub so that northbound_base_app import succeeds
+# ---------------------------------------------------------------------------
+consts_exceptions_module = types.ModuleType("consts.exceptions")
+consts_exceptions_module.LimitExceededError = LimitExceededError
+consts_exceptions_module.UnauthorizedError = UnauthorizedError
+consts_exceptions_module.SignatureValidationError = SignatureValidationError
+
+# Register the stub so that `from consts.exceptions import ...` works seamlessly
+sys.modules['consts.exceptions'] = consts_exceptions_module
 
 # ---------------------------------------------------------------------------
 # SAFE TO IMPORT THE TARGET MODULE UNDER TEST NOW

test/backend/services/test_northbound_service.py

@@ -12,15 +12,28 @@
 
 # consts.model stubs used by northbound_service
 consts_mod = types.ModuleType("consts")
+consts_mod.__path__ = []  # Mark as namespace package so that submodule imports work
 consts_model_mod = types.ModuleType("consts.model")
+consts_exceptions_mod = types.ModuleType("consts.exceptions")
 
 
+# Define the custom exception classes expected by northbound_service
 class LimitExceededError(Exception):
-    pass
+    """Raised when the rate limit or similar guard is violated."""
 
 
 class UnauthorizedError(Exception):
-    pass
+    """Raised when authentication or authorization fails."""
+
+
+class SignatureValidationError(Exception):
+    """Raised when request signature header is missing or invalid."""
+
+
+# Attach them to the stub module so that `from consts.exceptions import ...` works
+consts_exceptions_mod.LimitExceededError = LimitExceededError
+consts_exceptions_mod.UnauthorizedError = UnauthorizedError
+consts_exceptions_mod.SignatureValidationError = SignatureValidationError
 
 
 class AgentRequest:
@@ -34,10 +47,10 @@ def __init__(self, conversation_id: int, agent_id: int, query: str, history: Any
 
 
 consts_model_mod.AgentRequest = AgentRequest
-consts_model_mod.LimitExceededError = LimitExceededError
-consts_model_mod.UnauthorizedError = UnauthorizedError
 sys.modules['consts'] = consts_mod
+# Register stubs
 sys.modules['consts.model'] = consts_model_mod
+sys.modules['consts.exceptions'] = consts_exceptions_mod
 
 # database.* stubs
 database_mod = types.ModuleType('database')
@@ -145,8 +158,8 @@ async def test_to_external_and_internal_conversation_id_success():
 @pytest.mark.asyncio
 async def test_to_external_conversation_id_not_found():
     partner_db_mod.get_external_id_by_internal.return_value = None
-    with pytest.raises(Exception):
-        await ns.to_external_conversation_id(123)
+    result = await ns.to_external_conversation_id(123)
+    assert result is None
 
 
 @pytest.mark.asyncio
@@ -230,14 +243,14 @@ async def _agen():
 async def test_rate_limit_exceeded(monkeypatch):
     monkeypatch.setattr(ns, "_RATE_LIMIT_PER_MINUTE", 1)
     await ns.check_and_consume_rate_limit("tenant-x")
-    with pytest.raises(LimitExceededError):
+    with pytest.raises(consts_exceptions_mod.LimitExceededError):
         await ns.check_and_consume_rate_limit("tenant-x")
 
 
 @pytest.mark.asyncio
 async def test_idempotency_prevents_duplicates():
     await ns.idempotency_start("dup-key")
-    with pytest.raises(LimitExceededError):
+    with pytest.raises(consts_exceptions_mod.LimitExceededError):
         await ns.idempotency_start("dup-key")
     await ns.idempotency_end("dup-key")
 
@@ -298,7 +311,7 @@ async def test_update_conversation_title_success_and_idempotency(ctx):
     assert res["message"] == "success"
     assert res["data"] == "ext-10"
     # duplicate should raise until released
-    with pytest.raises(LimitExceededError):
+    with pytest.raises(consts_exceptions_mod.LimitExceededError):
         await ns.update_conversation_title(ctx, "ext-10", "Title", idempotency_key="title-key")
     # cleanup manually to avoid bleed between tests
     await ns.idempotency_end("title-key")