Skip to content

Commit 7f63d0f

Browse files
authored
πŸ› Fixing the inability to download datamate data source files
2 parents 6fe37cc + 945bab2 commit 7f63d0f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

β€Žsdk/nexent/core/tools/datamate_search_tool.pyβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ def forward(
150150
entity_data = single_search_result.get("entity", {})
151151
metadata = self._parse_metadata(entity_data.get("metadata"))
152152
dataset_id = self._extract_dataset_id(metadata.get("absolute_directory_path", ""))
153-
file_id = entity_data.get("id")
153+
file_id = metadata.get("original_file_id")
154154
download_url = self._build_file_download_url(dataset_id, file_id)
155155

156156
score_details = entity_data.get("scoreDetails", {}) or {}
@@ -162,7 +162,7 @@ def forward(
162162
})
163163

164164
search_result_message = SearchResultTextMessage(
165-
title=metadata.get("file_name", "") or "Untitled",
165+
title=metadata.get("file_name", ""),
166166
text=entity_data.get("text", ""),
167167
source_type="datamate",
168168
url=download_url,
@@ -308,6 +308,6 @@ def _extract_dataset_id(absolute_path: str) -> str:
308308

309309
def _build_file_download_url(self, dataset_id: str, file_id: str) -> str:
310310
"""Build the download URL for a dataset file."""
311-
if not (self.server_ip and dataset_id and file_id):
311+
if not (self.server_base_url and dataset_id and file_id):
312312
return ""
313-
return f"{self.server_ip}/api/data-management/datasets/{dataset_id}/files/{file_id}/download"
313+
return f"{self.server_base_url}/api/data-management/datasets/{dataset_id}/files/{file_id}/download"

β€Žtest/sdk/core/tools/test_datamate_search_tool.pyβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def test_extract_dataset_id(self, datamate_tool: DataMateSearchTool, path, expec
117117
@pytest.mark.parametrize(
118118
"dataset_id, file_id, expected",
119119
[
120-
("ds1", "f1", "127.0.0.1/api/data-management/datasets/ds1/files/f1/download"),
120+
("ds1", "f1", "http://127.0.0.1:8080/api/data-management/datasets/ds1/files/f1/download"),
121121
("", "f1", ""),
122122
("ds1", "", ""),
123123
],

0 commit comments

Comments
Β (0)