🐛 Record the settings of tools

Phinease · web-flow · commit a28385d5902b · 2025-09-28T13:53:50.000+08:00
diff --git a/backend/apps/tool_config_app.py b/backend/apps/tool_config_app.py
@@ -10,7 +10,9 @@
 from services.tool_configuration_service import (
     search_tool_info_impl,
     update_tool_info_impl,
-    update_tool_list, list_all_tools,
+    update_tool_list,
+    list_all_tools,
+    load_last_tool_config_impl,
 )
 from utils.auth_utils import get_current_user_id
 
@@ -78,3 +80,21 @@ async def scan_and_update_tool(
         logger.error(f"Failed to update tool: {e}")
         raise HTTPException(
             status_code=HTTPStatus.INTERNAL_SERVER_ERROR, detail="Failed to update tool")
+
+@router.get("/load_config/{tool_id}")
+async def load_last_tool_config(tool_id: int, authorization: Optional[str] = Header(None)):
+    try:
+        user_id, tenant_id = get_current_user_id(authorization)
+        tool_params = load_last_tool_config_impl(tool_id, tenant_id, user_id)
+        return JSONResponse(
+            status_code=HTTPStatus.OK,
+            content={"message": tool_params, "status": "success"}
+        )
+    except ValueError:
+        logger.error(f"Tool configuration not found for tool ID: {tool_id}")
+        raise HTTPException(
+            status_code=HTTPStatus.NOT_FOUND, detail="Tool configuration not found")
+    except Exception as e:
+        logger.error(f"Failed to load tool config: {e}")
+        raise HTTPException(
+            status_code=HTTPStatus.INTERNAL_SERVER_ERROR, detail="Failed to load tool config")
diff --git a/backend/database/tool_db.py b/backend/database/tool_db.py
@@ -213,3 +213,14 @@ def delete_tools_by_agent_id(agent_id, tenant_id, user_id):
         ).update({
             ToolInstance.delete_flag: 'Y', 'updated_by': user_id
         })
+
+def search_last_tool_instance_by_tool_id(tool_id: int, tenant_id: str, user_id: str):
+    with get_db_session() as session:
+        query = session.query(ToolInstance).filter(
+            ToolInstance.tool_id == tool_id,
+            ToolInstance.tenant_id == tenant_id,
+            ToolInstance.user_id == user_id,
+            ToolInstance.delete_flag != 'Y'
+        ).order_by(ToolInstance.update_time.desc()) 
+        tool_instance = query.first()
+        return as_dict(tool_instance) if tool_instance else None
diff --git a/backend/services/tool_configuration_service.py b/backend/services/tool_configuration_service.py
@@ -19,7 +19,8 @@
     create_or_update_tool_by_tool_info,
     query_all_tools,
     query_tool_instances_by_id,
-    update_tool_table_from_scan_tool_list
+    update_tool_table_from_scan_tool_list,
+    search_last_tool_instance_by_tool_id
 )
 from database.user_tenant_db import get_all_tenant_ids
 
@@ -413,4 +414,13 @@ async def initialize_tools_on_startup():
         
     except Exception as e:
         logger.error(f"❌ Tool initialization failed: {str(e)}")
-        raise
+        raise
+
+def load_last_tool_config_impl(tool_id: int, tenant_id: str, user_id: str):
+    """
+    Load the last tool configuration for a given tool ID
+    """
+    tool_instance = search_last_tool_instance_by_tool_id(tool_id, tenant_id, user_id)
+    if tool_instance is None:
+        raise ValueError(f"Tool configuration not found for tool ID: {tool_id}")
+    return tool_instance.get("params", {})
diff --git a/frontend/app/[locale]/setup/agents/components/tool/ToolConfigModal.tsx b/frontend/app/[locale]/setup/agents/components/tool/ToolConfigModal.tsx
@@ -9,6 +9,7 @@ import { ToolParam, ToolConfigModalProps } from "@/types/agentConfig";
 import {
   updateToolConfig,
   searchToolConfig,
+  loadLastToolConfig,
 } from "@/services/agentConfigService";
 import log from "@/lib/logger";
 
@@ -122,6 +123,36 @@ export default function ToolConfigModal({
     setCurrentParams(newParams);
   };
 
+  // load last tool config
+  const handleLoadLastConfig = async () => {
+    if (!tool) return;
+
+    try {
+      const result = await loadLastToolConfig(parseInt(tool.id));
+      if (result.success && result.data) {
+        // Parse the last config data
+        const lastConfig = result.data;
+        
+        // Update current params with last config values
+        const updatedParams = currentParams.map((param) => {
+          const lastValue = lastConfig[param.name];
+          return {
+            ...param,
+            value: lastValue !== undefined ? lastValue : param.value,
+          };
+        });
+        
+        setCurrentParams(updatedParams);
+        message.success(t("toolConfig.message.loadLastConfigSuccess"));
+      } else {
+        message.warning(t("toolConfig.message.loadLastConfigNotFound"));
+      }
+    } catch (error) {
+      log.error(t("toolConfig.message.loadLastConfigFailed"), error);
+      message.error(t("toolConfig.message.loadLastConfigFailed"));
+    }
+  };
+
   const handleSave = async () => {
     if (!tool || !checkRequiredFields()) return;
 
@@ -257,26 +288,36 @@ export default function ToolConfigModal({
       title={
         <div className="flex justify-between items-center w-full pr-8">
           <span>{`${tool?.name}`}</span>
-          <Tag
-            color={
-              tool?.source === "mcp"
-                ? "blue"
+          <div className="flex items-center gap-2">
+            <button
+              onClick={handleLoadLastConfig}
+              className="px-2 py-1 text-xs bg-blue-500 text-white rounded hover:bg-blue-600 disabled:opacity-50 disabled:cursor-not-allowed transition-colors duration-200"
+            >
+              {t("toolConfig.message.loadLastConfig")}
+            </button>
+            <Tag
+              color={
+                tool?.source === "mcp"
+                  ? "blue"
+                  : tool?.source === "langchain"
+                  ? "orange"
+                  : "green"
+              }
+            >
+              {tool?.source === "mcp"
+                ? t("toolPool.tag.mcp")
                 : tool?.source === "langchain"
-                ? "orange"
-                : "green"
-            }
-          >
-            {tool?.source === "mcp"
-              ? t("toolPool.tag.mcp")
-              : tool?.source === "langchain"
-              ? t("toolPool.tag.langchain")
-              : t("toolPool.tag.local")}
-          </Tag>
+                ? t("toolPool.tag.langchain")
+                : t("toolPool.tag.local")}
+            </Tag>
+          </div>
         </div>
       }
       open={isOpen}
       onCancel={onCancel}
       onOk={handleSave}
+      okText={t("common.button.save")}
+      cancelText={t("common.button.cancel")}
       width={600}
       confirmLoading={isLoading}
     >
diff --git a/frontend/public/locales/en/common.json b/frontend/public/locales/en/common.json
@@ -351,6 +351,10 @@
   "toolConfig.message.saveError": "Save failed",
   "toolConfig.message.saveFailed": "Save failed, please try again later",
   "toolConfig.message.requiredFields": "The following required fields are not filled: ",
+  "toolConfig.message.loadLastConfig": "Load Last Configuration",
+  "toolConfig.message.loadLastConfigSuccess": "Last configuration loaded successfully",
+  "toolConfig.message.loadLastConfigFailed": "Failed to load last configuration",
+  "toolConfig.message.loadLastConfigNotFound": "No last configuration found",
   "toolConfig.input.model.placeholder": "Please select model",
   "toolConfig.input.string.placeholder": "Please enter {{name}}",
   "toolConfig.input.array.placeholder": "Please enter JSON array",
diff --git a/frontend/public/locales/zh/common.json b/frontend/public/locales/zh/common.json
@@ -352,6 +352,10 @@
   "toolConfig.message.saveError": "保存失败",
   "toolConfig.message.saveFailed": "保存失败，请稍后重试",
   "toolConfig.message.requiredFields": "以下必填字段未填写: ",
+  "toolConfig.message.loadLastConfig": "加载上一次配置",
+  "toolConfig.message.loadLastConfigSuccess": "上一次配置加载成功",
+  "toolConfig.message.loadLastConfigFailed": "加载上一次配置失败",
+  "toolConfig.message.loadLastConfigNotFound": "未找到上一次配置",
   "toolConfig.input.model.placeholder": "请选择模型",
   "toolConfig.input.string.placeholder": "请输入{{name}}",
   "toolConfig.input.array.placeholder": "请输入JSON数组",
diff --git a/frontend/services/agentConfigService.ts b/frontend/services/agentConfigService.ts
@@ -223,6 +223,38 @@ export const searchToolConfig = async (toolId: number, agentId: number) => {
   }
 };
 
+/**
+ * load last tool config
+ * @param toolId tool id
+ * @returns last tool config info
+ */
+export const loadLastToolConfig = async (toolId: number) => {
+  try {
+    const response = await fetch(API_ENDPOINTS.tool.loadConfig(toolId), {
+      method: "GET",
+      headers: getAuthHeaders(),
+    });
+
+    if (!response.ok) {
+      throw new Error(`Request failed: ${response.status}`);
+    }
+
+    const data = await response.json();
+    return {
+      success: true,
+      data: data.message, // Backend returns config in message field
+      message: "",
+    };
+  } catch (error) {
+    log.error("Failed to load last tool configuration:", error);
+    return {
+      success: false,
+      data: null,
+      message: "Failed to load last tool configuration, please try again later",
+    };
+  }
+};
+
 /**
  * Update Agent information
  * @param agentId agent id
diff --git a/frontend/services/api.ts b/frontend/services/api.ts
@@ -47,6 +47,7 @@ export const API_ENDPOINTS = {
     update: `${API_BASE_URL}/tool/update`,
     search: `${API_BASE_URL}/tool/search`,
     updateTool: `${API_BASE_URL}/tool/scan_tool`,
+    loadConfig: (toolId: number) => `${API_BASE_URL}/tool/load_config/${toolId}`,
   },
   prompt: {
     generate: `${API_BASE_URL}/prompt/generate`,
diff --git a/test/backend/app/test_tool_config_app.py b/test/backend/app/test_tool_config_app.py
@@ -401,6 +401,85 @@ def test_scan_tool_auth_failure(self, mock_get_user_id):
         assert "Failed to update tool" in data["detail"]
 
 
+class TestLoadLastToolConfigAPI:
+    """Test endpoint for loading last tool configuration"""
+
+    @patch('apps.tool_config_app.get_current_user_id')
+    @patch('apps.tool_config_app.load_last_tool_config_impl')
+    def test_load_last_tool_config_success(self, mock_load_config, mock_get_user_id):
+        """Test successful loading of last tool configuration"""
+        mock_get_user_id.return_value = ("user123", "tenant456")
+        mock_load_config.return_value = {"param1": "value1", "param2": "value2"}
+
+        response = client.get("/tool/load_config/123")
+
+        assert response.status_code == HTTPStatus.OK
+        data = response.json()
+        assert data["status"] == "success"
+        assert data["message"] == {"param1": "value1", "param2": "value2"}
+
+        mock_get_user_id.assert_called_once_with(None)
+        mock_load_config.assert_called_once_with(123, "tenant456", "user123")
+
+    @patch('apps.tool_config_app.get_current_user_id')
+    @patch('apps.tool_config_app.load_last_tool_config_impl')
+    def test_load_last_tool_config_not_found(self, mock_load_config, mock_get_user_id):
+        """Test loading tool config when not found"""
+        mock_get_user_id.return_value = ("user123", "tenant456")
+        mock_load_config.side_effect = ValueError("Tool configuration not found for tool ID: 123")
+
+        response = client.get("/tool/load_config/123")
+
+        assert response.status_code == HTTPStatus.NOT_FOUND
+        data = response.json()
+        assert "Tool configuration not found" in data["detail"]
+
+        mock_get_user_id.assert_called_once_with(None)
+        mock_load_config.assert_called_once_with(123, "tenant456", "user123")
+
+    @patch('apps.tool_config_app.get_current_user_id')
+    @patch('apps.tool_config_app.load_last_tool_config_impl')
+    def test_load_last_tool_config_service_error(self, mock_load_config, mock_get_user_id):
+        """Test service error when loading tool config"""
+        mock_get_user_id.return_value = ("user123", "tenant456")
+        mock_load_config.side_effect = Exception("Database error")
+
+        response = client.get("/tool/load_config/123")
+
+        assert response.status_code == HTTPStatus.INTERNAL_SERVER_ERROR
+        data = response.json()
+        assert "Failed to load tool config" in data["detail"]
+
+        mock_get_user_id.assert_called_once_with(None)
+        mock_load_config.assert_called_once_with(123, "tenant456", "user123")
+
+    @patch('apps.tool_config_app.get_current_user_id')
+    def test_load_last_tool_config_auth_error(self, mock_get_user_id):
+        """Test authentication error when loading tool config"""
+        mock_get_user_id.side_effect = Exception("Auth error")
+
+        response = client.get("/tool/load_config/123")
+
+        assert response.status_code == HTTPStatus.INTERNAL_SERVER_ERROR
+        data = response.json()
+        assert "Failed to load tool config" in data["detail"]
+
+    @patch('apps.tool_config_app.get_current_user_id')
+    @patch('apps.tool_config_app.load_last_tool_config_impl')
+    def test_load_last_tool_config_with_authorization_header(self, mock_load_config, mock_get_user_id):
+        """Test loading tool config with authorization header"""
+        mock_get_user_id.return_value = ("user123", "tenant456")
+        mock_load_config.return_value = {"param1": "value1"}
+
+        response = client.get(
+            "/tool/load_config/123",
+            headers={"Authorization": "Bearer test_token"}
+        )
+
+        assert response.status_code == HTTPStatus.OK
+        mock_get_user_id.assert_called_with("Bearer test_token")
+
+
 class TestDataValidation:
     """Data validation tests"""
 
diff --git a/test/backend/database/test_tool_db.py b/test/backend/database/test_tool_db.py
diff --git a/test/backend/services/test_tool_configuration_service.py b/test/backend/services/test_tool_configuration_service.py
