Merge pull request #1171 from ModelEngine-Group/bwq/0904_re

♻️ Refactor: Partial constant extraction in the backend

Author: Bavichi

backend/agents/create_agent_info.py

@@ -17,17 +17,17 @@
 from database.tool_db import search_tools_for_sub_agent
 from utils.prompt_template_utils import get_agent_prompt_template
 from utils.config_utils import tenant_config_manager, get_model_name_from_config
-from consts.const import LOCAL_MCP_SERVER
+from consts.const import LOCAL_MCP_SERVER, MODEL_CONFIG_MAPPING, LANGUAGE
 
 logger = logging.getLogger("create_agent_info")
 logger.setLevel(logging.DEBUG)
 
 
 async def create_model_config_list(tenant_id):
     main_model_config = tenant_config_manager.get_model_config(
-        key="LLM_ID", tenant_id=tenant_id)
+        key=MODEL_CONFIG_MAPPING["llm"], tenant_id=tenant_id)
     sub_model_config = tenant_config_manager.get_model_config(
-        key="LLM_SECONDARY_ID", tenant_id=tenant_id)
+        key=MODEL_CONFIG_MAPPING["llmSecondary"], tenant_id=tenant_id)
 
     return [ModelConfig(cite_name="main_model",
                         api_key=main_model_config.get("api_key", ""),
@@ -45,7 +45,7 @@ async def create_agent_config(
     agent_id,
     tenant_id,
     user_id,
-    language: str = "zh",
+    language: str = LANGUAGE["ZH"],
     last_user_query: str = None,
     allow_memory_search: bool = True,
 ):

backend/apps/memory_config_app.py

@@ -37,6 +37,7 @@
 from consts.const import (
     MEMORY_AGENT_SHARE_KEY,
     MEMORY_SWITCH_KEY,
+    BOOLEAN_TRUE_VALUES,
 )
 from consts.model import MemoryAgentShareMode
 from consts.exceptions import UnauthorizedError
@@ -100,7 +101,7 @@ def set_single_config(
 
     if key == MEMORY_SWITCH_KEY:
         enabled = bool(value) if isinstance(value, bool) else str(
-            value).lower() in {"true", "1", "y", "yes", "on"}
+            value).lower() in BOOLEAN_TRUE_VALUES
         ok = set_memory_switch(user_id, enabled)
     elif key == MEMORY_AGENT_SHARE_KEY:
         try:

backend/apps/mock_user_management_app.py

@@ -5,26 +5,12 @@
 from fastapi.responses import JSONResponse
 from http import HTTPStatus
 
-from consts.const import DEFAULT_USER_ID
+from consts.const import MOCK_USER, MOCK_SESSION
 from consts.model import UserSignInRequest, UserSignUpRequest
 
 logger = logging.getLogger("mock_user_management_app")
 router = APIRouter(prefix="/user", tags=["user"])
 
-# Mock user data
-MOCK_USER = {
-    "id": DEFAULT_USER_ID,
-    "email": "[email protected]",
-    "role": "admin"
-}
-
-MOCK_SESSION = {
-    "access_token": "mock_access_token",
-    "refresh_token": "mock_refresh_token",
-    "expires_at": int((datetime.now() + timedelta(days=3650)).timestamp()),
-    "expires_in_seconds": 315360000
-}
-
 
 @router.get("/service_health")
 async def service_health():
@@ -63,7 +49,7 @@ async def signup(request: UserSignUpRequest):
             "session": {
                 "access_token": MOCK_SESSION["access_token"],
                 "refresh_token": MOCK_SESSION["refresh_token"],
-                "expires_at": MOCK_SESSION["expires_at"],
+                "expires_at": int((datetime.now() + timedelta(days=3650)).timestamp()),
                 "expires_in_seconds": MOCK_SESSION["expires_in_seconds"]
             },
             "registration_type": "admin" if request.is_admin else "user"
@@ -97,7 +83,7 @@ async def signin(request: UserSignInRequest):
                 "session": {
                     "access_token": MOCK_SESSION["access_token"],
                     "refresh_token": MOCK_SESSION["refresh_token"],
-                    "expires_at": MOCK_SESSION["expires_at"],
+                    "expires_at": int((datetime.now() + timedelta(days=3650)).timestamp()),
                     "expires_in_seconds": MOCK_SESSION["expires_in_seconds"]
                 }
             }

backend/consts/const.py

@@ -146,6 +146,8 @@
 DISABLE_USERAGENT_ID_KEY = "DISABLE_USERAGENT_ID"
 DEFAULT_MEMORY_SWITCH_KEY = "Y"
 DEFAULT_MEMORY_AGENT_SHARE_KEY = "always"
+# Boolean value representations for configuration parsing
+BOOLEAN_TRUE_VALUES = {"true", "1", "y", "yes", "on"}
 
 
 DEFAULT_LLM_MAX_TOKENS = 4096
@@ -161,6 +163,55 @@
 # Debug JWT expiration time (seconds), not set or 0 means not effective
 DEBUG_JWT_EXPIRE_SECONDS = int(os.getenv('DEBUG_JWT_EXPIRE_SECONDS', '0') or 0)
 
+# Memory Search Status Messages (for i18n placeholders)
+MEMORY_SEARCH_START_MSG = "<MEM_START>"
+MEMORY_SEARCH_DONE_MSG = "<MEM_DONE>"
+MEMORY_SEARCH_FAIL_MSG = "<MEM_FAILED>"
+
+# Tool Type Mapping (for display normalization)
+TOOL_TYPE_MAPPING = {
+    "mcp": "MCP",
+    "langchain": "LangChain",
+    "local": "Local",
+}
+
+# Default Language Configuration
+LANGUAGE = {
+    "ZH": "zh",
+    "EN": "en"
+}
+
+# Message Role Constants
+MESSAGE_ROLE = {
+    "USER": "user",
+    "ASSISTANT": "assistant",
+    "SYSTEM": "system"
+}
+
+# Knowledge summary max token limits
+KNOWLEDGE_SUMMARY_MAX_TOKENS_ZH = 300
+KNOWLEDGE_SUMMARY_MAX_TOKENS_EN = 120
+
+# Host Configuration Constants
+LOCALHOST_IP = "127.0.0.1"
+LOCALHOST_NAME = "localhost"
+DOCKER_INTERNAL_HOST = "host.docker.internal"
+
+
+# Mock User Management Configuration (for speed mode)
+MOCK_USER = {
+    "id": DEFAULT_USER_ID,
+    "email": "[email protected]",
+    "role": "admin"
+}
+
+MOCK_SESSION = {
+    "access_token": "mock_access_token",
+    "refresh_token": "mock_refresh_token",
+    "expires_at": None,  # Will be set dynamically
+    "expires_in_seconds": 315360000  # 10 years
+}
+
 MODEL_CONFIG_MAPPING = {
     "llm": "LLM_ID",
     "llmSecondary": "LLM_SECONDARY_ID",
@@ -177,3 +228,14 @@
 ICON_TYPE = "ICON_TYPE"
 AVATAR_URI = "AVATAR_URI"
 CUSTOM_ICON_URL = "CUSTOM_ICON_URL"
+
+# Task Status Constants
+TASK_STATUS = {
+    "WAIT_FOR_PROCESSING": "WAIT_FOR_PROCESSING",
+    "WAIT_FOR_FORWARDING": "WAIT_FOR_FORWARDING",
+    "PROCESSING": "PROCESSING",
+    "FORWARDING": "FORWARDING",
+    "COMPLETED": "COMPLETED",
+    "PROCESS_FAILED": "PROCESS_FAILED",
+    "FORWARD_FAILED": "FORWARD_FAILED",
+}

backend/services/agent_service.py

@@ -13,6 +13,7 @@
 from agents.agent_run_manager import agent_run_manager
 from agents.create_agent_info import create_agent_run_info, create_tool_config_list
 from agents.preprocess_manager import preprocess_manager
+from consts.const import MEMORY_SEARCH_START_MSG, MEMORY_SEARCH_DONE_MSG, MEMORY_SEARCH_FAIL_MSG, TOOL_TYPE_MAPPING, LANGUAGE, MESSAGE_ROLE
 from consts.exceptions import MemoryPreparationException
 from consts.model import (
     AgentInfoRequest,
@@ -118,7 +119,7 @@ async def _stream_agent_chunks(
         if not agent_request.is_debug:
             save_messages(
                 agent_request,
-                target="assistant",
+                target=MESSAGE_ROLE["ASSISTANT"],
                 messages=local_messages,
                 tenant_id=tenant_id,
                 user_id=user_id,
@@ -149,8 +150,8 @@ async def _add_memory_background():
                     return
 
                 mem_messages_local = [
-                    {"role": "user", "content": agent_run_info.query},
-                    {"role": "assistant", "content": final_answer_local},
+                    {"role": MESSAGE_ROLE["USER"], "content": agent_run_info.query},
+                    {"role": MESSAGE_ROLE["ASSISTANT"], "content": final_answer_local},
                 ]
 
                 add_result_local = await add_memory_in_levels(
@@ -660,7 +661,7 @@ async def prepare_agent_run(
     agent_request: AgentRequest,
     user_id: str,
     tenant_id: str,
-    language: str="zh",
+    language: str=LANGUAGE["ZH"],
     allow_memory_search: bool = True,
 ):
     """
@@ -686,11 +687,11 @@ async def prepare_agent_run(
 
 # Helper function for run_agent_stream, used to save messages for either user or assistant
 def save_messages(agent_request, target: str, user_id: str, tenant_id: str, messages=None):
-    if target == "user":
+    if target == MESSAGE_ROLE["USER"]:
         if messages is not None:
             raise ValueError("Messages should be None when saving for user.")
         submit(save_conversation_user, agent_request, user_id, tenant_id)
-    elif target == "assistant":
+    elif target == MESSAGE_ROLE["ASSISTANT"]:
         if messages is None:
             raise ValueError(
                 "Messages cannot be None when saving for assistant.")
@@ -703,7 +704,7 @@ async def generate_stream_with_memory(
     agent_request: AgentRequest,
     user_id: str,
     tenant_id: str,
-    language: str = "zh",
+    language: str = LANGUAGE["ZH"],
 ):
     # Prepare preprocess task tracking (simulate preprocess flow)
     task_id = str(uuid.uuid4())
@@ -723,9 +724,9 @@ def _memory_token(message_text: str) -> str:
         return json.dumps(payload, ensure_ascii=False)
 
     # Placeholder messages handled by frontend for i18n
-    msg_start = "<MEM_START>"
-    msg_done = "<MEM_DONE>"
-    msg_fail = "<MEM_FAILED>"
+    msg_start = MEMORY_SEARCH_START_MSG
+    msg_done = MEMORY_SEARCH_DONE_MSG
+    msg_fail = MEMORY_SEARCH_FAIL_MSG
 
     # ------------------------------------------------------------------
     # Note: the actual streaming happens via `_stream_agent_chunks` helper
@@ -805,7 +806,7 @@ async def generate_stream_no_memory(
     agent_request: AgentRequest,
     user_id: str,
     tenant_id: str,
-    language: str="zh",
+    language: str=LANGUAGE["ZH"],
 ):
     """Stream agent responses without any memory preprocessing tokens or fallback logic."""
 
@@ -850,7 +851,7 @@ async def run_agent_stream(
 
     # Save user message only if not in debug mode (before streaming starts)
     if not agent_request.is_debug:
-        save_messages(agent_request, target="user",
+        save_messages(agent_request, target=MESSAGE_ROLE["USER"],
                       user_id=resolved_user_id,
                       tenant_id=resolved_tenant_id)
 
@@ -952,21 +953,14 @@ def get_agent_call_relationship_impl(agent_id: int, tenant_id: str) -> dict:
     Returns:
         dict: agent call relationship tree structure
     """
-    # Tool type specification: meets test expectations
-    _TYPE_MAPPING = {
-        "mcp": "MCP",
-        "langchain": "LangChain",
-        "local": "Local",
-    }
-
     def _normalize_tool_type(source: str) -> str:
         """Normalize the source from database to the expected display type for testing."""
         if not source:
             return "UNKNOWN"
         s = str(source)
         ls = s.lower()
-        if ls in _TYPE_MAPPING:
-            return _TYPE_MAPPING[ls]
+        if ls in TOOL_TYPE_MAPPING:
+            return TOOL_TYPE_MAPPING[ls]
         # Unknown source: capitalize first letter, keep the rest unchanged (unknown_source -> Unknown_source)
         return s[:1].upper() + s[1:]
 

backend/services/config_sync_service.py

@@ -11,7 +11,8 @@
     DEFAULT_APP_NAME_EN,
     DEFAULT_APP_NAME_ZH,
     ICON_TYPE,
-    MODEL_CONFIG_MAPPING
+    MODEL_CONFIG_MAPPING,
+    LANGUAGE
 )
 from database.model_management_db import get_model_id_by_display_name
 from utils.config_utils import (
@@ -126,8 +127,8 @@ async def load_config_impl(language: str, tenant_id: str):
 
 
 def build_app_config(language: str, tenant_id: str) -> dict:
-    default_app_name = DEFAULT_APP_NAME_ZH if language == "zh" else DEFAULT_APP_NAME_EN
-    default_app_description = DEFAULT_APP_DESCRIPTION_ZH if language == "zh" else DEFAULT_APP_DESCRIPTION_EN
+    default_app_name = DEFAULT_APP_NAME_ZH if language == LANGUAGE["ZH"] else DEFAULT_APP_NAME_EN
+    default_app_description = DEFAULT_APP_DESCRIPTION_ZH if language == LANGUAGE["ZH"] else DEFAULT_APP_DESCRIPTION_EN
 
     return {
         "name": tenant_config_manager.get_app_config(APP_NAME, tenant_id=tenant_id) or default_app_name,