✨ Model access supports modification access - bugs fix

✨ Model access supports modification access - bugs fix

Author: liutao12138

backend/apps/model_managment_app.py

@@ -90,23 +90,26 @@ async def create_model(request: ModelRequest, authorization: Optional[str] = Hea
 
 @router.post("/create_provider", response_model=ModelResponse)
 async def create_provider_model(request: ProviderModelRequest, authorization: Optional[str] = Header(None)):
-    try:
-        model_data = request.model_dump()
-        model_list=[]
-        if model_data["provider"] == ProviderEnum.SILICON.value:
-            provider = SiliconModelProvider()
-            model_list = await provider.get_models(model_data)
-        return ModelResponse(
-            code=200,
-            message=f"Provider model {model_data['provider']} created successfully",
-            data=model_list
-        )
-    except Exception as e:
-        return ModelResponse(
-            code=500,
-            message=f"Failed to create provider model: {str(e)}",
-            data=None
-        )
+	try:
+		model_data = request.model_dump()
+		model_list=[]
+		if model_data["provider"] == ProviderEnum.SILICON.value:
+			provider = SiliconModelProvider()
+			model_list = await provider.get_models(model_data)
+		# Sort by the first letter of id in descending order
+		if isinstance(model_list, list):
+			model_list.sort(key=lambda m: str((m.get("id") if isinstance(m, dict) else m) or "")[:1].lower(), reverse=False)
+		return ModelResponse(
+			code=200,
+			message=f"Provider model {model_data['provider']} created successfully",
+			data=model_list
+		)
+	except Exception as e:
+		return ModelResponse(
+			code=500,
+			message=f"Failed to create provider model: {str(e)}",
+			data=None
+		)
 
 
 @router.post("/batch_create_models", response_model=ModelResponse)

frontend/app/[locale]/setup/modelSetup/model/ModelDeleteDialog.tsx

@@ -351,7 +351,7 @@ export const ModelDeleteDialog = ({
                     pendingSelectedProviderIds.has(pm.id)
                   )
 
-                  if (allEnabledModels.length > 0) {
+                  if (allEnabledModels) {
                     const apiKey = getApiKeyByType(deletingModelType)
                     // Pass all currently enabled models
                     await modelService.addBatchCustomModel({

test/backend/app/test_model_managment_app.py

@@ -735,6 +735,28 @@ def test_create_provider_model_exception(self, mock_get_silicon):
         self.assertEqual(data["code"], 500)
         self.assertIn("Failed to create provider model: Silicon API error", data["message"])
 
+    def test_create_provider_model_silicon_success_backend_sorted(self):
+        backend_client_local, backend_model_app = _build_backend_client_with_s3_stub()
+        with patch.object(backend_model_app.SiliconModelProvider, "get_models", new=AsyncMock(return_value=[{"id": "b2"}, {"id": "A1"}, {"id": "a0"}, {"id": "c3"}])) as mock_get:
+            request_data = {"provider": "silicon", "api_key": "test_key"}
+            response = backend_client_local.post("/model/create_provider", json=request_data, headers=self.auth_header)
+            self.assertEqual(response.status_code, 200)
+            data = response.json()
+            self.assertEqual(data["code"], 200)
+            self.assertIn("Provider model silicon created successfully", data["message"])
+            self.assertEqual([m["id"] for m in data["data"]], ["A1", "a0", "b2", "c3"])
+            mock_get.assert_called_once()
+
+    def test_create_provider_model_exception_backend(self):
+        backend_client_local, backend_model_app = _build_backend_client_with_s3_stub()
+        with patch.object(backend_model_app.SiliconModelProvider, "get_models", new=AsyncMock(side_effect=Exception("Silicon API error"))) as mock_get:
+            request_data = {"provider": "silicon", "api_key": "test_key"}
+            response = backend_client_local.post("/model/create_provider", json=request_data, headers=self.auth_header)
+            self.assertEqual(response.status_code, 200)
+            data = response.json()
+            self.assertEqual(data["code"], 500)
+            self.assertIn("Failed to create provider model: Silicon API error", data["message"])
+            mock_get.assert_called_once()
 
     @patch("test_model_managment_app.get_current_user_id")
     @patch("test_model_managment_app.get_model_by_display_name")