✨Add unit tests to the model service that enables ModelEngine.

Author: Zhi-a

backend/utils/llm_utils.py

@@ -72,7 +72,7 @@ def call_llm_for_system_prompt(
         temperature=0.3,
         top_p=0.95,
         model_factory=llm_model_config.get("model_factory") if llm_model_config else None,
-        ssl_verify=llm_model_config.get("ssl_verify", True),
+        ssl_verify=llm_model_config.get("ssl_verify", True) if llm_model_config else True,
     )
     messages = [
         {"role": MESSAGE_ROLE["SYSTEM"], "content": system_prompt},

test/backend/app/test_knowledge_summary_app.py

@@ -127,7 +127,7 @@ def test_auto_summary_success(test_data):
     # Setup mock responses
     mock_vdb_core_instance = MagicMock()
     mock_user_info = ("test_user_id", "test_tenant_id", "en")
-    
+
     # Setup service mock
     mock_service_instance = MagicMock()
     mock_service_instance.summary_index_name = AsyncMock()
@@ -138,7 +138,7 @@ def test_auto_summary_success(test_data):
     with patch('backend.apps.knowledge_summary_app.ElasticSearchService', return_value=mock_service_instance), \
             patch('backend.apps.knowledge_summary_app.get_vector_db_core', return_value=mock_vdb_core_instance), \
             patch('backend.apps.knowledge_summary_app.get_current_user_info', return_value=mock_user_info):
-        
+
         # Execute test with model_id parameter
         response = client.post(
             f"/summary/{test_data['index_name']}/auto_summary?batch_size=500&model_id=1",
@@ -149,7 +149,7 @@ def test_auto_summary_success(test_data):
 
         # Assertions - verify the function was called exactly once
         assert mock_service_instance.summary_index_name.call_count == 1
-        
+
         # Extract the call arguments to verify expected values without comparing object identity
         call_kwargs = mock_service_instance.summary_index_name.call_args.kwargs
         assert call_kwargs['index_name'] == test_data['index_name']
@@ -163,7 +163,7 @@ def test_auto_summary_without_model_id(test_data):
     # Setup mock responses
     mock_vdb_core_instance = MagicMock()
     mock_user_info = ("test_user_id", "test_tenant_id", "en")
-    
+
     # Setup service mock
     mock_service_instance = MagicMock()
     mock_service_instance.summary_index_name = AsyncMock()
@@ -174,7 +174,7 @@ def test_auto_summary_without_model_id(test_data):
     with patch('backend.apps.knowledge_summary_app.ElasticSearchService', return_value=mock_service_instance), \
             patch('backend.apps.knowledge_summary_app.get_vector_db_core', return_value=mock_vdb_core_instance), \
             patch('backend.apps.knowledge_summary_app.get_current_user_info', return_value=mock_user_info):
-        
+
         # Execute test without model_id parameter
         response = client.post(
             f"/summary/{test_data['index_name']}/auto_summary?batch_size=500",
@@ -185,7 +185,7 @@ def test_auto_summary_without_model_id(test_data):
 
         # Assertions - verify the function was called exactly once
         assert mock_service_instance.summary_index_name.call_count == 1
-        
+
         # Extract the call arguments to verify expected values without comparing object identity
         call_kwargs = mock_service_instance.summary_index_name.call_args.kwargs
         assert call_kwargs['index_name'] == test_data['index_name']
@@ -199,7 +199,7 @@ def test_auto_summary_exception(test_data):
     # Setup mock to raise exception
     mock_vdb_core_instance = MagicMock()
     mock_user_info = ("test_user_id", "test_tenant_id", "en")
-    
+
     # Setup service mock to raise exception
     mock_service_instance = MagicMock()
     mock_service_instance.summary_index_name = AsyncMock(
@@ -210,7 +210,7 @@ def test_auto_summary_exception(test_data):
     with patch('backend.apps.knowledge_summary_app.ElasticSearchService', return_value=mock_service_instance), \
             patch('backend.apps.knowledge_summary_app.get_vector_db_core', return_value=mock_vdb_core_instance), \
             patch('backend.apps.knowledge_summary_app.get_current_user_info', return_value=mock_user_info):
-        
+
         # Execute test
         response = client.post(
             f"/summary/{test_data['index_name']}/auto_summary",
@@ -243,7 +243,7 @@ def test_change_summary_success(test_data):
     # Execute test with direct patching of route handler function
     with patch('backend.apps.knowledge_summary_app.ElasticSearchService', return_value=mock_service_instance), \
             patch('backend.apps.knowledge_summary_app.get_current_user_id', return_value=test_data["user_id"]):
-        
+
         response = client.post(
             f"/summary/{test_data['index_name']}/summary",
             json=request_data,
@@ -278,7 +278,7 @@ def test_change_summary_exception(test_data):
     # Execute test
     with patch('backend.apps.knowledge_summary_app.ElasticSearchService', return_value=mock_service_instance), \
             patch('backend.apps.knowledge_summary_app.get_current_user_id', return_value=test_data["user_id"]):
-        
+
         response = client.post(
             f"/summary/{test_data['index_name']}/summary",
             json=request_data,
@@ -327,4 +327,4 @@ def test_get_summary_exception(test_data):
 
     # Assertions
     assert response.status_code == 500
-    assert "Failed to get knowledge base summary" in response.json()["detail"]
+    assert "Failed to get knowledge base summary" in response.json()["detail"]

test/backend/services/test_conversation_management_service.py

@@ -79,10 +79,32 @@ def model_dump(self):
 # Also ensure backend.consts.model resolves to our stub for tests that import via backend.consts.model
 sys.modules["backend.consts.model"] = consts_model_mod
 
-# Stub database.client.as_dict to avoid import-time DB helpers
+# Stub database.client to avoid import-time DB helpers
 db_client_stub = types.ModuleType("database.client")
 db_client_stub.as_dict = lambda obj: {}
-db_client_stub.get_db_session = lambda *a, **k: (_ for _ in ()).throw(StopIteration)
+
+# Minimal dummy db_client with clean_string_values and session_maker to satisfy imports.
+db_client_stub.db_client = types.SimpleNamespace(
+    clean_string_values=lambda d: d,
+    session_maker=lambda: None
+)
+
+# Provide a simple context manager compatible get_db_session used with `with get_db_session() as session:`
+class _DummySessionCM:
+    def __enter__(self):
+        # Return a minimal session-like object with methods used in tests (execute, scalars, commit/rollback/close)
+        return types.SimpleNamespace(
+            execute=lambda *a, **k: types.SimpleNamespace(rowcount=0),
+            scalars=lambda *a, **k: types.SimpleNamespace(all=lambda: []),
+            commit=lambda: None,
+            rollback=lambda: None,
+            close=lambda: None,
+        )
+
+    def __exit__(self, exc_type, exc, tb):
+        return False
+
+db_client_stub.get_db_session = lambda *a, **k: _DummySessionCM()
 sys.modules["database.client"] = db_client_stub
 
 # Stub utils.prompt_template_utils to avoid requiring PyYAML

test/backend/services/test_file_management_service.py

@@ -796,11 +796,11 @@ async def test_upload_files_impl_semaphore_usage(self):
 
         with patch('backend.services.file_management_service.save_upload_file', AsyncMock(return_value=True)) as mock_save, \
              patch('backend.services.file_management_service.upload_semaphore') as mock_semaphore:
-            
+
             # Mock semaphore context manager
             mock_semaphore.__aenter__ = AsyncMock()
             mock_semaphore.__aexit__ = AsyncMock()
-            
+
             # Execute
             errors, uploaded_paths, uploaded_names = await upload_files_impl(
                 destination="local", file=[mock_file])
@@ -827,7 +827,7 @@ async def test_upload_files_impl_no_semaphore_for_minio(self):
             {"success": True, "file_name": "test.txt", "object_name": "folder/test.txt"}
         ])) as mock_upload, \
              patch('backend.services.file_management_service.upload_semaphore') as mock_semaphore:
-            
+
             # Execute
             errors, uploaded_paths, uploaded_names = await upload_files_impl(
                 destination="minio", file=[mock_file], folder="folder")
@@ -934,7 +934,8 @@ def test_get_llm_model_success(self, mock_tenant_config, mock_get_model_name, mo
             model_id="gpt-4",
             api_base="http://api.example.com",
             api_key="test_api_key",
-            max_context_tokens=4096
+            max_context_tokens=4096,
+            ssl_verify=True
         )
 
     @patch('backend.services.file_management_service.MODEL_CONFIG_MAPPING', {"llm": "llm_config_key"})

test/backend/services/test_image_service.py

@@ -336,7 +336,8 @@ def test_get_vlm_model_success(mock_tenant_config_manager, mock_get_model_name,
         temperature=0.7,
         top_p=0.7,
         frequency_penalty=0.5,
-        max_tokens=512
+        max_tokens=512,
+        ssl_verify=True
     )
     assert result == mock_model_instance
 
@@ -363,6 +364,7 @@ def test_get_vlm_model_with_empty_config(mock_tenant_config_manager, mock_get_mo
         temperature=0.7,
         top_p=0.7,
         frequency_penalty=0.5,
-        max_tokens=512
+        max_tokens=512,
+        ssl_verify=True
     )
     assert result == mock_model_instance

test/backend/services/test_model_health_service.py

@@ -143,7 +143,8 @@ async def test_perform_connectivity_check_embedding():
             model_name="text-embedding-ada-002",
             base_url="https://api.openai.com",
             api_key="test-key",
-            embedding_dim=0
+            embedding_dim=0,
+            ssl_verify=True
         )
         mock_embedding_instance.dimension_check.assert_called_once()
 
@@ -171,7 +172,8 @@ async def test_perform_connectivity_check_multi_embedding():
             model_name="jina-embeddings-v2",
             base_url="https://api.jina.ai",
             api_key="test-key",
-            embedding_dim=0
+            embedding_dim=0,
+            ssl_verify=True
         )
         mock_embedding_instance.dimension_check.assert_called_once()
 
@@ -236,7 +238,8 @@ async def test_perform_connectivity_check_vlm():
             mock_observer_instance,
             model_id="gpt-4-vision",
             api_base="https://api.openai.com",
-            api_key="test-key"
+            api_key="test-key",
+            ssl_verify=True
         )
         mock_model_instance.check_connectivity.assert_called_once()
 
@@ -645,7 +648,8 @@ async def test_embedding_dimension_check_embedding_success():
             model_name="test-embedding",
             base_url="http://test.com",
             api_key="test-key",
-            embedding_dim=0
+            embedding_dim=0,
+            ssl_verify=True
         )
 
 
@@ -665,7 +669,8 @@ async def test_embedding_dimension_check_multi_embedding_success():
             model_name="test-multi-embedding",
             base_url="http://test.com",
             api_key="test-key",
-            embedding_dim=0
+            embedding_dim=0,
+            ssl_verify=True
         )
 
 
@@ -708,7 +713,7 @@ async def test_embedding_dimension_check_wrapper_success():
         assert dimension == 1536
         mock_get_name.assert_called_once_with(model_config)
         mock_internal_check.assert_called_once_with(
-            "openai/text-embedding-ada-002", "embedding", "https://api.openai.com", "test-key"
+            "openai/text-embedding-ada-002", "embedding", "https://api.openai.com", "test-key", True
         )
 
 
@@ -751,7 +756,8 @@ async def test_embedding_dimension_check_multi_embedding_empty_response():
             model_name="test-multi-embedding",
             base_url="http://test.com",
             api_key="test-key",
-            embedding_dim=0
+            embedding_dim=0,
+            ssl_verify=True
         )
         # Verify warning was logged
         mock_logging.warning.assert_called_once_with(
@@ -780,7 +786,7 @@ async def test_embedding_dimension_check_wrapper_value_error():
         assert dimension == 0
         mock_get_name.assert_called_once_with(model_config)
         mock_internal_check.assert_called_once_with(
-            "test-model", "unsupported", "https://api.test.com", "test-key"
+            "test-model", "unsupported", "https://api.test.com", "test-key", True
         )
         # Verify error was logged with the specific ValueError message
         mock_logger.error.assert_called_once_with(