♻️ Refactor: cleanup data_process_app.py

Author: jiangpeiling

backend/apps/data_process_app.py

@@ -307,7 +307,7 @@ async def convert_state(request: ConvertStateRequest):
     This endpoint converts a process state string to a forward state string.
     """
     try:
-        result = await service.convert_celery_states_to_custom(
+        result = service.convert_celery_states_to_custom(
             process_celery_state=request.process_state or "",
             forward_celery_state=request.forward_state or ""
         )

backend/consts/model.py

@@ -165,30 +165,6 @@ class BatchTaskRequest(BaseModel):
                   ] = Field(..., description="List of source objects to process")
 
 
-class TaskResponse(BaseModel):
-    task_id: str
-
-
-class BatchTaskResponse(BaseModel):
-    task_ids: List[str]
-
-
-class SimpleTaskStatusResponse(BaseModel):
-    id: str
-    task_name: str
-    index_name: str
-    path_or_url: str
-    original_filename: str
-    status: str
-    created_at: float
-    updated_at: float
-    error: Optional[str] = None
-
-
-class SimpleTasksListResponse(BaseModel):
-    tasks: List[SimpleTaskStatusResponse]
-
-
 class IndexingResponse(BaseModel):
     success: bool
     message: str
@@ -320,11 +296,6 @@ class ConvertStateRequest(BaseModel):
     forward_state: str = ""
 
 
-class ConvertStateResponse(BaseModel):
-    """Response schema for /tasks/convert_state endpoint"""
-    state: str
-
-
 # ---------------------------------------------------------------------------
 # Memory Feature Data Models (Missing previously)
 # ---------------------------------------------------------------------------

backend/services/data_process_service.py

@@ -541,7 +541,7 @@ async def process_uploaded_text_file(self, file_content: bytes, filename: str, c
             "chunking_strategy": chunking_strategy
         }
 
-    def convert_celery_states_to_custom(self, process_celery_state: str, forward_celery_state: str) -> str:
+    def convert_celery_states_to_custom(self, process_celery_state: Optional[str], forward_celery_state: Optional[str]) -> str:
         """Map Celery task states to a custom frontend state string.
 
         This implements the business logic that was previously in the app layer.
@@ -554,9 +554,6 @@ def convert_celery_states_to_custom(self, process_celery_state: str, forward_cel
         if process_celery_state == states.SUCCESS and forward_celery_state == states.SUCCESS:
             return "COMPLETED"
 
-        if not process_celery_state and not forward_celery_state:
-            return "WAIT_FOR_PROCESSING"
-
         forward_state_map = {
             states.PENDING: "WAIT_FOR_FORWARDING",
             states.STARTED: "FORWARDING",

test/backend/services/test_data_process_service.py

@@ -1992,7 +1992,7 @@ def test_convert_celery_states_to_custom(self):
             "PROCESSING"
         )
 
-    def test_convert_celery_states_wait_for_processing(self):
+    async def test_convert_celery_states_wait_for_processing(self):
         """
         Cover return "WAIT_FOR_PROCESSING" branches:
         - both states are None
@@ -2023,6 +2023,18 @@ def test_convert_celery_states_wait_for_processing(self):
             "WAIT_FOR_PROCESSING",
         )
 
+    async def test_convert_celery_states_wait_for_processing_empty_strings(self):
+        """
+        Explicitly cover the last-line default return by passing empty strings
+        (falsy values) for both states.
+        """
+        self.assertEqual(
+            self.service.convert_celery_states_to_custom(
+                process_celery_state="", forward_celery_state=""
+            ),
+            "WAIT_FOR_PROCESSING",
+        )
+
     @pytest.mark.asyncio
     async def async_test_convert_to_base64(self):
         """