Skip to content

Commit 79d502a

Browse files
authored
[fix]cherry-pick clean code and set local_rank_size to tp_size (#596) (#600)
[fix]clean code and set local_rank_size to tp_size (#596) clean code and set local_rank_size to tp_size
1 parent ce981c4 commit 79d502a

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

ucm/integration/vllm/ucm_connector.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ def _create_store(
213213
config["block_size"] = chunk_block_size
214214
if self.is_dsa or self.is_mla:
215215
config["share_buffer_enable"] = True
216+
config["local_rank_size"] = self.tp_size
216217
else:
217218
config["share_buffer_enable"] = False
218219
store = UcmConnectorFactoryV1.create_connector(name, config)

ucm/store/pcstore/cc/domain/file/ifile.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class IFile {
5252
using FileStat = struct stat64;
5353

5454
public:
55-
IFile(const std::string& path) : path_{path} {}
55+
explicit IFile(const std::string& path) : path_{path} {}
5656
virtual ~IFile() = default;
5757
const std::string& Path() const { return this->path_; }
5858
virtual Status MkDir() = 0;

ucm/store/pcstore/cc/domain/file/posix_file.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ namespace UC {
3030

3131
class PosixFile : public IFile {
3232
public:
33-
PosixFile(const std::string& path) : IFile{path}, handle_{-1} {}
33+
explicit PosixFile(const std::string& path) : IFile{path}, handle_{-1} {}
3434
~PosixFile() override;
3535
Status MkDir() override;
3636
Status RmDir() override;

ucm/store/pcstore/cc/domain/trans/share_buffer.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ void CleanUpShmFileExceptMe(const std::string& me)
136136
if (now - lwt <= keepThreshold) { continue; }
137137
fs::remove(path);
138138
} catch (...) {
139+
// Ignore filesystem errors;
139140
}
140141
}
141142
}

0 commit comments

Comments
 (0)