Skip to content

Commit 86c7ca0

Browse files
authored
[bugfix] The Metrics module uses a non-existent variable self.rank (#445)
1 parent b6a21fd commit 86c7ca0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

examples/ucm_config_example.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ ucm_connectors:
1616

1717
load_only_first_rank: false
1818

19-
metrics_config_path: "/vllm-workspace/metrics_config.yaml"
19+
# Enable UCM metrics so they can be monitored online via Grafana and Prometheus.
20+
# metrics_config_path: "/workspace/unified-cache-management/examples/metrics/metrics_configs.yaml"
2021

2122
# Sparse attention configuration
2223
# Format 1: Dictionary format (for methods like ESA, KvComp)

ucm/integration/vllm/ucm_connector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ def __init__(self, vllm_config: "VllmConfig", role: KVConnectorRole):
174174
if self.metrics_config:
175175
self.stats_logger = UCMStatsLogger(
176176
vllm_config.model_config.served_model_name,
177-
self.rank,
177+
self.global_rank,
178178
self.metrics_config,
179179
)
180180
self.monitor = ucmmonitor.StatsMonitor.get_instance()

0 commit comments

Comments
 (0)