diff --git a/ucm/integration/vllm/ucm_connector.py b/ucm/integration/vllm/ucm_connector.py index 9b1d1350b..d81ee177b 100644 --- a/ucm/integration/vllm/ucm_connector.py +++ b/ucm/integration/vllm/ucm_connector.py @@ -213,6 +213,7 @@ def _create_store( config["block_size"] = chunk_block_size if self.is_dsa or self.is_mla: config["share_buffer_enable"] = True + config["local_rank_size"] = self.tp_size else: config["share_buffer_enable"] = False store = UcmConnectorFactoryV1.create_connector(name, config) diff --git a/ucm/store/pcstore/cc/domain/file/ifile.h b/ucm/store/pcstore/cc/domain/file/ifile.h index 512c33ba4..c038f9d3d 100644 --- a/ucm/store/pcstore/cc/domain/file/ifile.h +++ b/ucm/store/pcstore/cc/domain/file/ifile.h @@ -52,7 +52,7 @@ class IFile { using FileStat = struct stat64; public: - IFile(const std::string& path) : path_{path} {} + explicit IFile(const std::string& path) : path_{path} {} virtual ~IFile() = default; const std::string& Path() const { return this->path_; } virtual Status MkDir() = 0; diff --git a/ucm/store/pcstore/cc/domain/file/posix_file.h b/ucm/store/pcstore/cc/domain/file/posix_file.h index 75c6f0271..3b6a026d8 100644 --- a/ucm/store/pcstore/cc/domain/file/posix_file.h +++ b/ucm/store/pcstore/cc/domain/file/posix_file.h @@ -30,7 +30,7 @@ namespace UC { class PosixFile : public IFile { public: - PosixFile(const std::string& path) : IFile{path}, handle_{-1} {} + explicit PosixFile(const std::string& path) : IFile{path}, handle_{-1} {} ~PosixFile() override; Status MkDir() override; Status RmDir() override; diff --git a/ucm/store/pcstore/cc/domain/trans/share_buffer.cc b/ucm/store/pcstore/cc/domain/trans/share_buffer.cc index ddcf69546..00ab6eb20 100644 --- a/ucm/store/pcstore/cc/domain/trans/share_buffer.cc +++ b/ucm/store/pcstore/cc/domain/trans/share_buffer.cc @@ -136,6 +136,7 @@ void CleanUpShmFileExceptMe(const std::string& me) if (now - lwt <= keepThreshold) { continue; } fs::remove(path); } catch (...) { + // Ignore filesystem errors; } } }