Skip to content

Commit e37913a

Browse files
committed
Rewording of NEWS and CRAN comments
1 parent d0001d0 commit e37913a

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

NEWS.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
# kernelshap 0.9.0
22

3-
### Major bug fix
3+
### Bug fix
44

5-
`kernelshap()` used a wrong weighting logic, leading to values slightly off. This has
6-
been fixed with the help of Prof Mario Wuethrich of ETHZ and Ian Covert and his
7-
[wonderful Github repo](https://github.com/iancovert/shapley-regression).
8-
Now, exact Kernel SHAP returns identical values as exact permutation SHAP.
9-
All variants of `kernelshap()` had been affected by this (exact, sampling, hybrid).
10-
For models with interactions up to two, the bug had no consequences - which is why
11-
it went unnoticed.
5+
With input from Mario Wuethrich and Ian Covert and his [repo](https://github.com/iancovert/shapley-regression),
6+
we have fixed a bug in how `kernelshap()` calculates Kernel weights.
127

13-
Fixed in [#168](https://github.com/ModelOriented/kernelshap/pull/168).
8+
- The differences caused by this are typically very small.
9+
- Models with interactions of order up to two have been unaffected.
10+
- Exact Kernel SHAP now provides identical results to exact permutation SHAP.
11+
12+
Fixed in [#168](https://github.com/ModelOriented/kernelshap/pull/168), which also has received
13+
unit tests against Python's "shap".
1414

1515
### API
1616

cran-comments.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
1-
# kernelshap 0.9.0 (MAJOR BUG FIX)
1+
# kernelshap 0.9.0
22

3-
We have figured out a major bug in the weighting logic of Kernel SHAP.
3+
We have figured out a bug in the weighting logic of Kernel SHAP.
44

5-
This update comes with a fix which has been tested also against different
6-
Python algorithms.
5+
This update comes with a fix which has been tested against two other implementations.
76

8-
I know that summer holidays are ahead, and the last release is not long ago,
9-
but I would love to see this change on CRAN very soon.
7+
I am aware that the last release of {kernelshap} is not too long ago, but I still would love to see
8+
this fixed before the (well-deserved) summer break.
109

11-
Michael
10+
Thanks a lot!
1211

1312
## Checks
1413

0 commit comments

Comments
 (0)