Merge pull request #22 from bluelhf/fix/function-property-stack-order

Fix stack ordering problems in function property

Author: Moderocky

src/main/java/org/byteskript/skript/lang/syntax/function/ExprFunctionProperty.java

@@ -106,8 +106,6 @@ public void preCompile(Context context, Pattern.Match match) throws Throwable {
         for (final ElementTree tree : context.getCompileCurrent().nested()) {
             tree.takeAtomic = true;
         }
-        final String name = ((FunctionDetails) match.meta()).name();
-        context.getMethod().writeCode(WriteInstruction.loadConstant(name)); // ldc name
         final ElementTree[] nested = context.getCompileCurrent().nested();
         if (nested.length < 2) return;
         final ElementTree tree = nested[nested.length - 1]; // swap object order before array pack
@@ -138,6 +136,11 @@ public void compile(Context context, Pattern.Match match) throws Throwable {
             target.writeCode(WriteInstruction.returnObject());
         }
         method.writeCode(WriteInstruction.invokeStatic(builder.getType(), erasure)); // pack array
+        final String name = ((FunctionDetails) match.meta()).name();
+        context.getMethod().writeCode(WriteInstruction.loadConstant(name));
+        // shuffle stack from (source, params, name) -> (name, source, params)
+        method.writeCode(WriteInstruction.duplicateDrop3());
+        method.writeCode(WriteInstruction.pop());
         this.writeCall(method, findMethod(Metafactory.class, "callFunction", String.class, Object.class, Object[].class), context);
     }