Skip to content

Commit 98c23ea

Browse files
authored
Merge pull request #4 from ModestCoders/update-nodephp-image
Update nodephp image
2 parents e5d2014 + 4125262 commit 98c23ea

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ Example: `docker-compose run --rm unison watch -path vendor/<company_name>/<modu
127127
2. Grunt watch
128128

129129
```
130-
docker-compose run --rm node sh "grunt exec:<theme>"
131-
docker-compose run --rm node sh "grunt watch"
130+
docker-compose run --rm node sh -c "grunt exec:<theme>"
131+
docker-compose run --rm node sh -c "grunt watch"
132132
```
133133

134134
## Xdebug

config/docker/image/node/Dockerfile

Lines changed: 0 additions & 7 deletions
This file was deleted.

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ services:
5959
privileged: true
6060

6161
node:
62-
build: ./config/docker/image/node
62+
image: modestcoders/node-php:node8-php7.1
6363
volumes: *appvolumes
6464
environment:
6565
- NPM_CONFIG_PREFIX=/home/app/.npm-global # To avoid permission error on npm install. It tries to save it at /var/www (root is the owner)

0 commit comments

Comments
 (0)