refactor: Remove 'keyMedicalTerms' from MedicalDocumentAnalysis and related tests for simplification

Author: adamrefaey

backend/src/app.module.spec.ts

@@ -49,7 +49,6 @@ describe('AppModule', () => {
       .useValue({
         generateResponse: vi.fn().mockResolvedValue('test response'),
         analyzeMedicalDocument: vi.fn().mockResolvedValue({
-          keyMedicalTerms: [],
           labValues: [],
           diagnoses: [],
           metadata: {

backend/src/document-processor/services/aws-bedrock.service.spec.ts

@@ -67,10 +67,6 @@ vi.mock('@aws-sdk/client-bedrock-runtime', () => {
                   text: JSON.stringify({
                     title: 'Blood Test Results',
                     category: 'general',
-                    keyMedicalTerms: [
-                      { term: 'RBC', definition: 'Red Blood Cells' },
-                      { term: 'WBC', definition: 'White Blood Cells' },
-                    ],
                     labValues: [
                       {
                         name: 'Hemoglobin',
@@ -133,10 +129,6 @@ describe('AwsBedrockService', () => {
   const mockMedicalAnalysis: MedicalDocumentAnalysis = {
     title: 'Blood Test Results',
     category: 'general',
-    keyMedicalTerms: [
-      { term: 'RBC', definition: 'Red Blood Cells' },
-      { term: 'WBC', definition: 'White Blood Cells' },
-    ],
     labValues: [
       {
         name: 'Hemoglobin',
@@ -299,10 +291,8 @@ describe('AwsBedrockService', () => {
       const invalidResponses = [
         null,
         {},
-        { keyMedicalTerms: 'not an array' },
-        { keyMedicalTerms: [], labValues: [], diagnoses: [] }, // Missing metadata
+        { labValues: [], diagnoses: [] }, // Missing metadata
         {
-          keyMedicalTerms: [],
           labValues: [],
           diagnoses: [],
           metadata: { isMedicalReport: 'not a boolean', confidence: 0.5, missingInformation: [] },
@@ -320,7 +310,6 @@ describe('AwsBedrockService', () => {
       const validResponse: MedicalDocumentAnalysis = {
         title: 'Test Report',
         category: 'general',
-        keyMedicalTerms: [],
         labValues: [],
         diagnoses: [],
         metadata: {

backend/src/document-processor/services/aws-bedrock.service.ts

@@ -14,7 +14,6 @@ import { createHash } from 'crypto';
 export interface MedicalDocumentAnalysis {
   title: string;
   category: string;
-  keyMedicalTerms: Array<{ term: string; definition: string }>;
   labValues: Array<{
     name: string;
     value: string;
@@ -50,18 +49,16 @@ export class AwsBedrockService {
 Look for and extract the following information:
 1. Document title or main subject based on content
 2. Document category based on organ system focus
-3. Key medical terms visible in the document with their definitions
-4. Lab test values with their normal ranges and whether they are normal, high, or low (particularly important for blood work, metabolic panels, etc.)
-5. Any diagnoses, findings, or medical observations with details and recommendations
-6. Analyze if this is a medical document (lab report, test result, medical chart, prescription, etc.) and provide confidence level
+3. Lab test values with their normal ranges and whether they are normal, high, or low (particularly important for blood work, metabolic panels, etc.)
+4. Any diagnoses, findings, or medical observations with details and recommendations
+5. Analyze if this is a medical document (lab report, test result, medical chart, prescription, etc.) and provide confidence level
 
 This document may be a lab report showing blood work or other test results, so please pay special attention to tables, numeric values, reference ranges, and medical terminology.
 
 Format the response as a JSON object with the following structure:
 {
   "title": string,
   "category": string,
-  "keyMedicalTerms": [{"term": string, "definition": string}],
   "labValues": [{"name": string, "value": string, "unit": string, "normalRange": string, "status": "normal" | "high" | "low", "conclusion": string, "suggestions": string}],
   "diagnoses": [{"condition": string, "details": string, "recommendations": string}],
   "metadata": {
@@ -116,16 +113,16 @@ INCORRECT RESPONSE FORMATS (DO NOT DO THESE):
 "This appears to be a medical report. Here is the information extracted in the requested JSON format:
 
 {
-  \"keyMedicalTerms\": [...],
+  \"category\": \"heart\",
   ...
 }"
 
 2) DO NOT DO THIS - Nested JSON:
 {
-  "keyMedicalTerms": [
+  "labValues": [
     {
-      "term": "Here is the information extracted",
-      "definition": "{\"keyMedicalTerms\": [{\"term\": \"RBC\", \"definition\": \"Red blood cells\"}]}"
+      "name": "Here is the information extracted",
+      "value": "{\"labValues\": [{\"name\": \"RBC\", \"value\": \"14.2\"}]}"
     }
   ]
 }
@@ -134,10 +131,6 @@ CORRECT FORMAT (DO THIS):
 {
   "title": "Complete Blood Count Results",
   "category": "heart",
-  "keyMedicalTerms": [
-    {"term": "RBC", "definition": "Red blood cells"},
-    {"term": "WBC", "definition": "White blood cells"}
-  ],
   "labValues": [
     {
       "name": "Hemoglobin", 
@@ -432,7 +425,6 @@ Document text:
       !response ||
       typeof response.title !== 'string' ||
       typeof response.category !== 'string' ||
-      !Array.isArray(response.keyMedicalTerms) ||
       !Array.isArray(response.labValues) ||
       !Array.isArray(response.diagnoses) ||
       !response.metadata

backend/src/document-processor/services/document-processor.service.spec.ts

@@ -36,7 +36,6 @@ describe('DocumentProcessorService', () => {
       const medicalAnalysis = {
         title: 'Test Report',
         category: 'general',
-        keyMedicalTerms: [],
         labValues: [],
         diagnoses: [],
         metadata: {
@@ -148,7 +147,6 @@ describe('DocumentProcessorService', () => {
         analysis: {
           title: 'Document 1 Report',
           category: 'general',
-          keyMedicalTerms: [],
           labValues: [],
           diagnoses: [],
           metadata: {
@@ -174,7 +172,6 @@ describe('DocumentProcessorService', () => {
         analysis: {
           title: 'Document 2 Report',
           category: 'general',
-          keyMedicalTerms: [],
           labValues: [],
           diagnoses: [],
           metadata: {

backend/src/document-processor/services/document-processor.service.ts

@@ -84,7 +84,6 @@ export class DocumentProcessorService {
       this.logger.log(`Document processing completed in ${processingTime}ms`, {
         isMedicalReport: analysis.metadata.isMedicalReport,
         confidence: analysis.metadata.confidence,
-        keyTermCount: analysis.keyMedicalTerms.length,
         labValueCount: analysis.labValues.length,
         hasExplanation: !!simplifiedExplanation,
       });
@@ -156,7 +155,6 @@ export class DocumentProcessorService {
           analysis: {
             title: 'Failed Document',
             category: 'general',
-            keyMedicalTerms: [],
             labValues: [],
             diagnoses: [],
             metadata: {

backend/src/services/README.md

@@ -59,7 +59,6 @@ The structured medical information from Bedrock:
 
 ```typescript
 export interface MedicalDocumentAnalysis {
-  keyMedicalTerms: Array<{ term: string; definition: string }>;
   labValues: Array<{
     name: string;
     value: string;
@@ -111,9 +110,6 @@ curl -X POST \
     ]
   },
   "analysis": {
-    "keyMedicalTerms": [
-      { "term": "Hemoglobin", "definition": "Oxygen-carrying protein in red blood cells" }
-    ],
     "labValues": [
       {
         "name": "Hemoglobin",