refactor: Remove findByFilePath method to streamline report retrieval process

Author: adamrefaey

backend/src/reports/reports.service.ts

@@ -333,106 +333,6 @@ export class ReportsService {
     }
   }
 
-  /**
-   * Find a report by its filePath
-   * @param filePath The S3 path of the file
-   * @param userId User ID for authorization
-   * @returns Report record if found
-   */
-  async findByFilePath(filePath: string, userId: string): Promise<Report | null> {
-    if (!filePath) {
-      throw new NotFoundException('File path is required');
-    }
-
-    if (!userId) {
-      throw new ForbiddenException('User ID is required');
-    }
-
-    // Log the actual filePath being searched for debugging
-    this.logger.log(`Searching for report with filePath: "${filePath}" for user ${userId}`);
-
-    try {
-      const command = new QueryCommand({
-        TableName: this.tableName,
-        KeyConditionExpression: 'userId = :userId',
-        FilterExpression: 'filePath = :filePath',
-        ExpressionAttributeValues: marshall({
-          ':userId': userId,
-          ':filePath': filePath,
-        }),
-        Limit: 1, // We only want one record
-      });
-
-      this.logger.log('Executing QueryCommand with params:', {
-        TableName: this.tableName,
-        KeyConditionExpression: 'userId = :userId',
-        FilterExpression: 'filePath = :filePath',
-        Values: {
-          userId,
-          filePath,
-        },
-      });
-
-      const response = await this.dynamoClient.send(command);
-
-      this.logger.log(`Query response received, found ${response.Items?.length || 0} items`);
-
-      if (!response.Items || response.Items.length === 0) {
-        // If no exact match, try with case-insensitive comparison as a fallback
-        this.logger.log('No exact match found, trying with case-insensitive search');
-
-        // Get all items for the user and filter manually for case-insensitive match
-        const allUserItemsCommand = new QueryCommand({
-          TableName: this.tableName,
-          KeyConditionExpression: 'userId = :userId',
-          ExpressionAttributeValues: marshall({
-            ':userId': userId,
-          }),
-        });
-
-        const allUserResponse = await this.dynamoClient.send(allUserItemsCommand);
-
-        if (!allUserResponse.Items || allUserResponse.Items.length === 0) {
-          return null;
-        }
-
-        // Convert items and find case-insensitive match
-        const allReports = allUserResponse.Items.map(item => unmarshall(item) as Report);
-        const matchingReport = allReports.find(
-          report => report.filePath.toLowerCase() === filePath.toLowerCase(),
-        );
-
-        if (matchingReport) {
-          this.logger.log(
-            `Found case-insensitive match for ${filePath}: ${matchingReport.filePath}`,
-          );
-
-          return matchingReport;
-        }
-
-        return null;
-      }
-
-      const result = unmarshall(response.Items[0]) as Report;
-      this.logger.log(`Found report with ID ${result.id}`);
-
-      return result;
-    } catch (error: unknown) {
-      this.logger.error(`Error finding report with filePath ${filePath}:`);
-      this.logger.error(error);
-
-      if (error instanceof DynamoDBServiceException) {
-        if (error.name === 'ResourceNotFoundException') {
-          throw new InternalServerErrorException(
-            `Table "${this.tableName}" not found. Please check your database configuration.`,
-          );
-        }
-      }
-
-      throw new InternalServerErrorException(`Failed to fetch report with filePath ${filePath}`);
-    }
-  }
-
   /**
    * Update a report with new data
    * @param report Updated report object