generated from ModusCreateOrg/template
-
Notifications
You must be signed in to change notification settings - Fork 0
[ADE-203] UI fixes #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
[ADE-203] UI fixes #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry wrapper and adjust margin styles for better layout
…to enhance layout and readability
…ab to enhance layout and readability
…t and readability
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR applies several UI fixes by streamlining JSX formatting and updating inline arrow functions and destructuring syntax to improve code readability and consistency.
- Simplified JSX formatting in AiAssistantNotice.tsx, ActionButtons.tsx, ConfirmationModal.tsx, and SvgIcon.tsx.
- Updated arrow function syntax and inline formatting in ReportsListPage.tsx and removed an unused debouncing variable in ProcessingPage.tsx.
- Adjusted spacing in UploadModal.tsx and standardized test mocks in TabNavigation.test.tsx.
Reviewed Changes
Copilot reviewed 24 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/pages/Reports/components/AiAssistantNotice.tsx | Simplified JSX formatting for the assistant notice element. |
| frontend/src/pages/Reports/components/ActionButtons.tsx | Consolidated prop destructuring in the functional component. |
| frontend/src/pages/Reports/ReportsListPage.tsx | Updated arrow function formatting and minor inline improvements. |
| frontend/src/pages/Processing/ProcessingPage.tsx | Removed the debouncing variable and related check, streamlining logic. |
| frontend/src/common/components/Upload/UploadModal.tsx | Adjusted file details spacing for better readability. |
| frontend/src/common/components/Router/tests/TabNavigation.test.tsx | Standardized mock declarations with trailing commas. |
| frontend/src/common/components/Modal/ConfirmationModal.tsx | Cleaned up multiline JSX to a more concise format. |
| frontend/src/common/components/Icon/SvgIcon.tsx | Optimized className composition using a single-line format. |
Files not reviewed (10)
- .husky/pre-commit: Language not supported
- backend/package.json: Language not supported
- frontend/package.json: Language not supported
- frontend/src/common/components/Icon/SvgIcon.scss: Language not supported
- frontend/src/common/components/Modal/ConfirmationModal.scss: Language not supported
- frontend/src/common/components/Router/TabNavigation.scss: Language not supported
- frontend/src/pages/Home/components/ReportItem/ReportItem.scss: Language not supported
- frontend/src/pages/Processing/ProcessingPage.scss: Language not supported
- frontend/src/pages/Reports/ReportsListPage.scss: Language not supported
- frontend/src/pages/Reports/components/AiAssistantNotice.scss: Language not supported
GuidoBR
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This pull request introduces several improvements across the frontend and backend codebases, focusing on enhancing code quality, consistency, and maintainability. Key changes include the addition of
lint-stagedfor pre-commit hooks, updates to CSS styles for consistency, and formatting adjustments in React components. Below is a breakdown of the most important changes:Pre-commit Hook Enhancements:
.husky/pre-committo includenpx lint-stagedfor both frontend and backend directories, ensuring staged files are linted and formatted before committing.Linting and Formatting:
lint-stagedconfigurations inbackend/package.jsonandfrontend/package.jsonto automatically run Prettier and ESLint on staged files. [1] [2]CSS and Styling Consistency:
#ABBCCD→#abbccd). Changes were made inSvgIcon.scss,TabNavigation.scss,ReportItem.scss,ReportsListPage.scss, and others. [1] [2] [3] [4] [5]ProcessingPage.scssto improve layout and readability. [1] [2]React Component Formatting:
SvgIcon.tsx,ConfirmationModal.tsx,ReportsListPage.tsx, andActionButtons.tsx. [1] [2] [3] [4]Code Simplification:
lastTriggeredTimelogic inProcessingPage.tsxto simplify the error handling and API request logic. [1] [2]Does this PR introduce a breaking change?
{...}
What needs to be documented once your changes are merged?
{...}
Additional Comments
{...}