Skip to content

Conversation

@adamrefaey
Copy link
Collaborator

Change

UI fixes

Does this PR introduce a breaking change?

{...}

What needs to be documented once your changes are merged?

{...}

Additional Comments

{...}

@adamrefaey adamrefaey requested review from GuidoBR and Copilot May 6, 2025 18:58
@adamrefaey adamrefaey self-assigned this May 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces UI fixes on the sign-in page by reorganizing the form layout and adjusting label formatting for improved clarity and alignment.

  • Added a container div with the class "ls-signin-form__fields" to group related form fields.
  • Reformatted the password label to span multiple lines.
Files not reviewed (3)
  • frontend/src/common/utils/i18n/resources/en/auth.json: Language not supported
  • frontend/src/pages/Auth/SignIn/SignInPage.scss: Language not supported
  • frontend/src/pages/Auth/SignIn/components/SignInForm.scss: Language not supported
Comments suppressed due to low confidence (2)

frontend/src/pages/Auth/SignIn/components/SignInForm.tsx:151

  • Ensure that the newly introduced wrapper div has corresponding CSS adjustments to maintain consistent spacing and alignment across different viewports.
<div className="ls-signin-form__fields">

frontend/src/pages/Auth/SignIn/components/SignInForm.tsx:167

  • [nitpick] Confirm that the updated multi-line formatting for the password label matches the styling patterns used for other labels within the application for uniformity.
<label className="ls-signin-form__label">

@GuidoBR GuidoBR merged commit 6abb23e into main May 6, 2025
1 check passed
@adamrefaey adamrefaey deleted the ADE-200-Adam-fixes branch May 6, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants