Path Sanitization

[jpfieber]

I'm just starting with Moe, was able to import a bunch of albums, and created a simple plugin (had Claude do it for me) to move 'The ' to the end of artists name. I've created a new album path album_path = "{album.artist} - {album.year} - {album.title}" in config.toml, and when I do a moe move -n it shows the new paths, but then when I do a moe move it errors. Looks like it's trying to use a colon in the file path (and the path is very long):

OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\Users\\jpfie\\Music\\Library2\\Sergei Rachmaninoff, Pyotr Ilyich Tchaikovsky; Simon Trpčeski, BBC Symphony Orchestra, BBC Philharmonic, Sir Andrew Davis, Gianandrea Noseda - 2010 - BBC Music, Volume 18, Number 12∶ Rachmaninov∶ Rhapsody on a Theme by Paganini ⁄ Tchaikovsky∶ Symphony no․ 3'

Is file path sanitization not already part of Moe? I'm on Windows 11, installed via pipx.

[jtpavlock]

You are correct that Moe handles path sanitization. It seems that the file path you're using contains unicode special characters for the colon and forward slash that are not properly handled in moe. I'm guessing if you replaced the colons and forward slashes with ones you can type on your keyboard you'd fix the issue. In the meantime though I can make a fix to handle those special characters in Moe.

Another solution would be to enable the asciify_paths configuration option.

[jpfieber]

Thanks for the quick response. I did just try asciify_paths = true but it still chokes. Here's what Claude had to say about the error:

The issue is with the colon (:) in the album title - Windows doesn't allow colons in filenames. The asciify_paths = true setting should handle this, but it's not converting the ∶ character (which is a Unicode "ratio" character U+2236, not a regular colon).

I know I can modify the tags to get rid of it, but there's always the concern that it could happen again on a different album, so if you have a solution that would mitigate this general issue, it would be better for Moe.

[jtpavlock]

Ah, sorry. asciify_paths isn't working because it assumes the path is already sanitized, and it isn't getting sanitized properly because I haven't accounted for these unicode characters yet.

I have a PR that will permanently fix this in Moe. In the meantime, you could try to sanitize the characters or replace them yourself in your plugin. This might be useful if you have many tracks with tags with these special unicode colons and forward slashes.